Files
OmniRoute/tests/unit/reasoning-token-buffer-9507.test.ts
Praveen K Palaniswamy 65e81158ab fix(ollama): route models by advertised capability (#11088)
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host.

Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean.

Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
2026-08-23 11:45:01 -03:00

45 lines
1.6 KiB
TypeScript

/**
* #9507 — client max_tokens must NEVER be rewritten upward by the
* reasoning-token buffer. Core contract from #1761: OmniRoute must not
* silently enlarge a Claude Max user's per-turn cost.
*
* On claude-opus-5 (registry maxOutputTokens = 128000), a client sending
* max_tokens: 64000 got rewritten to 96000 (Math.ceil(64000 * 1.5)) because
* 96000 < 128000 so the "fits in cap" guard did NOT rescue it.
*/
import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-9507-"));
process.env.DATA_DIR = TEST_DATA_DIR;
const core = await import("../../src/lib/db/core.ts");
const { resolveReasoningBufferedMaxTokens } =
await import("../../open-sse/services/reasoningTokenBuffer.ts");
test.after(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true });
});
test("#9507 reasoning buffer does NOT enlarge a Claude opus-5 client budget upward", () => {
const result = resolveReasoningBufferedMaxTokens("anthropic/claude-opus-5", 64000);
assert.equal(
result,
64000,
`client max_tokens=64000 must be forwarded verbatim, got ${result} (x1.5 upward rewrite)`
);
});
test("#9507 reasoning buffer does NOT enlarge a Claude sonnet-5 client budget upward", () => {
const client = 32000;
const result = resolveReasoningBufferedMaxTokens("anthropic/claude-sonnet-5", client);
assert.ok(
result === null || result <= client,
`client max_tokens=${client} must not be enlarged, got ${result}`
);
});