mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-17 12:22:34 +03:00
65e81158ab
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host. Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean. Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
70 lines
2.7 KiB
TypeScript
70 lines
2.7 KiB
TypeScript
import { test } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import { syncStandaloneNativeAssets } from "../../scripts/build/assembleStandalone.mjs";
|
|
|
|
/**
|
|
* Repro #8847: better-sqlite3 prebuilds are not included in the standalone
|
|
* bundle, so the bundled app fails when the platform's prebuild is needed
|
|
* (e.g. under Bun, which resolves the native binary via prebuilds/ rather
|
|
* than build/Release/).
|
|
*
|
|
* The test creates a synthetic node_modules/better-sqlite3/ tree with both
|
|
* the compiled build/Release/ binary AND the prebuilds/ directory, then
|
|
* confirms that syncStandaloneNativeAssets copies both into the standalone
|
|
* output. On the unfixed code this fails because NATIVE_ASSET_ENTRIES only
|
|
* lists better-sqlite3/build/.
|
|
*/
|
|
test("repro-8847: better-sqlite3 prebuilds are bundled alongside the compiled binary", async () => {
|
|
const tmp = fs.mkdtempSync(path.join(os.tmpdir(), "repro-8847-"));
|
|
const projectRoot = path.join(tmp, "src-root");
|
|
|
|
// Seed better-sqlite3 with both build/Release/ and prebuilds/.
|
|
const bsqlDir = path.join(projectRoot, "node_modules", "better-sqlite3");
|
|
fs.mkdirSync(path.join(bsqlDir, "build", "Release"), { recursive: true });
|
|
fs.writeFileSync(
|
|
path.join(bsqlDir, "build", "Release", "better_sqlite3.node"),
|
|
"// native binary placeholder"
|
|
);
|
|
fs.mkdirSync(path.join(bsqlDir, "prebuilds"), { recursive: true });
|
|
for (const target of [
|
|
"darwin-arm64.node",
|
|
"darwin-x64.node",
|
|
"linux-arm64.node",
|
|
"linux-x64.node",
|
|
"linuxmusl-arm64.node",
|
|
"linuxmusl-x64.node",
|
|
"win32-arm64.node",
|
|
"win32-x64.node",
|
|
]) {
|
|
fs.writeFileSync(path.join(bsqlDir, "prebuilds", target), `// ${target}`);
|
|
}
|
|
|
|
const outDir = path.join(tmp, "standalone");
|
|
fs.mkdirSync(outDir, { recursive: true });
|
|
|
|
// Act: copy native assets into the standalone output.
|
|
await syncStandaloneNativeAssets(projectRoot, fs.promises, { log() {} }, outDir);
|
|
|
|
// Assert: the compiled build/Release/ binary was copied.
|
|
assert.ok(
|
|
fs.existsSync(
|
|
path.join(outDir, "node_modules", "better-sqlite3", "build", "Release", "better_sqlite3.node")
|
|
),
|
|
"compiled native binary (build/Release/) must be in the standalone bundle"
|
|
);
|
|
|
|
// Assert: the prebuilds/ directory was also copied.
|
|
const prebuildsDir = path.join(outDir, "node_modules", "better-sqlite3", "prebuilds");
|
|
assert.ok(fs.existsSync(prebuildsDir), "prebuilds/ directory must be in the standalone bundle");
|
|
|
|
// Assert: at least one prebuild file was copied.
|
|
assert.ok(
|
|
fs.existsSync(path.join(prebuildsDir, "linux-x64.node")),
|
|
"linux-x64 prebuild must be in the standalone bundle"
|
|
);
|
|
|
|
fs.rmSync(tmp, { recursive: true, force: true });
|
|
}); |