Files
OmniRoute/tests/unit/repro-8956.test.ts
Praveen K Palaniswamy 65e81158ab fix(ollama): route models by advertised capability (#11088)
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host.

Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean.

Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
2026-08-23 11:45:01 -03:00

66 lines
2.8 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const { resolveProjectRoot } = await import("../../src/lib/system/autoUpdate.ts");
test("repro-8956: resolveProjectRoot skips synthetic .build/next/package.json (no name field)", () => {
const tmp = fs.mkdtempSync(path.join(os.tmpdir(), "repro-8956-"));
try {
// Simulate a Next.js standalone build layout inside a real repo:
// <tmp>/repo/.git/ (real git marker)
// <tmp>/repo/package.json (real repo root, has a "name" field)
// <tmp>/repo/.build/next/package.json (synthetic marker, {"type":"commonjs"}, no name)
// <tmp>/repo/.build/next/server/chunks/ (where the bundled module lives at runtime)
const repoRoot = path.join(tmp, "repo");
const buildPkgDir = path.join(repoRoot, ".build", "next");
const chunksDir = path.join(buildPkgDir, "server", "chunks");
fs.mkdirSync(path.join(repoRoot, ".git"), { recursive: true });
fs.mkdirSync(chunksDir, { recursive: true });
// Real root package.json with a name
fs.writeFileSync(path.join(repoRoot, "package.json"), JSON.stringify({ name: "omniroute" }));
// Synthetic Next.js standalone build marker — no "name" field
fs.writeFileSync(path.join(buildPkgDir, "package.json"), JSON.stringify({ type: "commonjs" }));
// Start from the chunks dir (simulating __dirname at runtime)
const root = resolveProjectRoot("/fallback", chunksDir);
// Must NOT stop at .build/next — must walk up to the repo root that has .git
assert.equal(
root,
repoRoot,
`resolveProjectRoot returned ${root}, expected the repo root ${repoRoot} ` +
"(it stopped at the synthetic .build/next/package.json marker)"
);
// The resolved root must own .git so source-mode validation passes
assert.ok(
fs.existsSync(path.join(root, ".git")),
`PROJECT_ROOT resolved to ${root}, which lacks .git`
);
} finally {
fs.rmSync(tmp, { recursive: true, force: true });
}
});
test("repro-8956: resolveProjectRoot still finds package.json with a name field", () => {
const tmp = fs.mkdtempSync(path.join(os.tmpdir(), "repro-8956-named-"));
try {
// A normal repo root: has .git AND a named package.json
const repoRoot = path.join(tmp, "my-repo");
const subDir = path.join(repoRoot, "some", "deep", "path");
fs.mkdirSync(subDir, { recursive: true });
fs.writeFileSync(path.join(repoRoot, "package.json"), JSON.stringify({ name: "my-app" }));
fs.mkdirSync(path.join(repoRoot, ".git"), { recursive: true });
const root = resolveProjectRoot("/fallback", subDir);
assert.equal(root, repoRoot);
} finally {
fs.rmSync(tmp, { recursive: true, force: true });
}
});