Files
OmniRoute/tests/unit/api-key-rotator-health.test.ts
Diego Rodrigues de Sa e Souza f5073604b3 Release/v3.8.0 (#2430)
* fix(cli-tools): guard modelId type before calling indexOf

E2E shakedown v3.8.0: cli-tools quebrava com TypeError quando dynamicModels
continha entradas sem .id (objeto retornado diretamente em vez de string).

* fix(offline): avoid SSR/CSR hydration mismatch on navigator.onLine

Replace useState+lazy-initializer with useSyncExternalStore so the server
snapshot (() => false) and client snapshot (() => navigator.onLine) are
declared separately. React hydrates with the server value and switches to
the real online status client-side without a mismatch.

* chore(i18n): add missing en.json keys for translator, cli-tools, memory, onboarding

Adds 58 missing keys identified by the new dashboard audit script:
- cliTools: 18 custom CLI builder keys (CustomCliCard)
- translator: 24 keys covering stream transformer, live monitor, test bench
- memory: 12 health/pagination/dialog keys
- onboarding.tier: 8 keys for the tier tour walkthrough

Also adds scripts/i18n/audit-dashboard-pages.mjs which scans all dashboard
pages, reports t() calls referencing missing en.json keys, and flags
candidate hardcoded JSX/attribute strings.

* chore(i18n): replace hardcoded UI text with t() calls across dashboard (round 1)

Subagents refactored 8 high-impact dashboard pages, replacing 81 of the
407 hardcoded English/PT strings flagged by the audit with proper
useTranslations() lookups. Added 73 corresponding keys to en.json across
the home, apiManager, providers, settings, and usage namespaces.

Pages affected:
- BudgetTab (27 → 0)
- HomePageClient (2 → 0)
- RoutingTab (25 → 7)
- ResilienceTab (38 → 18)
- SystemStorageTab (42 → 21)
- providers/[id] (17 → 15)
- ApiManagerPageClient (14 → 13)
- OneproxyTab (13 → 10)

Also adds two helper scripts:
- scripts/i18n/extract-keys-from-diff.mjs — extracts new keys from git diff
- scripts/i18n/merge-keys.mjs — merges a pending-keys JSON into en.json

Remaining hardcoded strings will be addressed in follow-up rounds.

* chore(i18n): replace hardcoded UI text with t() calls across dashboard (round 2)

Continues round 1 (commit 8d34f4c65). Round-2 subagents refactored
additional dashboard pages, replacing 77 more hardcoded strings with
useTranslations() lookups. Added 79 corresponding keys to en.json
across the a2aDashboard, agents, analytics, apiManager, cliTools,
common, and settings namespaces.

Pages affected:
- a2a/page (new useTranslations + 6 keys)
- agent-skills/page (new useTranslations + 9 keys)
- AutoRoutingAnalyticsTab (new useTranslations + 6 keys)
- AppearanceTab (8 → 6 remaining)
- OneproxyTab (10 → 0)
- ResilienceTab (18 → 0 missing key)
- RoutingTab (7 → 0 missing key)
- VisionBridgeSettingsTab (new useTranslations + 6 keys)
- CopilotToolCard (7 → 0 missing key)
- ApiManagerPageClient (13 → 0 missing key)
- gamification/admin (new useTranslations + 7 keys)

Hardcoded total: 326 → 249. Real missing keys: 0 (the 6 still flagged
are false positives in exampleTemplates.tsx where t is passed as a
parameter — keys exist at translator.templatePayloads.*).

* chore(i18n): replace hardcoded UI text with t() calls across dashboard (round 3)

Round-3 subagents and manual edits refactored 9 more dashboard pages
(plus 2 small extras), replacing ~80 hardcoded strings with
useTranslations() lookups. Added 79 corresponding keys to en.json
across analytics, cloudAgents, combos, common, health, settings, and
usage namespaces.

Pages affected:
- analytics/ComboHealthTab (new useTranslations + 15 keys)
- analytics/CompressionAnalyticsTab (new useTranslations + 11 keys)
- settings/SystemStorageTab (21 → 0 missing key)
- tokens/page (new useTranslations + 13 keys)
- usage/BudgetTab (9 missing fixed)
- health/page (manual: 6 keys)
- cloud-agents/page (manual: 3 keys)
- combos/page (manual: 1 key)

Hardcoded total: 249 → 164. Real missing keys: 0 (6 remaining are
exampleTemplates.tsx false positives).

Also adds scripts/i18n/build-pending-from-missing.mjs which reads
_audit.json and locates English values from HEAD to rebuild
_pending-keys.json after race-condition resets between subagent edits.

* chore(i18n): localize remaining dashboard settings labels

Replace hardcoded labels in compression and resilience settings with
translation lookups to continue the dashboard i18n cleanup.

Add the v3.8.0 dashboard shakedown runbook to document the manual
smoke-test process and known dev environment pitfalls.

* chore(i18n): replace hardcoded UI text with t() calls across dashboard (round 4)

Round-4 subagent + manual key-resolution refactored remaining strings in
3 high-traffic settings/API tabs, plus extracted English values for
keys that were already added as t() calls but lost during the previous
en.json race-condition resets.

Pages affected:
- api-manager/ApiManagerPageClient (7 → 0 missing key)
- settings/CompressionSettingsTab (8 → 0 missing key)
- settings/MemorySkillsTab (8 → 0 missing key)
- settings/ResilienceTab (4 more keys recovered)

Hardcoded total: 164 → 140. Real missing keys: 0 (6 remaining are the
exampleTemplates.tsx false positives — t passed as parameter).

* chore(i18n): replace hardcoded UI text with t() calls across dashboard (round 5)

Round-5 agent began processing the remaining smaller dashboard files.
Added 5 more keys to en.json for providers/[id]/page.tsx OAuth flow
labels and the cross-OS auto-detection hint.

Pages affected:
- providers/[id]/page.tsx (5 keys)

Hardcoded total: 140 → 136. Real missing keys: 0.

* chore(i18n): resolve last 2 missing providers/[id] keys

Adds providerDetailMyClaudeAccountPlaceholder and
providerDetailPathAutoDetected — the final user-visible labels in the
providers/[id] page that the round-5 subagent rewrote to t() calls
without yet adding to en.json.

Real missing keys: 0 (6 remaining are exampleTemplates.tsx false
positives — t is passed as a parameter so the audit cannot resolve the
namespace; keys do exist at translator.templatePayloads.*).

* chore(i18n): replace hardcoded UI text with t() calls across dashboard (round 6 — 10 parallel agents)

Round-6 dispatched 10 parallel subagents covering all 57 remaining
dashboard files. Each agent worked on a disjoint file set to avoid
en.json race conditions. Added ~60 new i18n keys across 9 namespaces
covering small UI labels, table headers, search placeholders, and
empty-state messages.

Major changes:
- analytics: SearchAnalyticsTab, ProviderUtilizationTab, DiversityScoreCard, CompressionAnalyticsTab (new useTranslations + keys)
- batch: BatchDetailModal, BatchListTab, FileDetailModal, FilesListTab (new useTranslations + keys)
- settings: CliproxyapiSettingsTab, PayloadRulesTab, ModelCooldownsCard, AppearanceTab, PricingTab (mostly new useTranslations)
- endpoint: TokenSaverCard, ApiEndpointsTab, EndpointPageClient
- cache: CachePerformance, IdempotencyLayer, ReasoningCacheTab, MediaPageClient, page
- combos: IntelligentComboPanel, page
- playground: ChatPlayground, SearchPlayground
- providers: ProviderCard
- onboarding: TierFlowDiagram
- changelog: ChangelogViewer
- home: ProviderTopology, TierCoverageWidget, BootstrapBanner, BadgeToast
- usage: BudgetTab, BudgetTelemetryCards, QuotaTable
- quotaShare: QuotaSharePageClient
- profile: page
- leaderboard: page
- skills: page

Hardcoded total: 131 → 60. Real missing keys: 0 plus 1 false-positive
for combos.modePack (lookup via prop-passed t).

* chore(i18n): finalize round-6 keys for batch/cache/endpoint/usage

Adds the remaining keys produced by parallel agents A4, A6, A8, A9:
- common: batch-related labels (BatchDetailModal, BatchListTab,
  FileDetailModal, FilesListTab, page) + profile/leaderboard
- cache: hit rate, latency, retry, avg chars
- endpoint: token saver, API endpoints, copy URL, cloud/local labels
- usage: noSpend, activeSessions, quotaAlerts, budget timing
- skills: install/marketplace/filter
- proxyRegistry/quotaShare/mcpDashboard: misc labels

Hardcoded total: 60 → 48. Real missing keys: 0 (modePack remaining is a
false positive — combos.modePack exists but the audit can't resolve it
since IntelligentComboPanel receives t as a prop).

* fix(playground): dedupe filteredModels to avoid duplicate React key warning

The /v1/models endpoint can return the same model id twice (e.g., when a
model is listed by both an alias and its canonical provider), which made
the <Select> emit two <option> elements with the same key — triggering
"Encountered two children with the same key, codex/gpt-5.5".

Replace the chained filter + map with a single pass that skips ids
already added.

* fix(playground): guard against non-string model ids before .split/.startsWith

The /v1/models endpoint can include synthetic entries (combos, locals,
in-progress imports) with a null/undefined id. The playground used to
call m.id.split("/") in the provider-discovery loop, which threw on the
first non-string entry; the surrounding .catch(() => {}) silently
swallowed the error, so the provider/model/account dropdowns ended up
empty even though /v1/models returned thousands of valid entries.

- Skip entries without a string id before split/startsWith.
- Log the rejection in the .catch handler so future regressions are
  visible in DevTools instead of silently emptying the UI.

* fix(playground): guard ChatPlayground filteredModels for non-string ids

Same root cause as commit 49fe356b9: ChatPlayground filtered models
with m.id.startsWith(...) which crashed on null/undefined ids returned
by /v1/models (synthetic combo entries). Apply the same defensive guard
and dedupe used in the parent page.

* fix(claude): drop orphan tool_result after fixToolAdjacency strip (discussion #2410)

Discussion #2410 reports Claude returning 400 for sequences like:
  assistant: tool_use(id=X)
  user: <plain text>           ← breaks adjacency
  user: tool_result(id=X)

The previous round added `fixToolAdjacency` (commit 44d9abac9) which
correctly strips the orphan tool_use from the assistant message. But
that left the now-unmatched tool_result intact, so the upstream
rejected the request with:

  messages.N.content.M: unexpected `tool_use_id` found in `tool_result`
  blocks: X. Each tool_result block must have a corresponding tool_use
  block in the previous message.

Fix: after running `fixToolAdjacency`, re-run `fixToolPairs` to drop
the orphaned tool_result blocks. All three call sites updated:
  - contextManager.purifyHistory (both inside the binary-search loop
    and the final pass)
  - BaseExecutor message-prep (Claude path)
  - claudeCodeCompatible request signer

Also tightens an unrelated dynamic-key access in
readNestedString (claudeCodeCompatible) to satisfy the prototype-
pollution scanner triggered by the post-tool semgrep hook.

* fix(mitm): point runtime manager re-export to js entrypoint

Use the emitted `.js` path for the runtime manager re-export so dynamic
runtime loading resolves correctly outside the Turbopack alias handling.

* docs: add AgentRouter setup guide (#2422)

Integrated into release/v3.8.0 — AgentRouter setup guide docs.

* feat: add new feature on combos - falloverBeforeRetry (#2417)

Integrated into release/v3.8.0 — falloverBeforeRetry for per-model quota skipping in combos.

* feat(batch): implement 10 feature requests harvested  (#2414)

Integrated into release/v3.8.0 — batch of 10 feature requests: llama.cpp local provider, upstream error exposure, Termux detection, providers rotate CLI, t3.chat web skeleton, Zed Docker integration, Kiro multi-account OAuth isolation, auto-combo cost blending, auto-combo context filter, combo provider-level exhaustion tracking (#1731). Conflicts with #2417 (falloverBeforeRetry) resolved.

* fix(gamification): resolve SQL bug, auth gap, pagination, and anomaly scoring (#2421)

Integrated into release/v3.8.0 — 6 critical gamification bug fixes: SQL SELECT in checkActionCountBadges, federation auth enforcement, leaderboard pagination offset, real z-score computation, addXp level calculation, and barrel index.ts

* docs(changelog): add post-release entries for #2414 #2417 #2421 #2422

- feat(batch): T3-Chat-Web executor, exhaustedProviders set (#1731), Zed Docker
- feat(combos): falloverBeforeRetry + setTry loop (#2417 — @hartmark)
- fix(gamification): SQL SELECT bug, federation auth, pagination, z-score (#2421 — @oyi77)
- docs: AgentRouter setup guide (#2422 — @leninejunior)

* fix(security): resolve CodeQL random/password-hash alerts and sync docs & tests

* feat/fix: integrate PRs #2423, #2425, #2427, #2428 with test & security fixes

* docs(changelog): credit contributors for PRs #2423, #2425, #2427, #2428

* fix(mitm): drop .js extension on manager.runtime re-export for webpack build (#2425)

Merged into release/v3.8.0

* fix: persist STORAGE_ENCRYPTION_KEY across upgrades (closes #1622) (#2428)

Merged into release/v3.8.0

* fix: auto-reset apiKeyHealth on successful connection test (#2427)

Merged into release/v3.8.0

* fix: support Antigravity image generation, Add Gemini 3.5 Flash (#2423)

Merged into release/v3.8.0

---------

Co-authored-by: diegosouzapw <diego.souza.pw@gmail.com>
Co-authored-by: Lenine Júnior <lenine@engrene.com.br>
Co-authored-by: Markus Hartung <mail@hartmark.se>
Co-authored-by: Paijo <14921983+oyi77@users.noreply.github.com>
Co-authored-by: Anton <39598727+NomenAK@users.noreply.github.com>
Co-authored-by: Chewji <126886556+Chewji9875@users.noreply.github.com>
Co-authored-by: clousky2020 <33016567+clousky2020@users.noreply.github.com>
Co-authored-by: backryun <bakryun0718@proton.me>
2026-05-20 09:12:49 -03:00

666 lines
23 KiB
TypeScript
Raw Permalink Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
/**
* apiKeyRotator 健康状态追踪测试
*
* 测试 T07 功能API Key 健康状态追踪
* 当 API Key 连续认证失败 3 次后,应被标记为 "invalid" 并在轮换时自动跳过
*/
import { describe, it, beforeEach, afterEach } from "node:test";
import assert from "node:assert/strict";
import {
getValidApiKey,
recordKeyFailure,
recordKeySuccess,
connectionHasExtraKeys,
trackConnectionExtraKeys,
getInvalidKeyCount,
resetKeyStatus,
getAllKeyHealth,
syncHealthFromDB,
type KeyHealth,
} from "../../open-sse/services/apiKeyRotator.ts";
// Helper to reset module state between tests
function resetModuleState() {
// Clear all internal maps by re-importing or using exported reset functions
// Since apiKeyRotator doesn't export a clearAll function, we use resetKeyStatus
const allHealth = getAllKeyHealth();
for (const scopedKey of Object.keys(allHealth)) {
// scopedKey format is "connectionId:keyId"
const keyId = scopedKey.includes(":") ? scopedKey.split(":")[1] : scopedKey;
resetKeyStatus("test-conn", keyId);
}
}
describe("apiKeyRotator Health Tracking", () => {
beforeEach(() => {
resetModuleState();
});
afterEach(() => {
resetModuleState();
});
describe("getValidApiKey", () => {
it("should return primary key when no extra keys", () => {
const connectionId = "test-conn-1";
const primaryKey = "pk-test-123";
const result = getValidApiKey(connectionId, primaryKey, []);
assert.equal(result?.key, primaryKey);
assert.equal(result?.keyId, "primary");
});
it("should return null when no keys available", () => {
const connectionId = "test-conn-2";
const result = getValidApiKey(connectionId, "", []);
assert.equal(result, null);
});
it("should return object with key and keyId when a valid key is found", () => {
const connectionId = "test-conn-keyid";
const primaryKey = "pk-keyid-test";
const result = getValidApiKey(connectionId, primaryKey, []);
assert.ok(result, "should return an object");
assert.equal(typeof result!.key, "string");
assert.equal(typeof result!.keyId, "string");
assert.equal(result!.key, primaryKey);
assert.equal(result!.keyId, "primary");
});
it("should skip invalid primary key and return first extra key", () => {
const connectionId = "test-conn-3";
const primaryKey = "pk-invalid";
const extraKeys = ["extra-1", "extra-2"];
const health: Record<string, KeyHealth> = {
primary: {
status: "invalid",
failures: 3,
lastFailure: null,
lastSuccess: null,
totalRequests: 5,
totalFailures: 3,
},
};
const result = getValidApiKey(connectionId, primaryKey, extraKeys, health);
assert.equal(result?.key, "extra-1");
assert.equal(result?.keyId, "extra_0");
});
it("should skip all invalid keys and return null", () => {
const connectionId = "test-conn-4";
const primaryKey = "pk-invalid";
const extraKeys = ["extra-invalid"];
const health: Record<string, KeyHealth> = {
primary: {
status: "invalid",
failures: 3,
lastFailure: null,
lastSuccess: null,
totalRequests: 5,
totalFailures: 3,
},
extra_0: {
status: "invalid",
failures: 3,
lastFailure: null,
lastSuccess: null,
totalRequests: 3,
totalFailures: 3,
},
};
const result = getValidApiKey(connectionId, primaryKey, extraKeys, health);
assert.equal(result, null);
});
it("should return keyId in result", () => {
const connectionId = "test-conn-5";
const primaryKey = "pk-test";
const extraKeys = ["extra-1", "extra-2"];
const result = getValidApiKey(connectionId, primaryKey, extraKeys);
assert.ok(result, "should have a result");
assert.ok(["primary", "extra_0", "extra_1"].includes(result!.keyId), "keyId should be valid");
});
it("should round-robin among valid keys only (skipping invalid)", () => {
const connectionId = "test-conn-6";
const primaryKey = "pk-test";
const extraKeys = ["extra-1", "extra-2", "extra-3"];
const health: Record<string, KeyHealth> = {
extra_1: {
status: "invalid",
failures: 3,
lastFailure: null,
lastSuccess: null,
totalRequests: 3,
totalFailures: 3,
}, // extra-2 is index 1
};
// First call
const key1 = getValidApiKey(connectionId, primaryKey, extraKeys, health);
const key2 = getValidApiKey(connectionId, primaryKey, extraKeys, health);
const key3 = getValidApiKey(connectionId, primaryKey, extraKeys, health);
// Should only rotate among primary, extra-1 (index 0), extra-3 (index 2)
// Invalid extra_1 (which corresponds to extraKeys[1]) should be skipped
const validKeys = [primaryKey, "extra-1", "extra-3"];
assert.ok(validKeys.includes(key1!.key));
assert.ok(validKeys.includes(key2!.key));
assert.ok(validKeys.includes(key3!.key));
// extra-2 should never be selected
assert.notEqual(key1!.key, "extra-2");
assert.notEqual(key2!.key, "extra-2");
assert.notEqual(key3!.key, "extra-2");
});
});
describe("recordKeyFailure", () => {
it("should increment failure count", () => {
const health = recordKeyFailure("test-conn", "primary");
assert.equal(health.failures, 1);
assert.equal(health.status, "warning");
});
it("should mark as invalid after 3 consecutive failures", () => {
recordKeyFailure("test-conn", "primary");
recordKeyFailure("test-conn", "primary");
const health = recordKeyFailure("test-conn", "primary");
assert.equal(health.failures, 3);
assert.equal(health.status, "invalid");
});
it("should track totalRequests and totalFailures", () => {
const h1 = recordKeyFailure("test-conn", "test-key-1");
assert.equal(h1.totalRequests, 1);
assert.equal(h1.totalFailures, 1);
const h2 = recordKeyFailure("test-conn", "test-key-1");
assert.equal(h2.totalRequests, 2);
assert.equal(h2.totalFailures, 2);
});
it("should set lastFailure timestamp", () => {
const health = recordKeyFailure("test-conn", "primary");
assert.ok(health.lastFailure, "lastFailure should be set");
assert.ok(new Date(health.lastFailure!).getTime() > 0, "lastFailure should be valid date");
});
});
describe("recordKeySuccess", () => {
it("should reset failure count and mark as active", () => {
// First record some failures
recordKeyFailure("test-conn", "primary");
recordKeyFailure("test-conn", "primary");
// Then record success
const health = recordKeySuccess("test-conn", "primary");
assert.equal(health.failures, 0);
assert.equal(health.status, "active");
});
it("should recover from warning status", () => {
recordKeyFailure("test-conn", "primary"); // 1 failure -> warning
const afterSuccess = recordKeySuccess("test-conn", "primary");
assert.equal(afterSuccess.status, "active");
assert.equal(afterSuccess.failures, 0);
});
it("should recover from invalid status", () => {
recordKeyFailure("test-conn", "primary");
recordKeyFailure("test-conn", "primary");
recordKeyFailure("test-conn", "primary"); // 3 failures -> invalid
const afterSuccess = recordKeySuccess("test-conn", "primary");
assert.equal(afterSuccess.status, "active");
assert.equal(afterSuccess.failures, 0);
});
});
describe("getInvalidKeyCount", () => {
it("should return 0 when no invalid keys", () => {
const count = getInvalidKeyCount({});
assert.equal(count, 0);
});
it("should count invalid keys correctly", () => {
const health: Record<string, KeyHealth> = {
primary: {
status: "invalid",
failures: 3,
lastFailure: null,
lastSuccess: null,
totalRequests: 5,
totalFailures: 3,
},
extra_0: {
status: "active",
failures: 0,
lastFailure: null,
lastSuccess: null,
totalRequests: 10,
totalFailures: 0,
},
extra_1: {
status: "invalid",
failures: 3,
lastFailure: null,
lastSuccess: null,
totalRequests: 3,
totalFailures: 3,
},
};
const count = getInvalidKeyCount(health);
assert.equal(count, 2);
});
});
describe("trackConnectionExtraKeys", () => {
it("should track connection has extra keys", () => {
trackConnectionExtraKeys("conn-with-extras", ["key1", "key2"]);
assert.equal(connectionHasExtraKeys("conn-with-extras"), true);
});
it("should return false for connection without extra keys", () => {
trackConnectionExtraKeys("conn-no-extras", []);
assert.equal(connectionHasExtraKeys("conn-no-extras"), false);
});
it("should return false for unknown connection", () => {
assert.equal(connectionHasExtraKeys("unknown-conn"), false);
});
});
describe("syncHealthFromDB", () => {
it("should sync health status from DB to in-memory map", () => {
const connectionId = "test-sync-conn";
const health: Record<string, KeyHealth> = {
primary: {
status: "invalid",
failures: 3,
lastFailure: "2026-01-01T00:00:00Z",
lastSuccess: null,
totalRequests: 10,
totalFailures: 5,
},
};
syncHealthFromDB(connectionId, health);
// After sync, getAllKeyHealth should include the synced data
// Note: syncHealthFromDB uses `${connectionId}:${keyId}` as the key
const allHealth = getAllKeyHealth();
const syncedKey = `${connectionId}:primary`;
// This test will FAIL because syncHealthFromDB stores with connectionId prefix
// but getValidApiKey reads from health parameter without connectionId prefix
// This is a BUG - the key namespace mismatch
if (allHealth[syncedKey]) {
assert.equal(allHealth[syncedKey].status, "invalid");
}
});
});
describe("Key isolation per connection", () => {
it("should isolate health state per connection", () => {
// Connection A has primary key that failed
const connA = "conn-A";
const connB = "conn-B";
const primaryKeyA = "pk-A";
const primaryKeyB = "pk-B";
// Record failure for connection A's primary key
recordKeyFailure(connA, "primary");
recordKeyFailure(connA, "primary");
recordKeyFailure(connA, "primary"); // 3 failures -> invalid for connA only
// Connection B should NOT be affected - health is isolated
const keyA = getValidApiKey(connA, primaryKeyA, []);
const keyB = getValidApiKey(connB, primaryKeyB, []);
// keyA should be null (primary is invalid, no extra keys)
assert.equal(keyA, null);
// keyB should work (no failures recorded for connB)
assert.equal(keyB?.key, primaryKeyB);
});
it("should return correct keyId per connection", () => {
const connA = "conn-A";
const connB = "conn-B";
const resultA = getValidApiKey(connA, "pk-A", ["extra-A"]);
const resultB = getValidApiKey(connB, "pk-B", ["extra-B"]);
// Both should have a valid keyId
assert.ok(resultA, "connA should have a result");
assert.ok(resultB, "connB should have a result");
assert.ok(resultA!.keyId, "connA should have keyId");
assert.ok(resultB!.keyId, "connB should have keyId");
// keyId is per-connection scoped
});
});
});
describe("Integration: 401 handling should skip key not connection", () => {
it("should track extra keys for A3 guard", () => {
const connectionId = "conn-with-backup";
const extraKeys = ["backup-key-1", "backup-key-2"];
trackConnectionExtraKeys(connectionId, extraKeys);
assert.equal(connectionHasExtraKeys(connectionId), true);
});
it("should not mark connection unavailable when extra keys exist (A3 guard)", () => {
// This test documents the expected behavior:
// When 401 occurs and connection has extra keys,
// the system should:
// 1. Record failure against the specific key
// 2. Skip that key in future rotation
// 3. NOT disable the entire connection
const connectionId = "test-a3-guard";
const primaryKey = "pk-failing";
const extraKeys = ["extra-1-valid", "extra-2-valid"];
// Track that this connection has extra keys
trackConnectionExtraKeys(connectionId, extraKeys);
// Record 3 failures on primary key
recordKeyFailure(connectionId, "primary");
recordKeyFailure(connectionId, "primary");
const finalHealth = recordKeyFailure(connectionId, "primary");
// Primary key should now be invalid
assert.equal(finalHealth.status, "invalid");
// Build health state
const health: Record<string, KeyHealth> = {
primary: finalHealth,
};
// getValidApiKey should now skip primary and return an extra key
const nextKey = getValidApiKey(connectionId, primaryKey, extraKeys, health);
assert.ok(nextKey, "should return an extra key");
assert.notEqual(nextKey!.key, primaryKey, "should NOT return primary (invalid)");
assert.ok(extraKeys.includes(nextKey!.key), "should return one of the extra keys");
// The connection should still be usable because extra keys are available
// This is the core behavior the A3 guard should enable
});
});
describe("E2E: Complete 401 flow simulation", () => {
beforeEach(() => {
resetModuleState();
});
afterEach(() => {
resetModuleState();
});
it("should simulate full 401 failure → key rotation → success flow", () => {
const connectionId = "e2e-test-conn";
const primaryKey = "pk-primary";
const extraKeys = ["extra-key-1", "extra-key-2"];
// Step 1: Initial state - track extra keys
trackConnectionExtraKeys(connectionId, extraKeys);
assert.equal(connectionHasExtraKeys(connectionId), true);
// Step 2: First request - should get primary key
const key1 = getValidApiKey(connectionId, primaryKey, extraKeys);
assert.equal(key1?.key, primaryKey);
assert.equal(key1?.keyId, "primary");
// Step 3: Simulate 401 failure on primary key
const health1 = recordKeyFailure(connectionId, "primary");
assert.equal(health1.status, "warning");
assert.equal(health1.failures, 1);
// Step 4: Retry - should get a valid key (primary is still active, but round-robin may pick extra)
const key2 = getValidApiKey(connectionId, primaryKey, extraKeys, { primary: health1 });
assert.ok(
key2!.key === primaryKey || extraKeys.includes(key2!.key),
"should return a valid key"
);
// Step 5: Second 401 failure
const health2 = recordKeyFailure(connectionId, "primary");
assert.equal(health2.failures, 2);
assert.equal(health2.status, "invalid");
// Step 6: Third 401 failure - now primary becomes invalid
const health3 = recordKeyFailure(connectionId, "primary");
assert.equal(health3.failures, 3);
assert.equal(health3.status, "invalid");
// Step 7: Next request - should skip invalid primary and return extra key
const healthState = { primary: health3 };
const key3 = getValidApiKey(connectionId, primaryKey, extraKeys, healthState);
assert.ok(key3, "should return a key");
assert.notEqual(key3!.key, primaryKey, "should NOT return invalid primary key");
assert.ok(extraKeys.includes(key3!.key), "should return an extra key");
// Step 8: Verify the invalid key count
assert.equal(getInvalidKeyCount(healthState), 1);
// Step 9: A3 guard check - connection with extra keys should NOT be disabled
// This simulates what chat.ts does: check connectionHasExtraKeys before markAccountUnavailable
const shouldSkipConnectionDisable = connectionHasExtraKeys(connectionId);
assert.equal(shouldSkipConnectionDisable, true);
// Step 10: Success on extra key - mark it as successful
assert.ok(key3!.keyId.startsWith("extra_"));
const successHealth = recordKeySuccess(connectionId, key3!.keyId);
assert.equal(successHealth.status, "active");
assert.equal(successHealth.failures, 0);
// Step 11: Recover primary key
const recoveredHealth = recordKeySuccess(connectionId, "primary");
assert.equal(recoveredHealth.status, "active");
assert.equal(recoveredHealth.failures, 0);
// Step 12: Next request - can use primary again
const recoveredState = { primary: recoveredHealth };
const key4 = getValidApiKey(connectionId, primaryKey, extraKeys, recoveredState);
assert.ok(
key4!.key === primaryKey || extraKeys.includes(key4!.key),
"should rotate among valid keys"
);
});
it("should handle multiple invalid keys and still find valid ones", () => {
const connectionId = "multi-invalid-test";
const primaryKey = "pk-primary";
const extraKeys = ["extra-1", "extra-2", "extra-3"];
trackConnectionExtraKeys(connectionId, extraKeys);
// Mark primary and extra_0 as invalid
for (let i = 0; i < 3; i++) {
recordKeyFailure(connectionId, "primary");
recordKeyFailure(connectionId, "extra_0");
}
const health: Record<string, KeyHealth> = {
primary: {
status: "invalid",
failures: 3,
lastFailure: null,
lastSuccess: null,
totalRequests: 3,
totalFailures: 3,
},
extra_0: {
status: "invalid",
failures: 3,
lastFailure: null,
lastSuccess: null,
totalRequests: 3,
totalFailures: 3,
},
};
// Should still find valid keys (extra_1 or extra_2)
const validKeys: string[] = [];
for (let i = 0; i < 10; i++) {
const key = getValidApiKey(connectionId, primaryKey, extraKeys, health);
if (key) validKeys.push(key.key);
}
assert.ok(validKeys.length > 0, "should return valid keys");
// Verify no invalid keys are returned
const invalidKeys = ["pk-primary", "extra-1"];
for (const invalidKey of invalidKeys) {
assert.ok(!validKeys.includes(invalidKey), `${invalidKey} should be skipped`);
}
// Verify only valid keys (extra-2, extra-3) are returned
const validSet = new Set(["extra-2", "extra-3"]);
assert.ok(
validKeys.every((k) => validSet.has(k)),
"only extra_2 and extra_3 should be returned"
);
});
it("should handle edge case: all keys invalid", () => {
const connectionId = "all-invalid-test";
const primaryKey = "pk-primary";
const extraKeys = ["extra-1"];
trackConnectionExtraKeys(connectionId, extraKeys);
// Mark all keys as invalid
const health: Record<string, KeyHealth> = {
primary: {
status: "invalid",
failures: 3,
lastFailure: null,
lastSuccess: null,
totalRequests: 3,
totalFailures: 3,
},
extra_0: {
status: "invalid",
failures: 3,
lastFailure: null,
lastSuccess: null,
totalRequests: 3,
totalFailures: 3,
},
};
// Should return null - no valid keys
const key = getValidApiKey(connectionId, primaryKey, extraKeys, health);
assert.equal(key, null);
// A3 guard: even with extra keys, if ALL keys are invalid,
// the connection might need to be disabled
// But current behavior: don't disable, just return null and let caller handle
assert.equal(connectionHasExtraKeys(connectionId), true);
assert.equal(getInvalidKeyCount(health), 2);
});
it("should track health persistence round-trip", () => {
const connectionId = "persist-test";
const primaryKey = "pk-persist";
const extraKeys = ["extra-1"];
trackConnectionExtraKeys(connectionId, extraKeys);
// Record failures
const healthBefore = recordKeyFailure(connectionId, "primary");
assert.equal(healthBefore.failures, 1);
// Simulate DB sync (persist health)
const dbHealth: Record<string, KeyHealth> = {
primary: healthBefore,
};
// Sync from DB
syncHealthFromDB(connectionId, dbHealth);
// Verify key is still marked in internal state (with connection prefix)
const allHealth = getAllKeyHealth();
const prefixedKey = `${connectionId}:primary`;
assert.equal(allHealth[prefixedKey]?.status, "warning");
// Get valid key should still work
const key = getValidApiKey(connectionId, primaryKey, extraKeys, dbHealth);
assert.equal(key?.key, primaryKey); // Still valid (only 1 failure)
});
});
describe("A3 Guard Integration Test", () => {
beforeEach(() => {
resetModuleState();
});
afterEach(() => {
resetModuleState();
});
it("should document the expected A3 guard behavior for chat.ts", () => {
// This test documents how chat.ts should behave with A3 guard
const connectionId = "a3-guard-test";
const primaryKey = "pk-401";
const extraKeys = ["backup-1", "backup-2"];
// Simulate: Connection has extra keys
trackConnectionExtraKeys(connectionId, extraKeys);
assert.equal(connectionHasExtraKeys(connectionId), true);
// Simulate: 401 occurs on primary key
// Step 1: T07 code in chatCore.ts records key failure
const health = recordKeyFailure(connectionId, "primary");
// Step 2: A3 guard in chat.ts checks if connection has extra keys
const hasExtraKeys = connectionHasExtraKeys(connectionId);
const is401 = true; // Simulated 401
const skipConnectionDisable = is401 && hasExtraKeys;
// Step 3: With A3 guard, markAccountUnavailable should be skipped
assert.equal(skipConnectionDisable, true);
// Step 4: Next request should get backup key
const nextKey = getValidApiKey(connectionId, primaryKey, extraKeys, {
primary: health,
});
if (health.status === "invalid") {
assert.ok(extraKeys.includes(nextKey!.key!), "should use backup key");
}
// Step 5: Connection remains usable
// This is the key behavior: connection is NOT disabled
});
it("should document behavior when NO extra keys exist", () => {
const connectionId = "no-extras-test";
const extraKeys: string[] = [];
// No extra keys
trackConnectionExtraKeys(connectionId, extraKeys);
assert.equal(connectionHasExtraKeys(connectionId), false);
// Simulate: 401 occurs
recordKeyFailure(connectionId, "primary");
// A3 guard check
const hasExtraKeys = connectionHasExtraKeys(connectionId);
const is401 = true;
const skipConnectionDisable = is401 && hasExtraKeys;
// Without extra keys, connection SHOULD be disabled
assert.equal(skipConnectionDisable, false);
// chat.ts would call markAccountUnavailable here
// This is the expected behavior: disable the connection
});
});