Files
OmniRoute/tests/unit/cli/cli-manifest-drift.test.ts
Praveen K Palaniswamy 65e81158ab fix(ollama): route models by advertised capability (#11088)
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host.

Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean.

Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
2026-08-23 11:45:01 -03:00

128 lines
5.1 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import {
CLI_TARGET_MANIFEST,
listManifestTargets,
manifestModelArgs,
manifestRequiresModel,
resolveManifestTarget,
} from "../../../bin/cli/cli-manifest.mjs";
import { listRunTargets, resolveRunTarget } from "../../../bin/cli/commands/run.mjs";
import { listConfigureTargets, SETUP_MODULES } from "../../../bin/cli/commands/configure.mjs";
import { runCompletionCommand } from "../../../bin/cli/commands/completion.mjs";
import {
CLI_TOOL_IDS,
CLI_TOOL_ALIASES,
normalizeCliToolId,
getCliConfigPaths,
} from "../../../src/shared/services/cliRuntime";
import { getCliTool } from "../../../src/shared/constants/cliTools";
/**
* Drift guard for the executable manifest (`bin/cli/cli-manifest.mjs`).
*
* The manifest is the single declaration of which targets `omniroute run` /
* `omniroute configure` / shell completion expose. These assertions fail as
* soon as any consumer surface — or the server-side runtime catalog — starts
* disagreeing with it silently.
*/
const manifestIds = Object.keys(CLI_TARGET_MANIFEST);
test("every manifest target is a canonical id in the runtime catalog", () => {
for (const [id, entry] of Object.entries(CLI_TARGET_MANIFEST)) {
assert.equal(normalizeCliToolId(id), id, `${id} must be canonical (not an alias)`);
assert.ok(CLI_TOOL_IDS.includes(id), `${id} must exist in cliRuntime CLI_TOOLS`);
assert.ok(getCliConfigPaths(id), `${id} must resolve config paths in the runtime`);
// Configure targets surface in the dashboard picker flows, so they must be
// cataloged for the UI. Run-only targets (e.g. gemini) may stay CLI-only.
if (entry.configure) {
assert.ok(getCliTool(id), `${id} must exist in the UI catalog (cliTools.ts)`);
}
}
});
test("manifest aliases never conflict with runtime aliases", () => {
for (const [id, entry] of Object.entries(CLI_TARGET_MANIFEST)) {
for (const alias of entry.aliases) {
const runtimeTarget = CLI_TOOL_ALIASES[alias];
if (runtimeTarget !== undefined) {
assert.equal(
runtimeTarget,
id,
`alias '${alias}' maps to '${id}' in the manifest but '${runtimeTarget}' in cliRuntime`
);
}
}
}
});
test("kilocode variants stay a single canonical target in both worlds", () => {
for (const legacy of ["kilocode", "kilo-code", "kilo_cli"]) {
assert.equal(resolveManifestTarget(legacy, "configure"), "kilo");
assert.equal(normalizeCliToolId(legacy), "kilo");
}
});
test("run command derives targets and aliases from the manifest", () => {
assert.deepEqual(listRunTargets(), listManifestTargets("run"));
for (const [id, entry] of Object.entries(CLI_TARGET_MANIFEST)) {
const expected = entry.run ? id : undefined;
assert.equal(resolveRunTarget(id), expected, `resolveRunTarget(${id})`);
for (const alias of entry.aliases) {
assert.equal(resolveRunTarget(alias), expected, `resolveRunTarget(${alias})`);
}
}
assert.equal(resolveRunTarget("definitely-not-a-cli"), undefined);
});
test("configure command derives targets from the manifest and has a recipe per target", () => {
assert.deepEqual(listConfigureTargets(), listManifestTargets("configure"));
for (const id of listManifestTargets("configure")) {
const hasRecipe = id === "codex" || Boolean(SETUP_MODULES[id]);
assert.ok(hasRecipe, `configure target '${id}' has no setup recipe`);
}
for (const id of Object.keys(SETUP_MODULES)) {
assert.ok(
listManifestTargets("configure").includes(id),
`setup recipe '${id}' is not a manifest configure target`
);
}
});
test("completion scripts embed the manifest-derived target lists", async () => {
const runWords = listManifestTargets("run").join(" ");
const configureWords = listManifestTargets("configure").join(" ");
for (const shell of ["bash", "zsh", "fish"] as const) {
const chunks: string[] = [];
const originalWrite = process.stdout.write.bind(process.stdout);
process.stdout.write = ((chunk: unknown) => {
if (typeof chunk === "string") chunks.push(chunk);
return true;
}) as typeof process.stdout.write;
try {
assert.equal(await runCompletionCommand(shell), 0);
} finally {
process.stdout.write = originalWrite;
}
const output = chunks.join("");
assert.ok(output.includes(runWords), `${shell} completion must list run targets`);
assert.ok(output.includes(configureWords), `${shell} completion must list configure targets`);
}
});
test("model-flag wiring stays declared in the manifest", () => {
assert.deepEqual(manifestModelArgs("aider", "glm/glm-5.2"), ["--model", "openai/glm/glm-5.2"]);
assert.deepEqual(manifestModelArgs("opencode", "glm/glm-5.2"), [
"--model",
"omniroute/glm/glm-5.2",
]);
assert.deepEqual(manifestModelArgs("qwen", "glm/glm-5.2"), ["--model", "glm/glm-5.2"]);
assert.deepEqual(manifestModelArgs("claude", "glm/glm-5.2"), []);
assert.deepEqual(manifestModelArgs("codex", "glm/glm-5.2"), []);
assert.equal(manifestRequiresModel("qwen"), true);
assert.equal(manifestRequiresModel("aider"), false);
});