mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-16 11:52:26 +03:00
65e81158ab
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host. Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean. Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
42 lines
1.7 KiB
TypeScript
42 lines
1.7 KiB
TypeScript
/**
|
|
* Regression guard for GCF root-array surplus (SPEC Section 13).
|
|
*
|
|
* The root-array decode discarded parseArrayFromHeader's `consumed` count, so a wire whose
|
|
* declared count was fewer than the rows actually present silently dropped the surplus rows
|
|
* (the row loop breaks at the declared count and the extra lines were never read). SPEC 13
|
|
* makes a count mismatch — fewer OR more items than declared — an error. The fix checks that
|
|
* the consumed lines cover the whole document and throws otherwise.
|
|
*
|
|
* Reachable in prod: headroomEngine round-trips the encoded blob; a truncated decode is a
|
|
* silent losslessness violation.
|
|
*/
|
|
import { test } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { encodeGeneric } from "@omniroute/open-sse/services/compression/engines/headroom/gcf/generic.ts";
|
|
import { decodeGeneric } from "@omniroute/open-sse/services/compression/engines/headroom/gcf/decode_generic.ts";
|
|
|
|
test("surplus rows beyond the declared root-array count throw count_mismatch (SPEC 13)", () => {
|
|
const rows = [
|
|
{ a: 1, b: "x" },
|
|
{ a: 2, b: "y" },
|
|
{ a: 3, b: "z" },
|
|
];
|
|
const wire = encodeGeneric(rows); // header declares [3]
|
|
const understated = wire.replace("[3]", "[2]"); // declare fewer than present
|
|
assert.throws(
|
|
() => decodeGeneric(understated),
|
|
/count_mismatch/,
|
|
"a root array carrying more rows than declared must error, not silently truncate"
|
|
);
|
|
});
|
|
|
|
test("a root array with the exact declared count decodes normally", () => {
|
|
const rows = [
|
|
{ a: 1, b: "x" },
|
|
{ a: 2, b: "y" },
|
|
{ a: 3, b: "z" },
|
|
];
|
|
const wire = encodeGeneric(rows);
|
|
assert.deepEqual(decodeGeneric(wire), rows);
|
|
});
|