Files
OmniRoute/tests/unit/duckduckgo-web-executor.test.ts
Diego Rodrigues de Sa e Souza 7db430a352 Release v3.8.14 (#3340)
* chore(release): open v3.8.14 development cycle

Version bump 3.8.13 -> 3.8.14 (root + electron + open-sse + openapi + lockfiles).
Seed the v3.8.14 changelog with the four post-tag hotfixes that shipped to
Docker/Electron in v3.8.13 but missed the immutable npm 3.8.13 (#3336 SSRF /
CodeQL #323, #3334/#3335/#3339 Electron packaging). i18n CHANGELOG mirrors get
the in-progress placeholder section.

* feat: add per-provider custom headers support for OpenAI/Anthropic-compatible nodes (#3338)

Integrated into release/v3.8.14

* fix: Kiro Builder ID token import fails with Bad credentials (#3333)

Integrated into release/v3.8.14 — adds Builder ID cached-creds + OIDC refresh path for Kiro token import, with regression tests (#3333).

* Improve code quality: auto-pr/docstrings-1780792063 (#3337)

Integrated into release/v3.8.14 — docstring for context analytics route re-export.

* fix(catalog): remove minimaxai/minimax-m3 from NVIDIA NIM tier (404 upstream) (#3329) (#3341)

NVIDIA NIM does not host minimaxai/minimax-m3 — every request returns
404 page not found, while sibling minimaxai/minimax-m2.7 on the same provider
works. Advertising a model that 404s is a catalog bug; remove it from the nvidia
tier (it remains on the tiers that actually serve MiniMax M3). Re-add only once
NVIDIA serves it.

Co-authored-by: mikmaneggahommie <mikmaneggahommie@users.noreply.github.com>

* fix(cli): write OpenCode config to ~/.config on all platforms incl. Windows (#3330) (#3343)

resolveOpencodeConfigDir used %APPDATA% on Windows, but OpenCode reads its
config from XDG ~/.config/opencode/ on every platform (on Windows:
%USERPROFILE%\.config\opencode\, NOT %APPDATA%). So a Windows user who
configured OpenCode via the dashboard had the file written where OpenCode never
looks — it silently had no effect.

Use the XDG path (XDG_CONFIG_HOME || ~/.config) unconditionally. Update the UI
note + route JSDoc, and flip the three tests that encoded the old %APPDATA%
behavior (t40 per-platform + card-note, cli-runtime-extended getCliConfigPaths).

Co-authored-by: abdulkadirozyurt <abdulkadirozyurt@users.noreply.github.com>

* fix(proxy): make auto-selection fallback opt-in (#3332) (#3344)

selectWorkingProxyFallback (Step 11 of resolveProxyForConnection) listed ALL
registry proxies, ignoring assignments and per-connection proxy_enabled, and
returned the first working one with level:'autoSelect'. So a single proxy added
to the registry silently became a global fallback for every connection's traffic.

Gate it behind a new PROXY_AUTO_SELECT_ENABLED feature flag (default off): the
fallback now no-ops unless the operator opts in. No registry proxy becomes a
silent global default anymore.

Co-authored-by: hertznsk <hertznsk@users.noreply.github.com>

* fix(sse): treat MiniMax M3 as multimodal so vision isn't stripped (#3328) (#3342)

MiniMax M3 via the opencode provider (oc/minimax-m3-free) appeared blind:
image inputs didn't reach the model, while the same model in Cline could
see them. Verified empirically that MiniMax M3 on the opencode upstream IS
multimodal -- a base64 image is described correctly (it returns 403 only
for remote image URLs, which it doesn't accept).

Root cause: OmniRoute treated MiniMax M3 as a non-vision model in two
places, so when compression was active the image was replaced with a text
placeholder before dispatch:
- compression's modelSupportsVision() heuristic (lite.ts) only matched
  gpt-4/4o/claude-3/gemini/vision -- minimax was absent -> replaceImageUrls
  stripped the image.
- the opencode minimax-m3-free catalog entry lacked supportsVision, so the
  combo vision-capability gate could also exclude/mishandle it.

Add 'minimax-m3' to the vision heuristic and supportsVision: true to the
opencode minimax-m3-free entry. TDD: a failing-then-passing test in
compression/lite.test.ts proves replaceImageUrls now keeps images for
minimax-m3 ids, plus a registry assertion mirroring the #2822 qwen test.

Reported-by: @mikmaneggahommie

* docs(i18n): translate 25 core documentation files to Indonesian (#3348)

Integrated into release/v3.8.14 — Indonesian i18n docs.

* fix(review): resolve /review-reviews battery findings (LEDGER-1..11) on v3.8.14 (#3350)

Integrated into release/v3.8.14 — /review-reviews battery hardening (LEDGER-1..11) for #3338 custom-headers + #3333 kiro, plus cycle-test drift fixes (#3329/#3330/#3332).

* fix(provider-proxy): honor per-account proxy toggles (#3349)

Integrated into release/v3.8.14 — honor per-account proxy toggles + auto-fallback opt-in via PROXY_AUTO_SELECT_ENABLED.

* fix(dashboard): remove duplicate Distribute Proxies button on provider page (#3352)

* fix(providers): reduce proxy label noise (#3346)

Integrated into release/v3.8.14 — reduce proxy label noise + a11y (aria-label/sr-only).

* fix(duckduckgo): restore bare Response contract and rebase onto release/v3.8.14 (#3323)

Integrated into release/v3.8.14 — browser-backed cookie providers (duckduckgo/claude-web) with restored executor contract + unit tests.

* fix(noauth): expose only usable model aliases (#3345)

Integrated into release/v3.8.14 — noauth usable-alias filtering + registry alias plumbing (veo-free).

* fix(dashboard): stop infinite config-load loop on Hermes Agent detail page (#3353)

* fix(electron): tree-kill the server on exit/update to release the omniroute.exe lock (#3347) (#3354)

* chore(release): finalize v3.8.14 changelog + clear release-gate drift

- CHANGELOG: finalize the v3.8.14 section (date, full New Features/Bug Fixes/
  Maintenance coverage of all 16 cycle commits, Contributors hall of 12).
- docs: document OMNIROUTE_BROWSER_POOL + WEB_COOKIE_USE_BROWSER (#3323) in
  .env.example + ENVIRONMENT.md; regenerate the id/llm.txt strict mirror (#3348
  had translated it; llm.txt mirrors must match root).
- test(proxy-fetch): #3323 made tlsClient.available a computed getter — stub it
  via Object.defineProperty instead of assignment (5 tests were red on the base).

* fix(translator): coerce Gemini functionDeclaration parameters to an OBJECT schema (#3357) (#3360)

* fix(gemini): resolve truncation/suppression of false positive textual tool call markers in backticks (#3358)

Integrated into release/v3.8.14 — Gemini/Antigravity textual tool-call marker normalization (no false-positive suppression + split-chunk buffering).

* docs(changelog): add #3358 Gemini textual tool-call normalization to v3.8.14

* fix(dashboard): surface real analytics error instead of generic placeholder (#3356) (#3361)

The Analytics page discarded the server's error body on a non-OK response and
rendered a generic "An error occurred", so users (and maintainers) could not see
why /api/usage/analytics 500'd after an upgrade. Now the route returns the real
reason via buildErrorBody (sanitized, Hard Rule #12) and the page surfaces it via
a new readFetchErrorMessage helper that handles both the OpenAI-style and legacy
error shapes.

Reported-by: @superti4r

---------

Co-authored-by: PizzaV <103120356+pizzav-xyz@users.noreply.github.com>
Co-authored-by: Someres <168349709+quanturbo@users.noreply.github.com>
Co-authored-by: Dong Mengzhe <154944819+Lang-Qiu@users.noreply.github.com>
Co-authored-by: mikmaneggahommie <mikmaneggahommie@users.noreply.github.com>
Co-authored-by: abdulkadirozyurt <abdulkadirozyurt@users.noreply.github.com>
Co-authored-by: hertznsk <hertznsk@users.noreply.github.com>
Co-authored-by: Krisna Santosa <54174372+KrisnaSantosa15@users.noreply.github.com>
Co-authored-by: Randi <55005611+rdself@users.noreply.github.com>
Co-authored-by: Wilson <pedbookmed@gmail.com>
Co-authored-by: Paijo <14921983+oyi77@users.noreply.github.com>
Co-authored-by: Ardem2025 <ardemb22@gmail.com>
2026-06-07 07:20:02 -03:00

205 lines
7.3 KiB
TypeScript

import { describe, it, mock } from "node:test";
import assert from "node:assert/strict";
import { DuckDuckGoWebExecutor, DUCKDUCKGO_BASE } from "../../open-sse/executors/duckduckgo-web.ts";
describe("DuckDuckGoWebExecutor", () => {
describe("class instantiation", () => {
it("should instantiate executor", () => {
const executor = new DuckDuckGoWebExecutor();
assert.ok(executor, "Executor should be created");
});
it("should have execute method", () => {
const executor = new DuckDuckGoWebExecutor();
assert.equal(typeof executor.execute, "function", "execute should be a function");
});
it("should have testConnection method", () => {
const executor = new DuckDuckGoWebExecutor();
assert.equal(typeof executor.testConnection, "function", "testConnection should be a function");
});
it("should export DUCKDUCKGO_BASE constant", () => {
assert.equal(DUCKDUCKGO_BASE, "https://duckduckgo.com", "DUCKDUCKGO_BASE should be correct URL");
});
});
describe("execute method validation", () => {
it("should reject empty messages array", async () => {
const executor = new DuckDuckGoWebExecutor();
const response = await executor.execute({
model: "gpt-4o-mini",
messages: [],
stream: false,
} as any);
assert.ok(response instanceof Response, "should return Response");
assert.equal(response.status, 400, "should return 400 for empty messages");
const body = await response.json();
assert.ok(body.error, "error response should have error field");
});
it("should accept non-empty messages array", async () => {
const executor = new DuckDuckGoWebExecutor();
// This will fail due to network, but should pass input validation
try {
const response = await executor.execute({
model: "gpt-4o-mini",
messages: [{ role: "user", content: "test" }],
stream: false,
} as any);
// Should either succeed with real response or fail with network error (status 5xx, not 400)
assert.notEqual(response.status, 400, "should not return 400 for valid messages");
} catch (error) {
// Network error is expected since we're not running against real DuckDuckGo
assert.ok(error instanceof Error, "should throw Error for network issues");
}
});
it("should handle missing model parameter", async () => {
const executor = new DuckDuckGoWebExecutor();
try {
await executor.execute({
model: undefined,
messages: [{ role: "user", content: "test" }],
stream: false,
} as any);
} catch (error) {
assert.ok(error instanceof Error || error instanceof Response, "should handle missing model");
}
});
});
describe("testConnection method", () => {
it("should return boolean", async () => {
const executor = new DuckDuckGoWebExecutor();
try {
const result = await executor.testConnection({});
assert.equal(typeof result, "boolean", "testConnection should return boolean");
} catch (error) {
// Network error is acceptable - just verify method exists and is callable
assert.ok(true, "testConnection is callable");
}
});
it("should complete within timeout", async () => {
const executor = new DuckDuckGoWebExecutor();
const startTime = Date.now();
try {
await executor.testConnection({});
} catch (error) {
// Expected to fail or timeout
}
const elapsed = Date.now() - startTime;
assert.ok(elapsed < 35000, `testConnection should complete within 35 seconds, took ${elapsed}ms`);
});
});
describe("response handling", () => {
it("should handle AbortSignal", async () => {
const executor = new DuckDuckGoWebExecutor();
const controller = new AbortController();
// Abort immediately
controller.abort();
const response = await executor.execute({
model: "gpt-4o-mini",
body: { messages: [{ role: "user", content: "test" }] },
stream: false,
signal: controller.signal,
} as any);
assert.ok(response instanceof Response, "should return Response");
assert.equal(response.status, 499, "should return 499 for aborted request");
});
it("should support streaming parameter", async () => {
const executor = new DuckDuckGoWebExecutor();
try {
// Test with stream: true
const response1 = await executor.execute({
model: "gpt-4o-mini",
messages: [{ role: "user", content: "test" }],
stream: true,
} as any);
assert.ok(response1 instanceof Response, "streaming mode should return Response");
// Test with stream: false
const response2 = await executor.execute({
model: "gpt-4o-mini",
messages: [{ role: "user", content: "test" }],
stream: false,
} as any);
assert.ok(response2 instanceof Response, "non-streaming mode should return Response");
} catch (error) {
// Network errors are expected
assert.ok(error instanceof Error || error instanceof Response);
}
});
});
describe("error handling", () => {
it("should handle network timeouts gracefully", async () => {
const executor = new DuckDuckGoWebExecutor();
try {
const response = await executor.execute({
model: "gpt-4o-mini",
messages: [{ role: "user", content: "test" }],
stream: false,
} as any);
// Should get a response, not throw
assert.ok(response instanceof Response, "should return Response even on timeout");
} catch (error) {
// Timeout or network error is acceptable
assert.ok(error instanceof Error, "should handle errors gracefully");
}
});
it("should return valid error responses with JSON", async () => {
const executor = new DuckDuckGoWebExecutor();
const response = await executor.execute({
model: "gpt-4o-mini",
messages: [],
stream: false,
} as any);
assert.equal(response.status, 400);
const contentType = response.headers.get("content-type");
assert.ok(contentType?.includes("application/json"), "error response should be JSON");
const body = await response.json();
assert.ok(body.error, "error response should have error object");
assert.ok(body.error.message, "error should have message");
});
});
describe("integration checks", () => {
it("should be properly exported from executor module", async () => {
// Import the singleton as well
const { duckduckgoWebExecutor } = await import("../../open-sse/executors/duckduckgo-web.ts");
assert.ok(duckduckgoWebExecutor, "singleton executor should be exported");
assert.ok(duckduckgoWebExecutor.execute, "singleton should have execute method");
});
it("should be registered in executor index", async () => {
const { getExecutor } = await import("../../open-sse/executors/index.ts");
const executor = getExecutor("duckduckgo-web");
assert.ok(executor, "executor should be registered in index");
assert.equal(typeof executor.execute, "function", "registered executor should have execute method");
});
});
});