Files
OmniRoute/tests/unit/tokenExtractionConfig.test.ts
backryun bd472200d5 [v3.8.50] Fix Z.ai web browser transport and model capabilities (#8451)
* fix: complete Z.ai web browser transport

* refactor: address Z.ai review feedback

* test(zai-web): reconcile the #8014 endpoint guard with the chats/new + signed flow

Rebasing onto release/v3.8.49 pulled in #8503, which repointed CHAT_URL to
/api/v2/chat/completions and added an endpoint probe. This branch already
targets v2, so the executor conflict resolved to this branch's superset
(NEW_CHAT_URL + signature constants alongside the same v2 CHAT_URL). The two
tests needed adapting, because #8503's assertions assume the pre-rework flow:

- executor-zai-web.test.ts: the completion URL now carries the request
  signature as a query string, so an exact-equality check on the endpoint can
  never match. Assert the v2 prefix instead.
- zai-web-chat-endpoint-8014-probe.test.ts: the probe drove the executor with a
  bare cookie credential and no captcha proof, which now routes through the
  browser transport — fetch was never called and the probe captured nothing.
  Supplied a direct-path credential, and matched on pathname across all
  requests (the executor also probes the homepage for the frontend version and
  calls /api/v1/chats/new first).

The guard's intent is unchanged and slightly strengthened: it now asserts no
request reaches the stale unversioned path and that exactly one completions
request is issued, against v2.

54/54 across the zai suites; typecheck:core and eslint clean.

* fix(zai-web): surface upstream error frames instead of finishing empty

Reported on this PR: HTTP 200, `out=0`, stream "complete", no content and no
diagnosis.

Cause. HTTP-level failures are already handled — fetchUpstream turns any !ok
response into a makeErrorResult with the sanitized body. The gap is a 200 whose
SSE body carries an error payload: parseZaiFrame returns null for it,
drainSseDeltas drops it, and buildZaiStreamingBody then closes with an empty
assistant message + stop + [DONE]. The caller reads that as a successful empty
completion, so a rejected signature, an expired captcha and a stale token all
look identical — which is why this had to be diagnosed by reading code rather
than logs. Hard Rule #6.

Fix. parseZaiFrame now classifies an affirmatively error-shaped frame
(`error` at the top level or under `data`, string or {detail|message|msg}) as a
terminal delta, checked before the delta paths so it cannot fall through to the
"no usable delta" null. The stream emits it as `[Z.ai error] <message>`,
matching the mid-stream convention the other web executors already use
(zed-hosted's createErrorChunk) — the 200 is on the wire, so the status cannot
change, but the caller must not be left reading a blank success. Content
streamed before the failure is preserved. Message goes through
sanitizeErrorMessage (Rule #12).

Deliberately NOT changed: a contentless frame still parses to null. That is
live-validated behaviour, not an oversight — z.ai emits phase frames with no
delta_content, and executor-zai-web.test.ts pins it ("returns null for frames
with no usable delta"). Treating "nothing parseable arrived" as a failure would
invent policy on top of an observed protocol and risk false errors on the happy
path, so this only adds recognition of explicit error frames.

Tests (TDD, RED then GREEN): zai-web-silent-empty-repro.test.ts — 7 cases.
Error frame classified and terminal; surfaced through the stream with the
upstream's own text; surfaced after partial content without losing it; plus a
REGRESSION GUARD that contentless/phase-only frames are still skipped, and two
controls that the happy path and reasoning-only output are untouched. The guard
and controls passed before the fix; the four error cases did not.

94/94 across the zai + stream suites; typecheck:core, eslint and check:file-size
clean.

* refactor(sse): extract the zai-web transports so the complexity ratchet holds

The v3.8.49 merge-train rebaseline (#8686) set the ceiling to the tip's own
measurement, leaving zero headroom, so this branch's +5 cyclomatic / +3 cognitive
own-growth had nowhere to sit once rebased onto it.

Eight violations, all in code this branch introduces, resolved by extraction —
no behaviour change:

- `execute` (152 lines, complexity 25, cognitive 20) now delegates to
  `resolveZaiRequest()` for the four client-error rejections and to a
  `fetchViaSignedApi()` method for the CAPTCHA/signature path, so it reads as
  "validate, pick a transport, shape the response".
- `fetchThroughBrowser` (126 lines, cognitive 16) hands its image decoding to
  `resolveZaiBrowserAttachments()`, its Playwright options to
  `buildZaiBrowserChatOptions()`, and its call-log payload to
  `buildZaiBrowserAuditBody()`.
- `configureZaiBrowserEffort` (cognitive 35 — the worst of the set) repeated a
  wrap-and-relabel try/catch four times inside an if/else. `runStage`, which
  already existed one function below, is now module-scoped and reused, and the
  toggle collapses to `checked !== config.enabled` (same four cases).
- `validateWebCookieProvider` (complexity 19) moves its can-we-probe-this
  cascade into `resolveWebCookieProbe()`, which returns either a rejection or
  the URL + headers to use.
- `acquireBrowserContext`'s creation closure (complexity 17) hands cookie and
  localStorage seeding to `seedContextSession()`.

That last extraction also clears a violation that predates this branch —
`acquireBrowserContext` was already over the 80-line ceiling — so cyclomatic
lands at 2187 against a baseline of 2188.

Verified: check:complexity-ratchets green both metrics; typecheck:core clean;
ESLint clean on all four files; 85 tests across the zai-web, web-cookie
validation, browser-pool and model-test-runner suites pass.

* fix(zai-web): surface upstream errors on the non-streaming path

collectZaiNonStreaming ignored delta.error — a 200 whose SSE body carries
an error frame (rejected signature, expired captcha, stale token) came
back as a successful empty completion. Now it throws on an error frame,
matching the streaming path's [Z.ai error] convention; the caller's
existing try/catch returns makeErrorResult(502) instead of an empty 200.

Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>

---------

Co-authored-by: backryun <busan011@ormbiz.co.kr>
Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
2026-08-12 08:41:03 -03:00

168 lines
6.4 KiB
TypeScript

/**
* Tests for open-sse/services/tokenExtractionConfig.ts
*
* Validates that all web-cookie provider configs are well-formed,
* have valid login URLs, and include at least one extraction source.
*/
import { describe, it } from "node:test";
import assert from "node:assert/strict";
const { TOKEN_EXTRACTION_CONFIGS, getExtractionConfig, listExtractionConfigs } =
await import("../../open-sse/services/tokenExtractionConfig.ts");
describe("tokenExtractionConfig", () => {
it("exports TOKEN_EXTRACTION_CONFIGS as a Map", () => {
assert.ok(TOKEN_EXTRACTION_CONFIGS instanceof Map);
});
it("has at least 21 registered providers (18 existing + 3 new)", () => {
assert.ok(TOKEN_EXTRACTION_CONFIGS.size >= 21);
});
it("every config has required fields", () => {
for (const [providerId, cfg] of TOKEN_EXTRACTION_CONFIGS) {
assert.ok(typeof cfg.providerId === "string", `${providerId}: missing providerId`);
assert.ok(cfg.providerId.length > 0, `${providerId}: empty providerId`);
assert.ok(typeof cfg.displayName === "string", `${providerId}: missing displayName`);
assert.ok(cfg.displayName.length > 0, `${providerId}: empty displayName`);
assert.ok(
cfg.loginUrl.startsWith("http"),
`${providerId}: loginUrl "${cfg.loginUrl}" must start with http`
);
assert.ok(
cfg.homeUrl.startsWith("http"),
`${providerId}: homeUrl "${cfg.homeUrl}" must start with http`
);
assert.ok(Array.isArray(cfg.tokenSources), `${providerId}: tokenSources must be an array`);
assert.ok(cfg.tokenSources.length > 0, `${providerId}: must have at least one tokenSource`);
assert.ok(typeof cfg.instructions === "string", `${providerId}: missing instructions`);
assert.ok(cfg.instructions.length > 0, `${providerId}: empty instructions`);
}
});
it("every tokenSource has a valid type", () => {
const validTypes = ["cookie", "localStorage", "sessionStorage", "header"];
for (const [providerId, cfg] of TOKEN_EXTRACTION_CONFIGS) {
for (const src of cfg.tokenSources) {
assert.ok(
validTypes.includes(src.type),
`${providerId}: invalid tokenSource type "${src.type}"`
);
if (src.type === "cookie") {
assert.ok(typeof src.name === "string", `${providerId}: cookie source missing name`);
assert.ok(src.name.length > 0, `${providerId}: cookie source has empty name`);
}
if (src.type === "localStorage" || src.type === "sessionStorage") {
assert.ok(typeof src.key === "string", `${providerId}: storage source missing key`);
assert.ok(src.key.length > 0, `${providerId}: storage source has empty key`);
}
}
}
});
it("loginUrl and homeUrl share the same root domain", () => {
function extractDomain(url: string): string {
try {
const u = new URL(url);
return u.hostname;
} catch {
return "";
}
}
for (const [providerId, cfg] of TOKEN_EXTRACTION_CONFIGS) {
const loginDomain = extractDomain(cfg.loginUrl);
const homeDomain = extractDomain(cfg.homeUrl);
// Allow different subdomains but same root
const loginParts = loginDomain.split(".");
const homeParts = homeDomain.split(".");
const loginRoot = loginParts.slice(-2).join(".");
const homeRoot = homeParts.slice(-2).join(".");
assert.equal(
loginRoot,
homeRoot,
`${providerId}: loginUrl (${cfg.loginUrl}) and homeUrl (${cfg.homeUrl}) should share the same root domain`
);
}
});
it("getExtractionConfig returns undefined for unknown provider", () => {
const result = getExtractionConfig("nonexistent-provider");
assert.equal(result, undefined);
});
it("getExtractionConfig returns config for known providers", () => {
const providers = ["claude-web", "chatgpt-web", "gemini-web", "grok-web", "deepseek-web"];
for (const id of providers) {
const cfg = getExtractionConfig(id);
assert.ok(cfg !== undefined, `getExtractionConfig("${id}") returned undefined`);
assert.equal(cfg?.providerId, id);
}
});
it("captures Copilot's bearer authorization header instead of an unrelated cookie", () => {
const cfg = getExtractionConfig("copilot-web");
assert.deepEqual(cfg?.tokenSources, [{ type: "header", name: "Authorization" }]);
assert.doesNotMatch(cfg?.instructions || "", /RPSCAuth/i);
});
it("extracts zai-web auth from localStorage rather than a cookie", () => {
const cfg = getExtractionConfig("zai-web");
assert.deepEqual(cfg?.tokenSources, [{ type: "localStorage", key: "token" }]);
assert.match(cfg?.instructions ?? "", /CAPTCHA/);
});
it("listExtractionConfigs returns all configs as an array", () => {
const all = listExtractionConfigs();
assert.ok(Array.isArray(all));
assert.equal(all.length, TOKEN_EXTRACTION_CONFIGS.size);
});
it("includes the 3 new missing providers", () => {
const newProviders = ["chatglm-web", "xiaomimimo-web", "manus-web"];
for (const id of newProviders) {
const cfg = getExtractionConfig(id);
assert.ok(cfg !== undefined, `Missing provider "${id}" not found in config`);
}
});
it("every provider ID matches the executor naming convention", () => {
for (const providerId of TOKEN_EXTRACTION_CONFIGS.keys()) {
assert.ok(
providerId.endsWith("-web"),
`Provider ID "${providerId}" should follow the "-web" naming convention`
);
}
});
it("each cookie token source has a valid domain when specified", () => {
for (const [providerId, cfg] of TOKEN_EXTRACTION_CONFIGS) {
for (const src of cfg.tokenSources) {
if (src.type === "cookie" && src.domain) {
assert.ok(
src.domain.startsWith(".") || src.domain.startsWith("http"),
`${providerId}: cookie domain "${src.domain}" should start with "." or "http"`
);
}
}
}
});
it("pollingConfig has valid values", () => {
for (const [providerId, cfg] of TOKEN_EXTRACTION_CONFIGS) {
assert.ok(
cfg.pollingConfig.pollInterval >= 100,
`${providerId}: pollInterval too low (${cfg.pollingConfig.pollInterval})`
);
assert.ok(
cfg.pollingConfig.timeout >= 10000,
`${providerId}: timeout too low (${cfg.pollingConfig.timeout})`
);
assert.ok(
cfg.pollingConfig.minLoginTime >= 1000,
`${providerId}: minLoginTime too low (${cfg.pollingConfig.minLoginTime})`
);
}
});
});