Files
OmniRoute/tests/integration/agent-bridge-mappings.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

197 lines
6.7 KiB
TypeScript

/**
* Integration tests: AgentBridge model mappings round-trip
*
* Covers:
* - PUT /api/tools/agent-bridge/agents/[id]/mappings — replace mappings
* - GET /api/tools/agent-bridge/agents/[id]/mappings — read back
* - Zod 400 on invalid body
* - Error responses do not leak stack traces
*/
import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-ab-mappings-"));
process.env.DATA_DIR = TEST_DATA_DIR;
process.env.DISABLE_SQLITE_AUTO_BACKUP = "true";
const core = await import("../../src/lib/db/core.ts");
const mappingsRoute =
await import("../../src/app/api/tools/agent-bridge/agents/[id]/mappings/route.ts");
function resetDb() {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
test.beforeEach(() => {
resetDb();
});
test.after(() => {
try {
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
} catch {
/* noop */
}
});
// ── GET (empty) ────────────────────────────────────────────────────────────
test("GET /mappings: returns empty array for new agent", async () => {
const res = await mappingsRoute.GET(new Request("http://localhost/"), {
params: { id: "copilot" },
});
assert.equal(res.status, 200);
const body = (await res.json()) as { mappings: unknown[] };
assert.ok(Array.isArray(body.mappings));
assert.equal(body.mappings.length, 0);
});
// ── PUT → GET round-trip ───────────────────────────────────────────────────
test("PUT → GET round-trip: stores and retrieves mappings", async () => {
const mappings = [
{ source: "gpt-4o", target: "claude-sonnet-4-5" },
{ source: "gpt-4o-mini", target: "claude-haiku-3" },
];
const putRes = await mappingsRoute.PUT(
new Request("http://localhost/", {
method: "PUT",
headers: { "content-type": "application/json" },
body: JSON.stringify({ mappings }),
}),
{ params: { id: "copilot" } }
);
assert.equal(putRes.status, 200);
const putBody = (await putRes.json()) as {
ok: boolean;
mappings: Array<{ agent_id: string; source_model: string; target_model: string }>;
};
assert.equal(putBody.ok, true);
assert.equal(putBody.mappings.length, 2);
// GET reads back the same data
const getRes = await mappingsRoute.GET(new Request("http://localhost/"), {
params: { id: "copilot" },
});
assert.equal(getRes.status, 200);
const getBody = (await getRes.json()) as {
mappings: Array<{ source_model: string; target_model: string }>;
};
assert.equal(getBody.mappings.length, 2);
const sources = getBody.mappings.map((m) => m.source_model).sort();
assert.deepEqual(sources, ["gpt-4o", "gpt-4o-mini"]);
const targets = getBody.mappings.map((m) => m.target_model).sort();
assert.deepEqual(targets, ["claude-haiku-3", "claude-sonnet-4-5"]);
});
test("PUT: replaces all previous mappings", async () => {
// First PUT
await mappingsRoute.PUT(
new Request("http://localhost/", {
method: "PUT",
headers: { "content-type": "application/json" },
body: JSON.stringify({ mappings: [{ source: "old-model", target: "old-target" }] }),
}),
{ params: { id: "cursor" } }
);
// Second PUT — replaces
const putRes = await mappingsRoute.PUT(
new Request("http://localhost/", {
method: "PUT",
headers: { "content-type": "application/json" },
body: JSON.stringify({ mappings: [{ source: "new-model", target: "new-target" }] }),
}),
{ params: { id: "cursor" } }
);
assert.equal(putRes.status, 200);
const getRes = await mappingsRoute.GET(new Request("http://localhost/"), {
params: { id: "cursor" },
});
const body = (await getRes.json()) as { mappings: Array<{ source_model: string }> };
assert.equal(body.mappings.length, 1);
assert.equal(body.mappings[0].source_model, "new-model");
});
test("PUT: empty mappings array clears all mappings", async () => {
// Add then clear
await mappingsRoute.PUT(
new Request("http://localhost/", {
method: "PUT",
headers: { "content-type": "application/json" },
body: JSON.stringify({ mappings: [{ source: "x", target: "y" }] }),
}),
{ params: { id: "zed" } }
);
const putRes = await mappingsRoute.PUT(
new Request("http://localhost/", {
method: "PUT",
headers: { "content-type": "application/json" },
body: JSON.stringify({ mappings: [] }),
}),
{ params: { id: "zed" } }
);
assert.equal(putRes.status, 200);
const body = (await putRes.json()) as { mappings: unknown[] };
assert.equal(body.mappings.length, 0);
});
// ── Zod validation ─────────────────────────────────────────────────────────
test("PUT: invalid body (missing mappings) returns 400", async () => {
const res = await mappingsRoute.PUT(
new Request("http://localhost/", {
method: "PUT",
headers: { "content-type": "application/json" },
body: JSON.stringify({ wrong_key: [] }),
}),
{ params: { id: "antigravity" } }
);
assert.equal(res.status, 400);
const body = (await res.json()) as Record<string, unknown>;
const errMsg = (body.error as Record<string, unknown>)?.message as string;
assert.ok(!errMsg.includes("at /"), "stack trace leaked in 400 error");
});
test("PUT: invalid JSON returns 400", async () => {
const res = await mappingsRoute.PUT(
new Request("http://localhost/", {
method: "PUT",
headers: { "content-type": "application/json" },
body: "not-json",
}),
{ params: { id: "antigravity" } }
);
assert.equal(res.status, 400);
});
test("PUT: error responses do not leak stack traces", async () => {
const res = await mappingsRoute.PUT(
new Request("http://localhost/", {
method: "PUT",
headers: { "content-type": "application/json" },
body: JSON.stringify({ mappings: "not-an-array" }),
}),
{ params: { id: "codex" } }
);
const text = await res.text();
assert.ok(!text.includes("at /"), "stack trace leaked in PUT /mappings error");
});
test("GET: error responses do not leak stack traces", async () => {
const res = await mappingsRoute.GET(new Request("http://localhost/"), {
params: { id: "antigravity" },
});
const text = await res.text();
assert.ok(!text.includes("at /"), "stack trace leaked in GET /mappings response");
});