mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
226 lines
6.4 KiB
TypeScript
226 lines
6.4 KiB
TypeScript
/**
|
|
* Real FFmpeg fixture gate for the scene-aware Video Bridge sampler.
|
|
*
|
|
* Run explicitly because FFmpeg is an optional operational dependency:
|
|
* RUN_VIDEO_BRIDGE_FFMPEG=1 node --import tsx/esm --test \
|
|
* tests/integration/video-bridge-sampler-ffmpeg.test.ts
|
|
*/
|
|
import assert from "node:assert/strict";
|
|
import { execFile } from "node:child_process";
|
|
import { mkdtemp, readFile, rm } from "node:fs/promises";
|
|
import { tmpdir } from "node:os";
|
|
import { join } from "node:path";
|
|
import test from "node:test";
|
|
import { promisify } from "node:util";
|
|
|
|
import {
|
|
extractVideoFramesFromBytes,
|
|
type VideoCommandRunner,
|
|
} from "../../src/lib/guardrails/videoBridgeRuntime.ts";
|
|
|
|
const execFileAsync = promisify(execFile);
|
|
const REAL_FFMPEG_ENABLED = process.env.RUN_VIDEO_BRIDGE_FFMPEG === "1";
|
|
const REAL_FFMPEG_SKIP = REAL_FFMPEG_ENABLED
|
|
? false
|
|
: "Set RUN_VIDEO_BRIDGE_FFMPEG=1 to run the real FFmpeg fixture matrix";
|
|
|
|
const realRunner: VideoCommandRunner = async (executable, args, options) => {
|
|
const result = await execFileAsync(executable, [...args], {
|
|
encoding: "utf8",
|
|
maxBuffer: 1024 * 1024,
|
|
signal: options.signal,
|
|
timeout: options.timeoutMs,
|
|
windowsHide: true,
|
|
});
|
|
return { stderr: String(result.stderr), stdout: String(result.stdout) };
|
|
};
|
|
|
|
async function createFixture(
|
|
directory: string,
|
|
name: string,
|
|
inputArgs: readonly string[],
|
|
videoFilter: string
|
|
): Promise<Buffer> {
|
|
const outputPath = join(directory, `${name}.mkv`);
|
|
await realRunner(
|
|
"ffmpeg",
|
|
[
|
|
"-nostdin",
|
|
"-hide_banner",
|
|
"-loglevel",
|
|
"error",
|
|
...inputArgs,
|
|
"-vf",
|
|
videoFilter,
|
|
"-c:v",
|
|
"ffv1",
|
|
"-y",
|
|
outputPath,
|
|
],
|
|
{ timeoutMs: 30_000 }
|
|
);
|
|
return readFile(outputPath);
|
|
}
|
|
|
|
async function createRapidEdgeCutFixture(directory: string): Promise<Buffer> {
|
|
const outputPath = join(directory, "rapid-edge-cuts.mkv");
|
|
await realRunner(
|
|
"ffmpeg",
|
|
[
|
|
"-nostdin",
|
|
"-hide_banner",
|
|
"-loglevel",
|
|
"error",
|
|
"-f",
|
|
"lavfi",
|
|
"-i",
|
|
"color=c=red:s=64x64:r=10:d=0.2",
|
|
"-f",
|
|
"lavfi",
|
|
"-i",
|
|
"color=c=black:s=64x64:r=10:d=2.6",
|
|
"-f",
|
|
"lavfi",
|
|
"-i",
|
|
"color=c=white:s=64x64:r=10:d=0.2",
|
|
"-filter_complex",
|
|
"[0:v][1:v][2:v]concat=n=3:v=1:a=0,format=yuv420p[v]",
|
|
"-map",
|
|
"[v]",
|
|
"-c:v",
|
|
"ffv1",
|
|
"-y",
|
|
outputPath,
|
|
],
|
|
{ timeoutMs: 30_000 }
|
|
);
|
|
return readFile(outputPath);
|
|
}
|
|
|
|
async function sample(bytes: Buffer, frameCount: number, runner = realRunner) {
|
|
return extractVideoFramesFromBytes(bytes, {
|
|
frameCount,
|
|
maxDurationSeconds: 600,
|
|
runner,
|
|
samplingPolicy: "scene_aware",
|
|
timeoutMs: 30_000,
|
|
});
|
|
}
|
|
|
|
test(
|
|
"scene-aware sampling handles the canonical real FFmpeg fixture matrix",
|
|
{ skip: REAL_FFMPEG_SKIP },
|
|
async (context) => {
|
|
const directory = await mkdtemp(join(tmpdir(), "omniroute-video-sampler-fixtures-"));
|
|
context.after(async () =>
|
|
rm(directory, { force: true, recursive: true, maxRetries: 5, retryDelay: 100 })
|
|
);
|
|
|
|
const rapidCuts = await createRapidEdgeCutFixture(directory);
|
|
await context.test("rapid cuts near both ends retain coverage within the cap", async () => {
|
|
const result = await sample(rapidCuts, 4);
|
|
|
|
assert.deepEqual(
|
|
result.frames.map((frame) => frame.timestampSeconds),
|
|
[0.2, 0.5, 2.8]
|
|
);
|
|
assert.deepEqual(result.sampling, {
|
|
candidateCount: 2,
|
|
policyEffective: "scene_aware",
|
|
policyRequested: "scene_aware",
|
|
});
|
|
assert.ok(result.frames.length <= 16);
|
|
});
|
|
|
|
await context.test("one frame falls back to the full-window midpoint", async () => {
|
|
const result = await sample(rapidCuts, 1);
|
|
|
|
assert.deepEqual(
|
|
result.frames.map((frame) => frame.timestampSeconds),
|
|
[1.5]
|
|
);
|
|
assert.deepEqual(result.sampling, {
|
|
candidateCount: 2,
|
|
policyEffective: "uniform",
|
|
policyRequested: "scene_aware",
|
|
});
|
|
});
|
|
|
|
const staticVideo = await createFixture(
|
|
directory,
|
|
"static",
|
|
["-f", "lavfi", "-i", "color=c=blue:s=64x64:r=10:d=4"],
|
|
"format=yuv420p"
|
|
);
|
|
await context.test("a static scene falls back to uniform midpoints", async () => {
|
|
const result = await sample(staticVideo, 4);
|
|
|
|
assert.deepEqual(
|
|
result.frames.map((frame) => frame.timestampSeconds),
|
|
[0.5, 1.5, 2.5, 3.5]
|
|
);
|
|
assert.deepEqual(result.sampling, {
|
|
candidateCount: 0,
|
|
policyEffective: "uniform",
|
|
policyRequested: "scene_aware",
|
|
});
|
|
});
|
|
|
|
const slowChange = await createFixture(
|
|
directory,
|
|
"slow-change",
|
|
["-f", "lavfi", "-i", "nullsrc=s=64x64:r=10:d=4"],
|
|
"geq=lum='clip(16+200*T/4,16,235)':cb=128:cr=128,format=yuv420p"
|
|
);
|
|
await context.test("a gradual luminance change does not become a false scene cut", async () => {
|
|
const result = await sample(slowChange, 4);
|
|
|
|
assert.deepEqual(
|
|
result.frames.map((frame) => frame.timestampSeconds),
|
|
[0.5, 1.5, 2.5, 3.5]
|
|
);
|
|
assert.equal(result.sampling.candidateCount, 0);
|
|
assert.equal(result.sampling.policyEffective, "uniform");
|
|
});
|
|
|
|
const shortVideo = await createFixture(
|
|
directory,
|
|
"short",
|
|
["-f", "lavfi", "-i", "color=c=yellow:s=64x64:r=10:d=0.4"],
|
|
"format=yuv420p"
|
|
);
|
|
await context.test("a sub-second clip remains deterministic and bounded", async () => {
|
|
const result = await sample(shortVideo, 8);
|
|
|
|
assert.deepEqual(
|
|
result.frames.map((frame) => frame.timestampSeconds),
|
|
[0.2]
|
|
);
|
|
assert.equal(result.sampling.policyEffective, "uniform");
|
|
});
|
|
|
|
await context.test(
|
|
"a detector failure falls back while real frame extraction continues",
|
|
async () => {
|
|
const detectorFailureRunner: VideoCommandRunner = async (executable, args, options) => {
|
|
if (args.some((arg) => arg.includes("showinfo"))) {
|
|
throw new Error("fixture scene detector failure");
|
|
}
|
|
return realRunner(executable, args, options);
|
|
};
|
|
const result = await sample(staticVideo, 4, detectorFailureRunner);
|
|
|
|
assert.deepEqual(
|
|
result.frames.map((frame) => frame.timestampSeconds),
|
|
[0.5, 1.5, 2.5, 3.5]
|
|
);
|
|
assert.deepEqual(result.sampling, {
|
|
candidateCount: 0,
|
|
policyEffective: "uniform",
|
|
policyRequested: "scene_aware",
|
|
});
|
|
}
|
|
);
|
|
}
|
|
);
|