mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
85 lines
3.3 KiB
TypeScript
85 lines
3.3 KiB
TypeScript
/**
|
|
* Regression test for #8374 — GET /api/plugins returns "Invalid status value"
|
|
* when no `?status=` filter is passed.
|
|
*
|
|
* Root cause: `URLSearchParams.get("status")` returns `null` (not `undefined`)
|
|
* when the query param is absent. `z.enum([...]).optional()` widens the schema
|
|
* to accept `undefined`, but NOT `null` — so `safeParse(null)` fails and the
|
|
* route returns HTTP 400, even though the caller passed no filter at all.
|
|
*
|
|
* Fix: coerce `null` -> `undefined` before handing it to Zod, matching the
|
|
* repo's own established idiom (see registered-keys/route.ts,
|
|
* suggested-models/route.ts, quota/preview/route.ts).
|
|
*/
|
|
|
|
import { test, before, after } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import { NextRequest } from "next/server";
|
|
|
|
// Hermetic DB: isolate from the shared dev DATA_DIR so this test never
|
|
// touches or depends on real plugin rows, and so a fresh install has no
|
|
// configured password (isAuthRequired() -> false -> GET reachable directly).
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-plugins-8374-"));
|
|
const originalDataDir = process.env.DATA_DIR;
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const pluginsDb = await import("../../src/lib/db/plugins.ts");
|
|
const { GET } = await import("../../src/app/api/plugins/route.ts");
|
|
|
|
before(() => {
|
|
pluginsDb.insertPlugin({
|
|
id: "test-plugin-8374",
|
|
name: "test-plugin-8374",
|
|
version: "1.0.0",
|
|
main: "index.js",
|
|
manifest: {},
|
|
status: "active",
|
|
pluginDir: "/tmp/test-plugin-8374",
|
|
});
|
|
});
|
|
|
|
after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
if (originalDataDir === undefined) delete process.env.DATA_DIR;
|
|
else process.env.DATA_DIR = originalDataDir;
|
|
});
|
|
|
|
test("BUG #8374: GET /api/plugins with no ?status= returns 200, not 400", async () => {
|
|
// @ts-ignore - handler accepts NextRequest at runtime
|
|
const req = new NextRequest("http://localhost:3000/api/plugins");
|
|
const res = await GET(req);
|
|
const body = await res.json();
|
|
assert.equal(res.status, 200, `expected 200, got ${res.status}: ${JSON.stringify(body)}`);
|
|
assert.ok(Array.isArray(body.plugins), "response body must contain a plugins array");
|
|
});
|
|
|
|
test("GET /api/plugins with a valid ?status= filter still works and filters", async () => {
|
|
// @ts-ignore
|
|
const req = new NextRequest("http://localhost:3000/api/plugins?status=active");
|
|
const res = await GET(req);
|
|
const body = await res.json();
|
|
assert.equal(res.status, 200);
|
|
assert.ok(
|
|
body.plugins.every((p: { status: string }) => p.status === "active"),
|
|
"all returned plugins must have the requested status"
|
|
);
|
|
assert.ok(
|
|
body.plugins.some((p: { id: string }) => p.id === "test-plugin-8374"),
|
|
"the seeded active plugin must be present in the filtered result"
|
|
);
|
|
});
|
|
|
|
test("GET /api/plugins with an invalid ?status= still returns 400", async () => {
|
|
// @ts-ignore
|
|
const req = new NextRequest("http://localhost:3000/api/plugins?status=bogus");
|
|
const res = await GET(req);
|
|
const body = await res.json();
|
|
assert.equal(res.status, 400);
|
|
assert.equal(body.error, "Invalid status value");
|
|
});
|