Files
OmniRoute/tests/unit/approvalGate.test.ts
Praveen K Palaniswamy 65e81158ab fix(ollama): route models by advertised capability (#11088)
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host.

Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean.

Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
2026-08-23 11:45:01 -03:00

52 lines
2.0 KiB
TypeScript

import { describe, it } from "node:test";
import { ok, equal } from "node:assert/strict";
describe("Approval gate integration (#8461)", () => {
it("classifyCommand types are exported", async () => {
const mod = await import("@/lib/copilot/commandClassification");
equal(typeof mod.classifyCommand, "function");
});
it("classification module has the expected categories", async () => {
const mod = await import("@/lib/copilot/commandClassification");
const r = mod.classifyCommand(["status"]);
ok(r !== null, "should classify status");
ok(["read-only", "mutating", "destructive", "secret-affecting"].includes(r.category));
});
it("read-only command returns category and rule", async () => {
const { classifyCommand } = await import(
"@/lib/copilot/commandClassification"
);
const r = classifyCommand(["help"]);
equal(r?.category, "read-only");
ok(r?.rule.reason.length > 0, "rule should have a reason");
});
it("mutating command returns warning reason", async () => {
const { classifyCommand } = await import(
"@/lib/copilot/commandClassification"
);
const r = classifyCommand(["create", "something"]);
equal(r?.category, "mutating");
ok(r?.rule.reason.includes("changes"), "reason should explain the risk");
});
it("destructive command returns a stronger reason", async () => {
const { classifyCommand } = await import(
"@/lib/copilot/commandClassification"
);
const r = classifyCommand(["delete", "provider"]);
equal(r?.category, "destructive");
ok(r?.rule.reason.includes("permanently"), "reason should warn about permanence");
});
it("secret-affecting command warns about credentials", async () => {
const { classifyCommand } = await import(
"@/lib/copilot/commandClassification"
);
const r = classifyCommand(["keys", "show"]);
equal(r?.category, "secret-affecting");
ok(r?.rule.reason.includes("secrets"), "reason should mention secrets");
});
});