mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 02:42:24 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
74 lines
2.7 KiB
TypeScript
74 lines
2.7 KiB
TypeScript
// Characterization of emitRequestGamificationEvent — the per-request gamification hook extracted
|
|
// from handleChatCore's non-streaming AND streaming success paths (chatCore god-file
|
|
// decomposition, #3501). The inline block was duplicated verbatim; this locks the shared helper.
|
|
// Uses a real temp DB and polls xp_audit_log (the emit is fire-and-forget). Locks: the missing
|
|
// api-key guard (no-op) and that a valid call awards the "request" XP audit row.
|
|
import { test, before, after } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const testDataDir = fs.mkdtempSync(path.join(os.tmpdir(), "omni-gamification-test-"));
|
|
process.env.DATA_DIR = testDataDir;
|
|
|
|
const coreDb = await import("../../src/lib/db/core.ts");
|
|
const { emitRequestGamificationEvent } =
|
|
await import("../../open-sse/handlers/chatCore/gamificationEvent.ts");
|
|
|
|
function countAuditRows(apiKeyId: string): number {
|
|
const row = coreDb
|
|
.getDbInstance()
|
|
.prepare("SELECT COUNT(*) AS n FROM xp_audit_log WHERE api_key_id = ?")
|
|
.get(apiKeyId) as { n: number } | undefined;
|
|
return row?.n ?? 0;
|
|
}
|
|
|
|
async function waitForAuditRows(apiKeyId: string, min: number, timeoutMs = 3000): Promise<number> {
|
|
const deadline = Date.now() + timeoutMs;
|
|
while (Date.now() < deadline) {
|
|
if (countAuditRows(apiKeyId) >= min) break;
|
|
await new Promise((r) => setTimeout(r, 25));
|
|
}
|
|
return countAuditRows(apiKeyId);
|
|
}
|
|
|
|
before(async () => {
|
|
await coreDb.ensureDbInitialized();
|
|
});
|
|
|
|
after(() => {
|
|
coreDb.resetDbInstance();
|
|
try {
|
|
fs.rmSync(testDataDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
} catch {
|
|
// best-effort cleanup
|
|
}
|
|
});
|
|
|
|
test("missing apiKeyId is a no-op and never throws", async () => {
|
|
await assert.doesNotReject(
|
|
emitRequestGamificationEvent({ apiKeyId: null, model: "m", provider: "p" })
|
|
);
|
|
await assert.doesNotReject(
|
|
emitRequestGamificationEvent({ apiKeyId: undefined, model: "m", provider: "p" })
|
|
);
|
|
await assert.doesNotReject(
|
|
emitRequestGamificationEvent({ apiKeyId: "", model: "m", provider: "p" })
|
|
);
|
|
});
|
|
|
|
test("valid apiKeyId awards a 'request' XP audit row (fire-and-forget)", async () => {
|
|
const apiKeyId = "gamify-key-1";
|
|
assert.equal(countAuditRows(apiKeyId), 0);
|
|
await emitRequestGamificationEvent({ apiKeyId, model: "gpt-x", provider: "openai" });
|
|
const n = await waitForAuditRows(apiKeyId, 1);
|
|
assert.ok(n >= 1, "expected at least one xp_audit_log row for the request action");
|
|
});
|
|
|
|
test("never throws even when the emit path runs fully", async () => {
|
|
await assert.doesNotReject(
|
|
emitRequestGamificationEvent({ apiKeyId: "gamify-key-2", model: null, provider: null })
|
|
);
|
|
});
|