Files
OmniRoute/tests/unit/chatcore-telemetry-helpers.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

173 lines
6.0 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
// Isolated DATA_DIR set BEFORE importing anything that may touch the DB
// (maybeSyncClaudeExtraUsageState -> fetchLiveProviderLimits -> getProviderConnectionById).
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-telemetry-"));
process.env.DATA_DIR = TEST_DATA_DIR;
const { forwardDashboardEventToLiveWs, maybeSyncClaudeExtraUsageState } =
await import("../../open-sse/handlers/chatCore/telemetryHelpers.ts");
const core = await import("../../src/lib/db/core.ts");
const originalFetch = globalThis.fetch;
const originalLiveWsPort = process.env.LIVE_WS_PORT;
test.afterEach(() => {
globalThis.fetch = originalFetch;
if (originalLiveWsPort === undefined) {
delete process.env.LIVE_WS_PORT;
} else {
process.env.LIVE_WS_PORT = originalLiveWsPort;
}
});
test.after(() => {
globalThis.fetch = originalFetch;
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
// ─── forwardDashboardEventToLiveWs ───────────────────────────────────────────
test("forwardDashboardEventToLiveWs POSTs event+payload+timestamp as JSON to the default port", async () => {
delete process.env.LIVE_WS_PORT;
let capturedUrl: string | undefined;
let capturedInit: RequestInit | undefined;
globalThis.fetch = (async (url: string, init: RequestInit) => {
capturedUrl = url;
capturedInit = init;
return new Response("ok", { status: 200 });
}) as typeof fetch;
const before = Date.now();
await forwardDashboardEventToLiveWs("my-event", { foo: "bar" });
const after = Date.now();
// Default port is 20132 when LIVE_WS_PORT is unset.
assert.equal(capturedUrl, "http://127.0.0.1:20132/__omniroute_event");
assert.equal(capturedInit?.method, "POST");
assert.equal(
(capturedInit?.headers as Record<string, string>)["content-type"],
"application/json"
);
assert.ok(capturedInit?.signal, "an AbortSignal is attached for the 1.5s timeout");
const parsed = JSON.parse(capturedInit?.body as string);
assert.equal(parsed.event, "my-event");
assert.deepEqual(parsed.payload, { foo: "bar" });
assert.equal(typeof parsed.timestamp, "number");
assert.ok(
parsed.timestamp >= before && parsed.timestamp <= after,
"timestamp is Date.now() captured at call time"
);
});
test("forwardDashboardEventToLiveWs honors LIVE_WS_PORT override", async () => {
process.env.LIVE_WS_PORT = "31337";
let capturedUrl: string | undefined;
globalThis.fetch = (async (url: string) => {
capturedUrl = url;
return new Response("ok", { status: 200 });
}) as typeof fetch;
await forwardDashboardEventToLiveWs("e", null);
assert.equal(capturedUrl, "http://127.0.0.1:31337/__omniroute_event");
});
test("forwardDashboardEventToLiveWs swallows fetch rejection and still resolves", async () => {
globalThis.fetch = (async () => {
throw new Error("sidecar down");
}) as typeof fetch;
// Must not throw — best-effort sidecar bridge; the catch swallows.
await assert.doesNotReject(forwardDashboardEventToLiveWs("e", { a: 1 }));
});
// ─── maybeSyncClaudeExtraUsageState ──────────────────────────────────────────
test("maybeSyncClaudeExtraUsageState returns early when connectionId is falsy (no fetch)", async () => {
let fetchCalled = false;
globalThis.fetch = (async () => {
fetchCalled = true;
return new Response("", { status: 200 });
}) as typeof fetch;
await maybeSyncClaudeExtraUsageState({
provider: "claude",
connectionId: null,
providerSpecificData: {},
log: null,
});
assert.equal(fetchCalled, false, "guard short-circuits before any network/DB work");
});
test("maybeSyncClaudeExtraUsageState returns early for non-claude provider (block disabled)", async () => {
let fetchCalled = false;
globalThis.fetch = (async () => {
fetchCalled = true;
return new Response("", { status: 200 });
}) as typeof fetch;
await maybeSyncClaudeExtraUsageState({
provider: "openai",
connectionId: "some-conn",
providerSpecificData: {},
log: null,
});
assert.equal(fetchCalled, false, "isClaudeExtraUsageBlockEnabled is false for non-claude");
});
test("maybeSyncClaudeExtraUsageState returns early for claude with blockExtraUsage:false", async () => {
let fetchCalled = false;
globalThis.fetch = (async () => {
fetchCalled = true;
return new Response("", { status: 200 });
}) as typeof fetch;
await maybeSyncClaudeExtraUsageState({
provider: "claude",
connectionId: "some-conn",
providerSpecificData: { blockExtraUsage: false },
log: null,
});
assert.equal(fetchCalled, false, "explicit blockExtraUsage:false disables the block");
});
test("maybeSyncClaudeExtraUsageState enters the try for claude+enabled, swallows the error, and logs via log.debug", async () => {
// provider=claude, providerSpecificData={} (blockExtraUsage !== false), connectionId set
// -> passes the guard -> calls the REAL fetchLiveProviderLimits("bogus-conn") which
// looks the connection up in the (empty) DB, finds nothing, throws "Connection not found",
// and the function's internal try/catch swallows it while logging to log.debug.
const calls: unknown[][] = [];
const log = {
debug: (...args: unknown[]) => {
calls.push(args);
},
};
await assert.doesNotReject(
maybeSyncClaudeExtraUsageState({
provider: "claude",
connectionId: "bogus-conn-id",
providerSpecificData: {},
log,
})
);
assert.equal(calls.length, 1, "the swallowed error path logs exactly once");
assert.equal(calls[0][0], "CLAUDE_USAGE");
assert.match(
String(calls[0][1]),
/Failed to sync Claude extra-usage state:/,
"logs the sync-failure message with the underlying error text"
);
});