mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
46 lines
2.2 KiB
TypeScript
46 lines
2.2 KiB
TypeScript
/**
|
|
* #5477 — the combo builder's per-model option construction was extracted into a
|
|
* shared `buildModelOptions` helper (one source of truth for the synced /
|
|
* built-in / custom / fallback branches). This test drives the real builder and
|
|
* locks the custom-model **source classification** branch: a custom model whose
|
|
* stored `source` is one of api-sync/auto-sync/imported must surface as
|
|
* `imported`, everything else as `custom`. A silent divergence in that mapping is
|
|
* exactly what the extraction could introduce.
|
|
*/
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-combo-source-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const modelsDb = await import("../../src/lib/db/models.ts");
|
|
const { getComboBuilderOptions } = await import("../../src/lib/combos/builderOptions.ts");
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("#5477 buildModelOptions classifies custom-model source (manual -> custom, api-sync -> imported)", async () => {
|
|
// Attach to a no-auth provider ("opencode") — it surfaces in the builder
|
|
// without a configured connection, so the custom-model branch is exercised.
|
|
await modelsDb.addCustomModel("opencode", "zzz-manual-5477", "Manual 5477", "manual");
|
|
await modelsDb.addCustomModel("opencode", "zzz-apisync-5477", "ApiSync 5477", "api-sync");
|
|
|
|
const payload = await getComboBuilderOptions();
|
|
|
|
const allModels = payload.providers.flatMap((p) => p.models);
|
|
const manual = allModels.find((m) => m.id === "zzz-manual-5477");
|
|
const apiSync = allModels.find((m) => m.id === "zzz-apisync-5477");
|
|
|
|
assert.ok(manual, "manual custom model must appear in the combo builder output");
|
|
assert.ok(apiSync, "api-sync custom model must appear in the combo builder output");
|
|
|
|
assert.equal(manual.source, "custom", "source=manual must classify as 'custom'");
|
|
assert.equal(apiSync.source, "imported", "source=api-sync must classify as 'imported'");
|
|
});
|