Files
OmniRoute/tests/unit/microsoft-designer-web-runtime-block.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

139 lines
4.6 KiB
TypeScript

import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import test from "node:test";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-designer-retired-"));
process.env.DATA_DIR = TEST_DATA_DIR;
process.env.DISABLE_SQLITE_AUTO_BACKUP = "true";
const core = await import("../../src/lib/db/core.ts");
const providersDb = await import("../../src/lib/db/providers.ts");
const leasesDb = await import("../../src/lib/db/exclusiveConnectionLeases.ts");
const auth = await import("../../src/sse/services/auth.ts");
const LEASE_OWNER_ID = `vlo_${"D".repeat(43)}`;
const API_KEY_ID = "designer-retirement-managed-key";
async function resetStorage(): Promise<void> {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
test.beforeEach(resetStorage);
test.after(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("creating a retired Microsoft Designer connection reports its persisted tombstone", async () => {
const connection = (await providersDb.createProviderConnection({
provider: "msdesigner",
authType: "cookie",
name: "retired-designer-create",
isActive: true,
providerSpecificData: { accessToken: "test-token" },
})) as {
id: string;
isActive: boolean;
testStatus: string | null;
lastErrorType: string | null;
lastErrorSource: string | null;
};
assert.equal(connection.isActive, false);
assert.equal(connection.testStatus, "unavailable");
assert.equal(connection.lastErrorType, "provider_retired");
assert.equal(connection.lastErrorSource, "migration:retire-microsoft-designer-web");
const persisted = await providersDb.getProviderConnectionById(connection.id);
assert.equal(persisted?.isActive, false);
assert.equal(persisted?.providerSpecificData.accessToken, "test-token");
const reactivated = await providersDb.updateProviderConnection(connection.id, {
isActive: true,
testStatus: "active",
lastError: null,
lastErrorType: null,
lastErrorSource: null,
});
assert.equal(reactivated?.isActive, false);
assert.equal(reactivated?.testStatus, "unavailable");
assert.equal(reactivated?.lastErrorType, "provider_retired");
const upserted = await providersDb.createProviderConnection({
provider: "msdesigner",
authType: "cookie",
name: "retired-designer-create",
isActive: true,
testStatus: "active",
providerSpecificData: { accessToken: "replacement-token" },
});
assert.equal(upserted?.id, connection.id);
assert.equal(upserted?.isActive, false);
assert.equal(upserted?.testStatus, "unavailable");
const control = await providersDb.createProviderConnection({
provider: "openai",
authType: "apikey",
name: "openai-control",
apiKey: "sk-openai-control",
isActive: true,
});
assert.equal(control?.isActive, true);
});
test("retired Microsoft Designer credentials are rejected and an active managed lease is invalidated", async () => {
await core.ensureDbInitialized();
const db = core.getDbInstance();
for (const trigger of [
"trg_retire_microsoft_designer_web_provider_insert",
"trg_retire_microsoft_designer_web_provider_update",
"trg_retire_microsoft_designer_web_lease_insert",
"trg_retire_microsoft_designer_web_lease_update",
]) {
db.exec(`DROP TRIGGER IF EXISTS ${trigger}`);
}
const connection = (await providersDb.createProviderConnection({
provider: "microsoft-designer-web",
authType: "cookie",
name: "retired-designer",
isActive: true,
providerSpecificData: { accessToken: "test-token" },
})) as { id: string };
const acquired = leasesDb.acquireExclusiveConnectionLease({
leaseOwnerId: LEASE_OWNER_ID,
apiKeyId: API_KEY_ID,
provider: "microsoft-designer-web",
connectionId: connection.id,
});
assert.equal(acquired.kind, "ACQUIRED");
if (acquired.kind !== "ACQUIRED") return;
const selected = await auth.getProviderCredentials(
"microsoft-designer-web",
null,
[connection.id],
"dall-e-3",
{
lease: {
apiKeyId: API_KEY_ID,
context: {
leaseOwnerId: LEASE_OWNER_ID,
leaseOwnerHash: leasesDb.hashLeaseOwnerId(LEASE_OWNER_ID),
ownerDiagnostic: "designer-retirement-test",
generation: acquired.lease.generation,
},
mode: "request",
},
}
);
assert.equal(selected, null);
assert.equal(leasesDb.getActiveExclusiveConnectionLease(LEASE_OWNER_ID), null);
});