mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
80 lines
3.4 KiB
TypeScript
80 lines
3.4 KiB
TypeScript
// Route-wiring tests for the paste-credentials OAuth action.
|
|
//
|
|
// These exercise the rejection paths only — they all return 400 BEFORE the
|
|
// route touches finalizeTokens (Google APIs) or persistOAuthConnection (DB), so
|
|
// no network is hit. The happy path's finalize+persist is the same IO as the
|
|
// already-covered `device-complete` action; the new, security-relevant logic
|
|
// (allowlist + provider match + blob validation) is unit-tested in
|
|
// oauth-paste-credentials.test.ts and re-asserted through the HTTP boundary here.
|
|
//
|
|
// Auth is disabled via settings (requireLogin:false) so we reach the action
|
|
// dispatch rather than a 401. DB handles are released in test.after (CLAUDE.md
|
|
// learning: unreleased SQLite handles hang node:test).
|
|
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-paste-creds-route-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const settingsDb = await import("../../src/lib/db/settings.ts");
|
|
const route = await import("../../src/app/api/oauth/[provider]/paste-credentials/route.ts");
|
|
const { encodeCredentialBlob } = await import("../../src/lib/oauth/credentialBlob.ts");
|
|
|
|
const tokens = { access_token: "ya29.x", refresh_token: "1//r", expires_in: 3599 };
|
|
|
|
test.before(async () => {
|
|
await settingsDb.updateSettings({ requireLogin: false });
|
|
});
|
|
|
|
test.after(async () => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
async function postPaste(provider: string, body: unknown) {
|
|
const request = new Request(`http://localhost:20128/api/oauth/${provider}/paste-credentials`, {
|
|
method: "POST",
|
|
headers: { "Content-Type": "application/json" },
|
|
body: JSON.stringify(body),
|
|
});
|
|
const response = await route.POST(request, {
|
|
params: Promise.resolve({ provider, action: "paste-credentials" }),
|
|
} as never);
|
|
return { status: response.status, body: await response.json() };
|
|
}
|
|
|
|
test("paste-credentials: non-allowlisted provider is rejected with 400", async () => {
|
|
const blob = encodeCredentialBlob({ provider: "openai", tokens });
|
|
const { status, body } = await postPaste("openai", { blob });
|
|
assert.equal(status, 400);
|
|
assert.match(body.error, /not supported|supported/i);
|
|
});
|
|
|
|
test("paste-credentials: malformed blob is rejected with 400", async () => {
|
|
const { status, body } = await postPaste("antigravity", { blob: "totally-not-a-blob" });
|
|
assert.equal(status, 400);
|
|
assert.match(body.error, /invalid|format|prefix/i);
|
|
});
|
|
|
|
test("paste-credentials: provider mismatch (blob for antigravity, route agy) → 400", async () => {
|
|
const blob = encodeCredentialBlob({ provider: "antigravity", tokens });
|
|
const { status, body } = await postPaste("agy", { blob });
|
|
assert.equal(status, 400);
|
|
assert.match(body.error, /match|mismatch|provider/i);
|
|
});
|
|
|
|
test("paste-credentials: empty body fails schema validation with 400", async () => {
|
|
const { status } = await postPaste("antigravity", {});
|
|
assert.equal(status, 400);
|
|
});
|
|
|
|
test("paste-credentials: error responses never leak a stack trace", async () => {
|
|
const { body } = await postPaste("antigravity", { blob: "totally-not-a-blob" });
|
|
assert.ok(!String(body.error).includes("at /"), "must not leak a stack trace");
|
|
});
|