mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
92 lines
2.9 KiB
TypeScript
92 lines
2.9 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
// Isolate DATA_DIR before importing validation.ts (it initializes the DB on load)
|
|
// so the test never touches the developer's real ~/.omniroute database.
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omr-proxy-ssrf-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const { isRetryableProxyTarget } = await import("../../src/lib/providers/validation.ts");
|
|
const { isPrivateHost } = await import("../../src/shared/network/outboundUrlGuard.ts");
|
|
|
|
test.after(() => {
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
/**
|
|
* SSRF hardening for the proxy auto-fallback (PR #3171). When provider
|
|
* validation fails, the proxy-fallback path must NEVER auto-discover a proxy and
|
|
* re-fetch a private / link-local / cloud-metadata target. The original PR's
|
|
* inline host check missed several ranges; both the validation gate and the
|
|
* canonical guard must now reject all of them.
|
|
*/
|
|
|
|
const PRIVATE_TARGETS = [
|
|
"http://169.254.169.254/latest/meta-data/", // AWS/GCP/Azure metadata — the classic SSRF target
|
|
"http://169.254.170.2/", // ECS task metadata
|
|
"http://0.0.0.0:8080/",
|
|
"http://127.0.0.1/",
|
|
"http://127.10.20.30/", // 127/8, not just 127.0.0.1
|
|
"http://10.0.0.5/",
|
|
"http://192.168.1.1/",
|
|
"http://172.16.0.1/",
|
|
"http://172.31.255.255/",
|
|
"http://100.64.0.1/", // CGNAT
|
|
"http://[::1]/",
|
|
"http://[fc00::1]/", // IPv6 ULA
|
|
"http://[fd12:3456::1]/",
|
|
"http://[fe80::1]/", // IPv6 link-local
|
|
"http://metadata.google.internal/", // .internal metadata hostname
|
|
"http://service.local/",
|
|
];
|
|
|
|
const PUBLIC_TARGETS = [
|
|
"https://api.openai.com/v1/models",
|
|
"https://api.anthropic.com/v1/messages",
|
|
"https://example.com/",
|
|
"http://8.8.8.8/",
|
|
];
|
|
|
|
test("isRetryableProxyTarget rejects every private / link-local / metadata host", () => {
|
|
for (const url of PRIVATE_TARGETS) {
|
|
assert.equal(
|
|
isRetryableProxyTarget(url),
|
|
false,
|
|
`${url} must NOT be eligible for proxy-fallback (SSRF)`
|
|
);
|
|
}
|
|
});
|
|
|
|
test("isRetryableProxyTarget allows public provider targets", () => {
|
|
for (const url of PUBLIC_TARGETS) {
|
|
assert.equal(
|
|
isRetryableProxyTarget(url),
|
|
true,
|
|
`${url} should be a valid proxy-fallback target`
|
|
);
|
|
}
|
|
});
|
|
|
|
test("isRetryableProxyTarget fails closed on an unparseable URL", () => {
|
|
assert.equal(isRetryableProxyTarget("not a url"), false);
|
|
});
|
|
|
|
test("canonical isPrivateHost covers the SSRF ranges the route guard relies on", () => {
|
|
for (const host of [
|
|
"169.254.169.254",
|
|
"0.0.0.0",
|
|
"127.10.20.30",
|
|
"172.16.0.1",
|
|
"100.64.0.1",
|
|
"fc00::1",
|
|
"fe80::1",
|
|
"metadata.google.internal",
|
|
]) {
|
|
assert.equal(isPrivateHost(host), true, `${host} must be classified private`);
|
|
}
|
|
assert.equal(isPrivateHost("api.openai.com"), false);
|
|
});
|