Files
OmniRoute/tests/unit/reasoning-routing-api.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

151 lines
5.0 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-reasoning-api-"));
process.env.DATA_DIR = TEST_DATA_DIR;
process.env.API_KEY_SECRET = process.env.API_KEY_SECRET || "test-reasoning-api-secret";
const core = await import("../../src/lib/db/core.ts");
const apiKeysDb = await import("../../src/lib/db/apiKeys.ts");
const rulesDb = await import("../../src/lib/db/reasoningRoutingRules.ts");
const collectionRoute = await import("../../src/app/api/settings/reasoning-routing-rules/route.ts");
const itemRoute = await import("../../src/app/api/settings/reasoning-routing-rules/[id]/route.ts");
const simulateRoute =
await import("../../src/app/api/settings/reasoning-routing-rules/simulate/route.ts");
type RuleResponse = {
rule: rulesDb.ReasoningRoutingRule;
};
type RuleListResponse = {
rules: rulesDb.ReasoningRoutingRule[];
};
type SimulationResponse = {
matched: boolean;
decision: {
targetModel: string;
targetEffort: string | null;
capability: "supported" | "unsupported" | "unknown";
};
errors: string[];
};
async function resetStorage() {
apiKeysDb.resetApiKeyState();
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
rulesDb.invalidateReasoningRoutingRuleCache();
}
function request(pathname: string, method = "GET", body?: unknown) {
return new Request(`http://localhost${pathname}`, {
method,
headers: body === undefined ? undefined : { "content-type": "application/json" },
body: body === undefined ? undefined : JSON.stringify(body),
});
}
function rulePayload() {
return {
name: "API rule",
description: "Created through management API",
scope: "global",
sourceEffort: "missing",
requestTags: ["coding"],
tagMatchMode: "any",
effortMode: "force",
targetEffort: "high",
targetKind: "model",
targetModel: "custom/unknown-reasoning-model",
budgetAction: "preserve",
priority: 5,
enabled: true,
};
}
test.beforeEach(resetStorage);
test.after(async () => {
await resetStorage();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("management API CRUD validates and persists reasoning routing rules", async () => {
const createdResponse = await collectionRoute.POST(
request("/api/settings/reasoning-routing-rules", "POST", rulePayload())
);
assert.equal(createdResponse.status, 201);
const created = (await createdResponse.json()) as RuleResponse;
assert.equal(created.rule.name, "API rule");
const listedResponse = await collectionRoute.GET(
request("/api/settings/reasoning-routing-rules")
);
const listed = (await listedResponse.json()) as RuleListResponse;
assert.equal(listed.rules.length, 1);
const patchedResponse = await itemRoute.PATCH(
request(`/api/settings/reasoning-routing-rules/${created.rule.id}`, "PATCH", {
priority: 50,
}),
{ params: Promise.resolve({ id: created.rule.id }) }
);
const patched = (await patchedResponse.json()) as RuleResponse;
assert.equal(patched.rule.priority, 50);
const deletedResponse = await itemRoute.DELETE(
request(`/api/settings/reasoning-routing-rules/${created.rule.id}`, "DELETE"),
{ params: Promise.resolve({ id: created.rule.id }) }
);
assert.equal(deletedResponse.status, 200);
assert.equal((await rulesDb.getReasoningRoutingRules()).length, 0);
});
test("management API rejects invalid references and invalid none/budget conflicts", async () => {
const missingKey = await collectionRoute.POST(
request("/api/settings/reasoning-routing-rules", "POST", {
...rulePayload(),
scope: "apiKey",
apiKeyId: "missing-api-key",
})
);
assert.equal(missingKey.status, 400);
const conflict = await collectionRoute.POST(
request("/api/settings/reasoning-routing-rules", "POST", {
...rulePayload(),
targetEffort: "none",
budgetAction: "set",
budgetTokens: 1024,
})
);
assert.equal(conflict.status, 400);
});
test("simulator returns the same winning target and capability warning without upstream", async () => {
await collectionRoute.POST(
request("/api/settings/reasoning-routing-rules", "POST", rulePayload())
);
const response = await simulateRoute.POST(
request("/api/settings/reasoning-routing-rules/simulate", "POST", {
model: "openai/gpt-4o-mini",
effort: "missing",
requestTags: ["coding"],
transport: "http",
})
);
const body = (await response.json()) as SimulationResponse;
assert.equal(response.status, 200);
assert.equal(body.matched, true);
assert.equal(body.decision.targetModel, "custom/unknown-reasoning-model");
assert.equal(body.decision.targetEffort, "high");
assert.equal(body.decision.capability, "unknown");
assert.equal(body.errors.length, 0);
});