Files
OmniRoute/tests/unit/require-management-auth-access-token.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

108 lines
4.5 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
// Integration: the management auth gate must accept scoped CLI access tokens
// (`oma_...`) and enforce the method+admin-allowlist scope policy. Other
// credential paths (dashboard JWT, loopback CLI token, manage-scope API key)
// are unaffected. Isolated DATA_DIR + DB handle closed in test.after.
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-mgmt-auth-"));
process.env.DATA_DIR = TEST_DATA_DIR;
process.env.DISABLE_SQLITE_AUTO_BACKUP = "true";
// Force isAuthRequired() === true deterministically (config'd password present).
process.env.INITIAL_PASSWORD = "test-pass";
const core = await import("../../src/lib/db/core.ts");
const at = await import("../../src/lib/db/accessTokens.ts");
const { requireManagementAuth } = await import("../../src/lib/api/requireManagementAuth.ts");
const BASE = "http://localhost:20128";
function req(method: string, pathname: string, token?: string): Request {
const headers: Record<string, string> = {};
if (token) headers.authorization = `Bearer ${token}`;
return new Request(`${BASE}${pathname}`, { method, headers });
}
test.after(() => {
try {
core.resetDbInstance();
} catch {}
try {
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
} catch {}
delete process.env.INITIAL_PASSWORD;
delete process.env.OMNIROUTE_INTERNAL_SERVICE_TOKEN;
});
test("internal service token requires the trusted loopback locality marker", async () => {
process.env.OMNIROUTE_INTERNAL_SERVICE_TOKEN = "internal-service-token-0123456789";
const tokenHeader = "x-omniroute-internal-service-token";
const local = new Request(`${BASE}/api/combos`, {
headers: {
[tokenHeader]: "internal-service-token-0123456789",
"x-omniroute-peer-locality": "loopback",
},
});
assert.equal(await requireManagementAuth(local), null);
const remote = new Request(`${BASE}/api/combos`, {
headers: {
[tokenHeader]: "internal-service-token-0123456789",
"x-omniroute-peer-locality": "remote",
},
});
assert.equal((await requireManagementAuth(remote))?.status, 401);
});
test("read token: allowed on GET, rejected (403) on a write route", async () => {
const { secret } = at.createAccessToken({ name: "read-tok", scope: "read" });
assert.equal(await requireManagementAuth(req("GET", "/api/v1/models", secret)), null);
const denied = await requireManagementAuth(req("POST", "/api/keys", secret));
assert.ok(denied, "expected a rejection Response");
assert.equal(denied?.status, 403);
});
test("write token: allowed on write route, rejected (403) on admin route", async () => {
const { secret } = at.createAccessToken({ name: "write-tok", scope: "write" });
assert.equal(await requireManagementAuth(req("POST", "/api/keys", secret)), null);
assert.equal(await requireManagementAuth(req("GET", "/api/v1/models", secret)), null);
const denied = await requireManagementAuth(req("POST", "/api/cli/tokens", secret));
assert.equal(denied?.status, 403);
});
test("admin token: allowed on admin route", async () => {
const { secret } = at.createAccessToken({ name: "admin-tok", scope: "admin" });
assert.equal(await requireManagementAuth(req("POST", "/api/cli/tokens", secret)), null);
assert.equal(await requireManagementAuth(req("POST", "/api/providers", secret)), null);
});
test("invalid/expired access token is rejected with 401", async () => {
const bad = await requireManagementAuth(
req("GET", "/api/v1/models", "oma_live_not_a_real_token")
);
assert.equal(bad?.status, 401);
const past = new Date(Date.now() - 60_000).toISOString();
const { secret } = at.createAccessToken({ name: "exp", scope: "admin", expiresAt: past });
const expired = await requireManagementAuth(req("GET", "/api/v1/models", secret));
assert.equal(expired?.status, 401);
});
test("revoked access token is rejected", async () => {
const { secret, record } = at.createAccessToken({ name: "rev", scope: "admin" });
assert.equal(await requireManagementAuth(req("GET", "/api/v1/models", secret)), null);
at.revokeAccessToken(record.id);
const denied = await requireManagementAuth(req("GET", "/api/v1/models", secret));
assert.equal(denied?.status, 401);
});
test("no credential at all → 401 (auth still required)", async () => {
const denied = await requireManagementAuth(req("GET", "/api/v1/models"));
assert.equal(denied?.status, 401);
});