mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
61 lines
2.1 KiB
TypeScript
61 lines
2.1 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
let tempDir: string;
|
|
let originalDataDir: string | undefined;
|
|
|
|
function setup() {
|
|
tempDir = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-stmt-cache-"));
|
|
originalDataDir = process.env.DATA_DIR;
|
|
process.env.DATA_DIR = tempDir;
|
|
}
|
|
|
|
function cleanup() {
|
|
try {
|
|
const { resetDbInstance } = require("../../src/lib/db/core.ts");
|
|
resetDbInstance();
|
|
} catch {}
|
|
if (originalDataDir !== undefined) {
|
|
process.env.DATA_DIR = originalDataDir;
|
|
} else {
|
|
delete process.env.DATA_DIR;
|
|
}
|
|
try {
|
|
fs.rmSync(tempDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
} catch {}
|
|
}
|
|
|
|
test("statement cache handles 200+ unique SELECTs without errors (LRU eviction)", async () => {
|
|
setup();
|
|
try {
|
|
const { getDbInstance } = await import("../../src/lib/db/core.ts");
|
|
const db = getDbInstance();
|
|
|
|
// Create a test table and insert a row so SELECTs are valid
|
|
db.exec("CREATE TABLE IF NOT EXISTS stmt_cache_test (id INTEGER PRIMARY KEY, val TEXT)");
|
|
db.exec("INSERT INTO stmt_cache_test (id, val) VALUES (1, 'hello')");
|
|
|
|
// Prepare 250 unique SELECT statements (exceeds MAX_STMT_CACHE_SIZE of 200)
|
|
const uniqueStatements = 250;
|
|
for (let i = 0; i < uniqueStatements; i++) {
|
|
const sql = `SELECT ${i} AS seq, val FROM stmt_cache_test WHERE id = 1`;
|
|
const stmt = db.prepare(sql);
|
|
const row = stmt.get() as { seq: number; val: string } | undefined;
|
|
assert.ok(row, `statement ${i} should return a row`);
|
|
assert.equal(row.seq, i, `statement ${i} should have correct seq`);
|
|
assert.equal(row.val, "hello", `statement ${i} should have correct val`);
|
|
}
|
|
|
|
// Verify the DB is still functional after eviction churn
|
|
const finalRow = db.prepare("SELECT COUNT(*) AS cnt FROM stmt_cache_test").get() as {
|
|
cnt: number;
|
|
};
|
|
assert.equal(finalRow.cnt, 1, "table should still have 1 row after cache churn");
|
|
} finally {
|
|
cleanup();
|
|
}
|
|
});
|