Files
OmniRoute/tests/unit/zai-web-model-sync-route.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

95 lines
3.3 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-zai-model-sync-"));
process.env.DATA_DIR = TEST_DATA_DIR;
if (!process.env.API_KEY_SECRET) {
process.env.API_KEY_SECRET = `test-zai-model-sync-${Date.now()}`;
}
const core = await import("../../src/lib/db/core.ts");
const apiKeysDb = await import("../../src/lib/db/apiKeys.ts");
const modelsDb = await import("../../src/lib/db/models.ts");
const providersDb = await import("../../src/lib/db/providers.ts");
const modelSyncRoute = await import("../../src/app/api/providers/[id]/sync-models/route.ts");
const scheduler = await import("../../src/shared/services/modelSyncScheduler.ts");
const originalFetch = globalThis.fetch;
async function resetStorage() {
delete process.env.INITIAL_PASSWORD;
globalThis.fetch = originalFetch;
modelSyncRoute.__resetLoopbackReadinessForTests();
core.resetDbInstance();
apiKeysDb.resetApiKeyState();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
test.after(() => {
globalThis.fetch = originalFetch;
core.resetDbInstance();
apiKeysDb.resetApiKeyState();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("curated zai-web sync removes stale imported models without touching manual models", async () => {
await resetStorage();
const connection = await providersDb.createProviderConnection({
provider: "zai-web",
authType: "apikey",
name: "Z.ai Web",
apiKey: "current-local-storage-token",
});
await modelsDb.replaceSyncedAvailableModelsForConnection("zai-web", connection.id, [
{ id: "glm-4.6v", name: "GLM-4.6V", source: "imported" },
{ id: "deep-research", name: "Z1-Rumination", source: "imported" },
]);
await modelsDb.addCustomModel("zai-web", "glm-4-air-250414", "GLM-4-32B", "imported");
await modelsDb.addCustomModel("zai-web", "manual-keep", "Manual Keep", "manual");
let fetchCalls = 0;
globalThis.fetch = (async () => {
fetchCalls += 1;
throw new Error("curated provider sync must not fetch a remote model catalog");
}) as typeof globalThis.fetch;
const response = await modelSyncRoute.POST(
new Request(`http://localhost/api/providers/${connection.id}/sync-models`, {
method: "POST",
headers: scheduler.buildModelSyncInternalHeaders(),
}),
{ params: { id: connection.id } }
);
const body = (await response.json()) as {
source: string;
skipped: string;
cleanup: {
removedSyncedLists: number;
removedImportedModels: number;
};
};
const syncedModels = await modelsDb.getSyncedAvailableModels("zai-web");
const customModels = (await modelsDb.getCustomModels("zai-web")) as Array<{
id: string;
source: string;
}>;
assert.equal(response.status, 200);
assert.equal(body.source, "curated");
assert.equal(body.skipped, "curated-models-only");
assert.deepEqual(body.cleanup, {
removedSyncedLists: 1,
removedImportedModels: 1,
});
assert.deepEqual(syncedModels, []);
assert.deepEqual(
customModels.map((model) => ({ id: model.id, source: model.source })),
[{ id: "manual-keep", source: "manual" }]
);
assert.equal(fetchCalls, 0);
});