Files
OmniRoute/tests/unit/conversationTurnContent.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

142 lines
5.1 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
// conversationTurnContent.ts resolves a conversation_turn_nodes row's actual
// display text/tool-call shape on demand from the call-log artifact its
// last_correlation_id points at (migration 156 dropped the old stored
// text_preview/block_kind/tool_name columns -- see conversationTracker.ts).
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-conv-turn-content-"));
process.env.DATA_DIR = TEST_DATA_DIR;
const core = await import("../../src/lib/db/core.ts");
const { hashTurnContent } = await import("../../open-sse/services/conversationTracker.ts");
const { resolveTurnDisplayContent } =
await import("../../open-sse/services/conversationTurnContent.ts");
test.after(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
function insertCallLog(row: { id: string; correlationId: string; artifactRelPath: string | null }) {
const db = core.getDbInstance();
db.prepare(
`INSERT INTO call_logs (id, timestamp, method, path, status, model, correlation_id, artifact_relpath)
VALUES (?, ?, 'POST', '/v1/chat/completions', 200, 'big-pickle', ?, ?)`
).run(row.id, new Date().toISOString(), row.correlationId, row.artifactRelPath);
}
function writeArtifact(relPath: string, clientRawRequestBody: unknown) {
const absPath = path.join(TEST_DATA_DIR, "call_logs", relPath);
fs.mkdirSync(path.dirname(absPath), { recursive: true });
fs.writeFileSync(
absPath,
JSON.stringify({
schemaVersion: 5,
requestBody: null,
responseBody: null,
error: null,
pipeline: {
clientRawRequest: { body: clientRawRequestBody },
},
})
);
}
test("resolveTurnDisplayContent resolves plain text turns from the artifact's raw request body", () => {
insertCallLog({ id: "log-1", correlationId: "corr-1", artifactRelPath: "2026-01-01/log-1.json" });
writeArtifact("2026-01-01/log-1.json", {
messages: [
{ role: "user", content: "hello there" },
{ role: "assistant", content: "hi!" },
],
});
const result = resolveTurnDisplayContent([{ lastCorrelationId: "corr-1" }]);
const userHash = hashTurnContent({
role: "user",
text: "hello there",
blockKind: "text",
toolName: null,
});
assert.deepEqual(result.get(userHash), {
textPreview: "hello there",
blockKind: "text",
toolName: null,
});
});
test("resolveTurnDisplayContent resolves tool_use/tool_result shape, full and untruncated", () => {
const bigArgs = JSON.stringify({ path: "/tmp/big.md", content: "line\n".repeat(2000) });
insertCallLog({ id: "log-2", correlationId: "corr-2", artifactRelPath: "2026-01-01/log-2.json" });
writeArtifact("2026-01-01/log-2.json", {
input: [{ type: "function_call", name: "write", call_id: "c1", arguments: bigArgs }],
});
const result = resolveTurnDisplayContent([{ lastCorrelationId: "corr-2" }]);
const hash = hashTurnContent({
role: "tool",
text: bigArgs,
blockKind: "tool_use",
toolName: "write",
});
const content = result.get(hash);
assert.equal(content?.blockKind, "tool_use");
assert.equal(content?.toolName, "write");
// No 8000-char truncation anymore -- the full raw arguments string survives.
assert.equal(content?.textPreview, bigArgs);
assert.ok(content!.textPreview.length > 8000);
});
test("resolveTurnDisplayContent groups nodes by correlation id, reading each artifact once", () => {
insertCallLog({ id: "log-3", correlationId: "corr-3", artifactRelPath: "2026-01-01/log-3.json" });
writeArtifact("2026-01-01/log-3.json", {
messages: [
{ role: "user", content: "a" },
{ role: "assistant", content: "b" },
{ role: "user", content: "c" },
],
});
const result = resolveTurnDisplayContent([
{ lastCorrelationId: "corr-3" },
{ lastCorrelationId: "corr-3" },
{ lastCorrelationId: "corr-3" },
]);
for (const [role, text] of [
["user", "a"],
["assistant", "b"],
["user", "c"],
] as const) {
const hash = hashTurnContent({ role, text, blockKind: "text", toolName: null });
assert.equal(result.get(hash)?.textPreview, text);
}
});
test("resolveTurnDisplayContent skips nodes with no correlation id without throwing", () => {
const result = resolveTurnDisplayContent([{ lastCorrelationId: null }]);
assert.equal(result.size, 0);
});
test("resolveTurnDisplayContent omits content for an unresolvable correlation id (missing call_logs row, purged artifact, or no pipeline captured)", () => {
const missingRow = resolveTurnDisplayContent([{ lastCorrelationId: "corr-does-not-exist" }]);
assert.equal(missingRow.size, 0);
insertCallLog({ id: "log-4", correlationId: "corr-4", artifactRelPath: null });
const noArtifact = resolveTurnDisplayContent([{ lastCorrelationId: "corr-4" }]);
assert.equal(noArtifact.size, 0);
insertCallLog({
id: "log-5",
correlationId: "corr-5",
artifactRelPath: "2026-01-01/does-not-exist.json",
});
const missingFile = resolveTurnDisplayContent([{ lastCorrelationId: "corr-5" }]);
assert.equal(missingFile.size, 0);
});