Files
OmniRoute/tests/unit/kiro-social-poll.test.ts
Krishna lokhande 671aa3d80d fix(oauth): treat Kiro social poll status as alias of error for pending states (#10620)
Kiro's device poll endpoint reports progress in a `status` field (e.g.
`authorization_pending`), but `classifyKiroSocialPoll()` only inspected
`data.error`. This caused every pre-authorization poll to fall through to
the terminal `invalid_token_response` error, making social login impossible
for Kiro AI and Amazon Q via Google/GitHub.

Changes:
- Add `status` field to `KiroSocialPollData` type
- Update `classifyKiroSocialPoll()` to check `data.status` as fallback
  for `data.error` when detecting pending states
- Add tests covering `status`-based pending detection and precedence

Closes #10618
2026-08-18 10:53:29 -03:00

67 lines
2.3 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import { classifyKiroSocialPoll, getNextKiroSocialPollInterval } from "@/lib/oauth/kiroSocialPoll";
test("slow_down permanently increases the polling interval for this authorization flow", () => {
const slowed = getNextKiroSocialPollInterval(5_000, "slow_down");
assert.equal(slowed, 10_000);
assert.equal(getNextKiroSocialPollInterval(slowed, "authorization_pending"), 10_000);
assert.equal(getNextKiroSocialPollInterval(slowed, "network_error"), 10_000);
});
test("classifyKiroSocialPoll keeps only documented pending states retryable", () => {
assert.deepEqual(classifyKiroSocialPoll(false, 400, { error: "authorization_pending" }), {
kind: "pending",
error: "authorization_pending",
});
assert.deepEqual(classifyKiroSocialPoll(false, 429, { error: "slow_down" }), {
kind: "pending",
error: "slow_down",
});
});
test("classifyKiroSocialPoll treats status as alias of error for pending states", () => {
// Kiro upstream returns progress in `status`, not `error`
assert.deepEqual(classifyKiroSocialPoll(true, 200, { status: "authorization_pending" }), {
kind: "pending",
error: "authorization_pending",
});
assert.deepEqual(classifyKiroSocialPoll(true, 200, { status: "slow_down" }), {
kind: "pending",
error: "slow_down",
});
// error takes precedence over status if both present
assert.deepEqual(
classifyKiroSocialPoll(true, 200, { error: "slow_down", status: "authorization_pending" }),
{
kind: "pending",
error: "slow_down",
}
);
});
test("classifyKiroSocialPoll stops on denied, expired and malformed responses", () => {
assert.deepEqual(classifyKiroSocialPoll(false, 403, { error: "access_denied" }), {
kind: "error",
error: "access_denied",
status: 403,
});
assert.deepEqual(classifyKiroSocialPoll(true, 200, { error: "expired_token" }), {
kind: "error",
error: "expired_token",
status: 400,
});
assert.deepEqual(classifyKiroSocialPoll(true, 200, {}), {
kind: "error",
error: "invalid_token_response",
status: 502,
});
});
test("classifyKiroSocialPoll accepts a token response", () => {
assert.deepEqual(classifyKiroSocialPoll(true, 200, { accessToken: "token" }), {
kind: "success",
});
});