mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-07-26 09:52:11 +03:00
* feat(plugins): WordPress-style plugin system backend * fix(plugins): address code review feedback - Path traversal guard: validate entryPoint stays within plugin dir - install() now handles direct plugin directories (not just parent dirs) - Non-null assertion replaced with explicit null check - require efficiency: allowedModules map moved outside function - Source wrapper: add newlines to prevent trailing comment issues - Config validation: validate values against configSchema on save - Dynamic import comment: clarify Node.js caching behavior Co-Authored-By: OpenClaude (mimo-v2.5-pro) <openclaude@gitlawb.com> * fix(plugins): replace vm with child_process, add auth to all routes Addresses all remaining code review feedback: 1. **Loader rewrite**: Replaced Node.js vm module with child_process.fork() for proper process-level isolation. Complies with Rule 3 (no eval). Each plugin runs in a separate Node.js process with IPC communication. 2. **Auth on all routes**: Added requireManagementAuth to all 6 plugin API route files (list, install, scan, details, activate, deactivate, config). 3. **Env filtering**: Only safe env vars passed to plugin processes unless "env" permission is granted. Co-Authored-By: OpenClaude (mimo-v2.5-pro) <openclaude@gitlawb.com> * fix(plugins): security + ESM fixes for loader and manager loader.ts: - Fix IPC: use process.send()/process.on("message") instead of worker_threads.parentPort - Fix ESM: write host script as .mjs (not .js) to force ESM execution - Add timeout: 10s default on callHook() with Promise.race - Add SIGKILL escalation: SIGTERM first, then SIGKILL after 3s grace - Fix env filtering: use allowlist (safeKeys) instead of passing all env vars - Clear timeout on successful IPC response (no timer leak) manager.ts: - Fix path traversal: use fs.realpath() instead of startsWith() - Fix imports: use registerHook/unregisterHooks from hooks.ts - Register hooks individually via registerHook(event, name, handler) hooks.ts: - Copied from feat/plugin-custom-hooks (canonical registry) * feat(discovery): add discovery tool stub service Phase 1 scaffold for automated provider discovery: - DiscoveryConfig, DiscoveryResult types - probeEndpoint() for URL availability checking - scanProvider() stub (Phase 2 will implement real scanning) - getDiscoveryResults() stub - Default config: disabled (opt-in) * chore(plugins): slop cleanup — pino logger, remove redundant sorts - index.ts: replace console.log/error with pino structured logging - hooks.ts: remove redundant .sort() in emitHookBlocking/runOnResponse (already sorted on registration) - manager.ts: add readFile import * test(plugins): add scanner, loader, manager unit tests - scanner: 9 tests (discovery, hidden dirs, validation, entry point, multiple) - loader: 5 tests (type contracts, Plugin/PluginContext/PluginResult interfaces) - manager: 6 tests (singleton, lifecycle methods, error on unknown) - Total: 20 tests, all passing * fix(settings): add missing home page pin keys to updateSettingsSchema * feat(plugins): add i18n keys to all 42 locales * fix(settings): add missing security keys to updateSettingsSchema and add tests * fix(usage): analytics route reads combo_name/requested_model from call_logs only The 3.8.6 variant of #2904 added SELECTs of combo_name/requested_model against usage_history, but those columns only exist in call_logs (no migration adds them to usage_history). This returned HTTP 500 on /api/usage/analytics. Restore the working query shape from the 3.8.7 variant. Fixes 18 failing usage-analytics-route tests. * fix(types,test): resolve noImplicitAny in progressiveAging + align semaphore test to #2903 gate pruning - progressiveAging: type compression results so messages[0].content is indexable (was TS7053 against {}); restores typecheck:noimplicit:core gate. - services-branch-hardening: #2903 (perf-ram) prunes idle rate-limit gates on zero; assert no-running/empty-queue without assuming the entry persists. * fix(analytics): address merged review regressions * fix(executor): normalize max effort for openai shape providers * Make zero-latency combo optimizations opt-in * Address zero-latency combo review feedback * chore(release): sync v3.8.7 touchpoints + credit contributors - llm.txt → 3.8.7 (Current version + Key Features header) - CHANGELOG: add Dmitry Kuznetsov & Nikolay Alafuzov to 3.8.6 Hall of Contributors - version already 3.8.7 across package.json/open-sse/electron/openapi (from #2909) * fix(cleanup): restore usage history cutoff boundary * docs(changelog): rank 3.8.6 contributors in a commits table with their PRs * fix(dashboard): theme ReactFlow Controls +/- buttons for dark mode * fix(settings): add missing home page pin keys to updateSettingsSchema * fix(settings): add missing security keys to updateSettingsSchema and add tests * fix(executor): normalize max effort for openai shape providers * Make zero-latency combo optimizations opt-in * Address zero-latency combo review feedback * fix(analytics): address merged review regressions * fix(cleanup): restore usage history cutoff boundary * feat(plugins): WordPress-style plugin system backend * fix(plugins): address code review feedback - Path traversal guard: validate entryPoint stays within plugin dir - install() now handles direct plugin directories (not just parent dirs) - Non-null assertion replaced with explicit null check - require efficiency: allowedModules map moved outside function - Source wrapper: add newlines to prevent trailing comment issues - Config validation: validate values against configSchema on save - Dynamic import comment: clarify Node.js caching behavior Co-Authored-By: OpenClaude (mimo-v2.5-pro) <openclaude@gitlawb.com> * fix(plugins): replace vm with child_process, add auth to all routes Addresses all remaining code review feedback: 1. **Loader rewrite**: Replaced Node.js vm module with child_process.fork() for proper process-level isolation. Complies with Rule 3 (no eval). Each plugin runs in a separate Node.js process with IPC communication. 2. **Auth on all routes**: Added requireManagementAuth to all 6 plugin API route files (list, install, scan, details, activate, deactivate, config). 3. **Env filtering**: Only safe env vars passed to plugin processes unless "env" permission is granted. Co-Authored-By: OpenClaude (mimo-v2.5-pro) <openclaude@gitlawb.com> * fix(plugins): security + ESM fixes for loader and manager loader.ts: - Fix IPC: use process.send()/process.on("message") instead of worker_threads.parentPort - Fix ESM: write host script as .mjs (not .js) to force ESM execution - Add timeout: 10s default on callHook() with Promise.race - Add SIGKILL escalation: SIGTERM first, then SIGKILL after 3s grace - Fix env filtering: use allowlist (safeKeys) instead of passing all env vars - Clear timeout on successful IPC response (no timer leak) manager.ts: - Fix path traversal: use fs.realpath() instead of startsWith() - Fix imports: use registerHook/unregisterHooks from hooks.ts - Register hooks individually via registerHook(event, name, handler) hooks.ts: - Copied from feat/plugin-custom-hooks (canonical registry) * feat(discovery): add discovery tool stub service Phase 1 scaffold for automated provider discovery: - DiscoveryConfig, DiscoveryResult types - probeEndpoint() for URL availability checking - scanProvider() stub (Phase 2 will implement real scanning) - getDiscoveryResults() stub - Default config: disabled (opt-in) * chore(plugins): slop cleanup — pino logger, remove redundant sorts - index.ts: replace console.log/error with pino structured logging - hooks.ts: remove redundant .sort() in emitHookBlocking/runOnResponse (already sorted on registration) - manager.ts: add readFile import * test(plugins): add scanner, loader, manager unit tests - scanner: 9 tests (discovery, hidden dirs, validation, entry point, multiple) - loader: 5 tests (type contracts, Plugin/PluginContext/PluginResult interfaces) - manager: 6 tests (singleton, lifecycle methods, error on unknown) - Total: 20 tests, all passing * feat(plugins): add i18n keys to all 42 locales * chore(plugins): remove duplicate migration 059_create_plugins.sql * chore(plugins): remove duplicate migration 059_create_plugins.sql (post-merge) * fix(sse): guard non-string error.code in proxyFetch + harden model parsing (#2463) (#2923) Integrated into release/v3.8.7 * fix(docker): add runner-web stage with Playwright Chromium (#2832) (#2846) Integrated into release/v3.8.7 * docs(changelog): document NVIDIA NIM and error code type-crash fix (#2463) * test: ignore NVIDIA_BASE_URL and NVIDIA_MODEL in env contract check --------- Co-authored-by: oyi77 <oyi77@users.noreply.github.com> Co-authored-by: OpenClaude (mimo-v2.5-pro) <openclaude@gitlawb.com> Co-authored-by: Apostol Apostolov <theapoapostolov@gmail.com> Co-authored-by: Halil Tezcan KARABULUT <info@hlltzcnkb.com> Co-authored-by: R.D. <rogerproself@gmail.com>
322 lines
11 KiB
JavaScript
322 lines
11 KiB
JavaScript
#!/usr/bin/env node
|
|
/**
|
|
* Strict environment variable contract checker.
|
|
*
|
|
* Enforces that every env var referenced in OmniRoute source code appears in
|
|
* both `.env.example` and `docs/reference/ENVIRONMENT.md`, and that the two files agree
|
|
* on the documented var set. Falls back to a small allowlist for variables
|
|
* that are intentionally documented but not literally referenced (legacy
|
|
* aliases, future-supported hooks) or vice versa.
|
|
*
|
|
* Usage:
|
|
* node scripts/check/check-env-doc-sync.mjs # strict (CI mode)
|
|
* node scripts/check/check-env-doc-sync.mjs --lenient # legacy report-only mode
|
|
*
|
|
* Strict mode exits non-zero if any of these are non-empty:
|
|
* - vars in code but missing from .env.example
|
|
* - vars in .env.example but missing from ENVIRONMENT.md
|
|
* - vars in ENVIRONMENT.md but missing from .env.example
|
|
*
|
|
* Programmatic API:
|
|
* Other Node tests can `import { runEnvDocSync } from "./check-env-doc-sync.mjs"`
|
|
* and pass `{ root, envExample, envDoc, codeVars, ignore, docOnlyAllowlist,
|
|
* envOnlyAllowlist }` to drive the checker against fixtures.
|
|
*/
|
|
|
|
import fs from "node:fs";
|
|
import path from "node:path";
|
|
import { fileURLToPath } from "node:url";
|
|
import { execSync } from "node:child_process";
|
|
|
|
const __dirname = path.dirname(fileURLToPath(import.meta.url));
|
|
const REPO_ROOT = path.resolve(__dirname, "..", "..");
|
|
|
|
// ─── Allowlists ────────────────────────────────────────────────────────────
|
|
// Env vars referenced in code that should NOT trigger documentation drift.
|
|
// These are usually system/process vars or harness-only knobs.
|
|
const IGNORE_FROM_CODE = new Set([
|
|
"NODE_ENV",
|
|
"PATH",
|
|
"HOME",
|
|
"USER",
|
|
"LOGNAME",
|
|
"XDG_CURRENT_DESKTOP",
|
|
"PWD",
|
|
"SHELL",
|
|
"TERM",
|
|
"TZ",
|
|
"LANG",
|
|
"LC_ALL",
|
|
"LC_MESSAGES",
|
|
"CI",
|
|
"GITHUB_ACTIONS",
|
|
"RUNNER_OS",
|
|
// Agent environment / system execution paths.
|
|
"PROJECT_ROOT",
|
|
"ARTIFACTS_DIR",
|
|
// OS / Node internals frequently surfaced by indirect dependencies.
|
|
"APPDATA",
|
|
"LOCALAPPDATA",
|
|
"XDG_CONFIG_HOME",
|
|
"USERPROFILE",
|
|
"PREFIX",
|
|
// X11 display server — set by the OS/session manager, not OmniRoute config.
|
|
"DISPLAY",
|
|
// POSIX session vars surfaced by cloudflaredTunnel.ts (env passthrough).
|
|
"LOGNAME",
|
|
"XDG_CURRENT_DESKTOP",
|
|
// Next.js / Node test runners — these are framework-managed.
|
|
"NEXT_DIST_DIR",
|
|
"NEXT_PHASE",
|
|
"NEXT_RUNTIME",
|
|
"NODE_TEST_CONTEXT",
|
|
"VITEST",
|
|
// CI providers (set by the runner).
|
|
"GITHUB_BASE_REF",
|
|
"GITHUB_BASE_SHA",
|
|
// CLI machine-id token opt-out (server-side flag; not user-configurable via .env).
|
|
"OMNIROUTE_DISABLE_CLI_TOKEN",
|
|
// update-notifier opt-out for the CLI binary.
|
|
"OMNIROUTE_NO_UPDATE_NOTIFIER",
|
|
// Headless CLI execution flag for Electron.
|
|
"OMNIROUTE_HEADLESS",
|
|
// Platform / OS detection vars read by CLI environment helper (bin/cli/utils/environment.mjs).
|
|
// These are external signals set by the host OS or cloud provider — not OmniRoute config.
|
|
"CODESPACES",
|
|
"GITHUB_CODESPACES_PORT_FORWARDING_DOMAIN",
|
|
"GITPOD_WORKSPACE_ID",
|
|
"NO_COLOR",
|
|
"REPL_ID",
|
|
"REPL_SLUG",
|
|
"WSL_DISTRO_NAME",
|
|
"WSL_INTEROP",
|
|
// X11/Wayland display server vars used by tray heuristic (isTraySupported).
|
|
"DISPLAY",
|
|
"WAYLAND_DISPLAY",
|
|
// Build-time override for OpenAPI spec path used by generate-api-commands.mjs.
|
|
"OPENAPI_SPEC",
|
|
// Aliases for documented vars handled via fallback ordering.
|
|
"API_KEY",
|
|
"APP_URL",
|
|
"PUBLIC_URL",
|
|
"ANTHROPIC_API_URL",
|
|
"OPENAI_API_URL",
|
|
"LOG_LEVEL",
|
|
// Internal QA helpers used only by scripts/ and Playwright.
|
|
"QA_BASE_URL",
|
|
"QA_LOCALES",
|
|
"QA_REPORT_SUFFIX",
|
|
"QA_ROUTES",
|
|
// Doctor diagnostic flags (no runtime behavior yet — placeholders).
|
|
"OMNIROUTE_DOCTOR_HOST",
|
|
"OMNIROUTE_DOCTOR_LIVENESS_URL",
|
|
"OMNIROUTE_PROVIDER_CATALOG_PATH",
|
|
"OMNIROUTE_PROVIDER_TEST_MODEL",
|
|
// Test-only opt-out: instructs bin/omniroute.mjs to skip auto-loading the
|
|
// repository .env so isolation tests get a deterministic environment.
|
|
"OMNIROUTE_CLI_SKIP_REPO_ENV",
|
|
// Source typo / placeholder.
|
|
"OMNIROUT",
|
|
// Static config alias path (the canonical var is OMNIROUTE_PAYLOAD_RULES_PATH).
|
|
"PAYLOAD_RULES_PATH",
|
|
// Node.js module resolution path — OS/Node internal, not an OmniRoute config var.
|
|
// Referenced in resolveSpawnArgs (ninerouter) to pass bundled native modules to subprocess.
|
|
"NODE_PATH",
|
|
// NVIDIA diagnostic/test helpers used only by ad-hoc scripts.
|
|
"NVIDIA_BASE_URL",
|
|
"NVIDIA_MODEL",
|
|
]);
|
|
|
|
// Vars documented in ENVIRONMENT.md but intentionally absent from .env.example.
|
|
// Used for past-tense documentation (Audit / Dead vars section), legacy aliases
|
|
// with no runtime hook, and section anchors that look like vars to the regex.
|
|
const DOC_ONLY_ALLOWLIST = new Set([
|
|
// Audit history (Removed / Dead Variables section).
|
|
"CEREBRAS_API_KEY",
|
|
"COHERE_API_KEY",
|
|
"FIREWORKS_API_KEY",
|
|
"GROQ_API_KEY",
|
|
"MISTRAL_API_KEY",
|
|
"NEBIUS_API_KEY",
|
|
"PERPLEXITY_API_KEY",
|
|
"TOGETHER_API_KEY",
|
|
"XAI_API_KEY",
|
|
"QIANFAN_API_KEY",
|
|
"CURSOR_PROTOBUF_DEBUG",
|
|
"CLI_COMPAT_KIRO",
|
|
"CLI_KIMI_CODING_BIN",
|
|
"CLI_ROO_BIN",
|
|
"IFLOW_OAUTH_CLIENT_ID",
|
|
"IFLOW_OAUTH_CLIENT_SECRET",
|
|
// Source-code constants accidentally captured by the doc regex.
|
|
"CLI_COMPAT_OMITTED_PROVIDER_IDS",
|
|
// Sample default values that look like SHOUTY_NAMES (not env vars).
|
|
"CHANGEME",
|
|
// Legacy aliases — present in docs as "would be aliases" but read-only
|
|
// through their canonical names today.
|
|
"OMNIROUTE_CRYPT_KEY",
|
|
"OMNIROUTE_API_KEY_BASE64",
|
|
// Future-supported hooks: documented but currently hardcoded constants.
|
|
"MAX_RETRY_INTERVAL_SEC",
|
|
"REQUEST_RETRY",
|
|
"SKILLS_EXECUTION_TIMEOUT_MS",
|
|
"SKILLS_SANDBOX_DOCKER_IMAGE",
|
|
]);
|
|
|
|
// Vars present in .env.example but intentionally absent from ENVIRONMENT.md.
|
|
// Empty today — kept for forward compatibility / explicit exemption.
|
|
const ENV_ONLY_ALLOWLIST = new Set([]);
|
|
|
|
// ─── Parsing helpers ───────────────────────────────────────────────────────
|
|
|
|
/**
|
|
* Extract VAR= entries from a `.env`-style file (handles commented examples).
|
|
*/
|
|
export function parseEnvExampleVars(text) {
|
|
const vars = new Set();
|
|
for (const line of String(text ?? "").split("\n")) {
|
|
const m = line.match(/^#?\s*([A-Z][A-Z0-9_]+)\s*=/);
|
|
if (m) vars.add(m[1]);
|
|
}
|
|
return vars;
|
|
}
|
|
|
|
/**
|
|
* Extract `VARNAME` tokens from a markdown doc — matches anything in backticks
|
|
* that looks like an env var (uppercase + digit + underscore).
|
|
*/
|
|
export function parseEnvDocVars(text) {
|
|
const vars = new Set();
|
|
for (const m of String(text ?? "").matchAll(/`([A-Z][A-Z0-9_]{2,})`/g)) {
|
|
vars.add(m[1]);
|
|
}
|
|
return vars;
|
|
}
|
|
|
|
/**
|
|
* Collect environment variable references in source code via grep against
|
|
* the `process.env` member access pattern.
|
|
*/
|
|
function scanCodeVars({ cwd } = {}) {
|
|
const repoRoot = cwd ?? REPO_ROOT;
|
|
const stdout = execSync(
|
|
"grep -rhoE 'process\\.env\\.[A-Z][A-Z0-9_]+' " +
|
|
"src/ open-sse/ bin/ scripts/ electron/main.js electron/preload.js 2>/dev/null || true",
|
|
{ cwd: repoRoot, encoding: "utf8", maxBuffer: 20 * 1024 * 1024 }
|
|
);
|
|
const vars = new Set();
|
|
for (const line of stdout.split("\n")) {
|
|
const m = line.match(/^process\.env\.([A-Z][A-Z0-9_]+)$/);
|
|
if (m) vars.add(m[1]);
|
|
}
|
|
return vars;
|
|
}
|
|
|
|
/**
|
|
* Diff helper.
|
|
*/
|
|
function diff(set, against) {
|
|
return [...set].filter((v) => !against.has(v)).sort((a, b) => a.localeCompare(b));
|
|
}
|
|
|
|
// ─── Programmatic entry point ──────────────────────────────────────────────
|
|
|
|
/**
|
|
* Run the contract checker. All inputs are overridable for tests.
|
|
*
|
|
* Returns `{ ok: boolean, summary, problems: { codeMissingEnv, envMissingDoc,
|
|
* docMissingEnv } }`.
|
|
*/
|
|
export function runEnvDocSync(options = {}) {
|
|
const ignore = options.ignore ?? IGNORE_FROM_CODE;
|
|
const docOnly = options.docOnlyAllowlist ?? DOC_ONLY_ALLOWLIST;
|
|
const envOnly = options.envOnlyAllowlist ?? ENV_ONLY_ALLOWLIST;
|
|
|
|
const envExampleText =
|
|
options.envExampleText ??
|
|
(options.envExamplePath
|
|
? fs.readFileSync(options.envExamplePath, "utf8")
|
|
: fs.readFileSync(path.join(REPO_ROOT, ".env.example"), "utf8"));
|
|
const envDocText =
|
|
options.envDocText ??
|
|
(options.envDocPath
|
|
? fs.readFileSync(options.envDocPath, "utf8")
|
|
: fs.readFileSync(path.join(REPO_ROOT, "docs", "reference", "ENVIRONMENT.md"), "utf8"));
|
|
|
|
const envVars = parseEnvExampleVars(envExampleText);
|
|
const docVars = parseEnvDocVars(envDocText);
|
|
|
|
const codeVars = new Set(
|
|
[...(options.codeVars ?? scanCodeVars({ cwd: options.root }))].filter((v) => !ignore.has(v))
|
|
);
|
|
|
|
const codeMissingEnv = diff(codeVars, envVars);
|
|
const envMissingDoc = diff(envVars, docVars).filter((v) => !envOnly.has(v));
|
|
const docMissingEnv = diff(docVars, envVars).filter((v) => !docOnly.has(v));
|
|
|
|
const ok =
|
|
codeMissingEnv.length === 0 && envMissingDoc.length === 0 && docMissingEnv.length === 0;
|
|
|
|
return {
|
|
ok,
|
|
summary: {
|
|
code: codeVars.size,
|
|
envExample: envVars.size,
|
|
doc: docVars.size,
|
|
},
|
|
problems: {
|
|
codeMissingEnv,
|
|
envMissingDoc,
|
|
docMissingEnv,
|
|
},
|
|
};
|
|
}
|
|
|
|
// ─── CLI ───────────────────────────────────────────────────────────────────
|
|
|
|
function printList(label, list, marker) {
|
|
if (list.length === 0) {
|
|
console.log(` ${marker || "✓"} ${label}: none`);
|
|
return;
|
|
}
|
|
console.log(` ✗ ${label}: ${list.length}`);
|
|
for (const v of list.slice(0, 50)) console.log(` - ${v}`);
|
|
if (list.length > 50) console.log(` ... and ${list.length - 50} more`);
|
|
}
|
|
|
|
function main() {
|
|
const lenient = process.argv.includes("--lenient");
|
|
const result = runEnvDocSync();
|
|
|
|
console.log("Env var contract sync report");
|
|
console.log("============================");
|
|
console.log(`Code references: ${result.summary.code} unique vars`);
|
|
console.log(`In .env.example: ${result.summary.envExample} unique vars`);
|
|
console.log(`In docs/reference/ENVIRONMENT.md: ${result.summary.doc} unique vars`);
|
|
console.log();
|
|
|
|
printList("In code but missing from .env.example", result.problems.codeMissingEnv);
|
|
printList("In .env.example but missing from ENVIRONMENT.md", result.problems.envMissingDoc);
|
|
printList("In ENVIRONMENT.md but missing from .env.example", result.problems.docMissingEnv);
|
|
|
|
if (result.ok) {
|
|
console.log("\n✓ Env / docs contract is in sync.");
|
|
process.exit(0);
|
|
}
|
|
|
|
if (lenient) {
|
|
console.log("\n⚠ Drift detected (lenient mode — exit 0).");
|
|
process.exit(0);
|
|
}
|
|
|
|
console.log(
|
|
"\n✗ Env / docs contract is out of sync. Update .env.example, docs/reference/ENVIRONMENT.md,"
|
|
);
|
|
console.log(" or the allowlists in scripts/check/check-env-doc-sync.mjs and try again.");
|
|
process.exit(1);
|
|
}
|
|
|
|
if (import.meta.url === `file://${process.argv[1]}`) {
|
|
main();
|
|
}
|