Files
OmniRoute/tests/unit/model-capability-overrides.test.ts
Xiangzhe 9fc3b29217 fix(catalog): scope combo reasoning efforts by connection (#10723)
Merged — locally validated (72/72 focused tests, typecheck:core clean, all static gates green) after resolving base-drift conflicts (catalog.ts cooperative-yield insertion point, modelMetadataRegistry.ts snapshot-param signature). CI's red checks (Unit Tests fast-path shards, Fast Quality Gates, Docs Gates) are confirmed PRE-EXISTING base-red on the pure release tip — reproduced tests/unit/db-driver-bundling-externals.test.ts, tests/unit/model-catalog-runtime-invalidation.test.ts and others failing identically against origin/release/v3.8.50 with zero PR content, unrelated to this change. Thanks for the design and for absorbing #10724's value here — great work on both review rounds!
2026-08-20 09:31:12 -03:00

307 lines
11 KiB
TypeScript
Raw Blame History

This file contains invisible Unicode characters
This file contains invisible Unicode characters that are indistinguishable to humans but may be processed differently by a computer. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
import { describe, it, beforeEach, after } from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const moduleDataDir = fs.mkdtempSync(path.join(os.tmpdir(), "omni-model-capability-overrides-"));
process.env.DATA_DIR = moduleDataDir;
const coreDb = await import("../../src/lib/db/core.ts");
const caps = await import("../../src/lib/modelCapabilities.ts");
const overrides = await import("../../src/lib/db/modelCapabilityOverrides.ts");
const contextOverrides = await import("../../src/lib/db/modelContextOverrides.ts");
const route = await import("../../src/app/api/model-capability-overrides/route.ts");
beforeEach(() => {
coreDb.resetDbInstance();
fs.rmSync(moduleDataDir, { recursive: true, force: true });
fs.mkdirSync(moduleDataDir, { recursive: true });
coreDb.getDbInstance();
});
after(() => {
coreDb.resetDbInstance();
fs.rmSync(moduleDataDir, { recursive: true, force: true });
});
function patchOverride(key: string, value: unknown) {
return route.PATCH(
new Request("http://localhost/api/model-capability-overrides", {
method: "PATCH",
headers: { "content-type": "application/json" },
body: JSON.stringify({ target: "codex/gpt-5.6", key, value }),
})
);
}
describe("model capability overrides", () => {
it("stores, lists, removes, and applies an exact max_output_tokens override", () => {
const withoutOverride = caps.getResolvedModelCapabilities({
provider: "openai",
model: "gpt-4o",
}).maxOutputTokens;
const distinct = (withoutOverride ?? 0) + 12345;
assert.equal(
overrides.setModelCapabilityOverride("openai/gpt-4o", "max_output_tokens", distinct),
true
);
assert.deepEqual(
overrides.listModelCapabilityOverrides().map((entry) => ({
target: entry.target,
key: entry.key,
value: entry.value,
})),
[{ target: "openai/gpt-4o", key: "max_output_tokens", value: distinct }]
);
assert.equal(
caps.getResolvedModelCapabilities({ provider: "openai", model: "gpt-4o" }).maxOutputTokens,
distinct
);
assert.notEqual(
caps.getResolvedModelCapabilities({ provider: "anthropic", model: "gpt-4o" }).maxOutputTokens,
distinct
);
assert.equal(
overrides.removeModelCapabilityOverride("openai/gpt-4o", "max_output_tokens"),
true
);
assert.equal(
caps.getResolvedModelCapabilities({ provider: "openai", model: "gpt-4o" }).maxOutputTokens,
withoutOverride
);
});
it("uses exact input/output overrides, clamps input to context, and isolates effort variants", () => {
const target = "codex/gpt-5.6";
const variant = "codex/gpt-5.6-high";
assert.equal(contextOverrides.setModelContextOverride("codex", "gpt-5.6", 372000), true);
assert.equal(overrides.setModelCapabilityOverride(target, "max_input_tokens", 999999), true);
assert.equal(overrides.setModelCapabilityOverride(target, "max_output_tokens", 123456), true);
const base = caps.getResolvedModelCapabilities(target);
assert.deepEqual(
{
contextWindow: base.contextWindow,
maxInputTokens: base.maxInputTokens,
maxOutputTokens: base.maxOutputTokens,
},
{ contextWindow: 372000, maxInputTokens: 372000, maxOutputTokens: 123456 }
);
assert.equal(overrides.removeModelCapabilityOverride(target, "max_output_tokens"), true);
assert.notEqual(caps.getResolvedModelCapabilities(target).maxOutputTokens, 123456);
const effort = caps.getResolvedModelCapabilities(variant);
assert.notEqual(effort.contextWindow, 372000);
assert.notEqual(effort.maxInputTokens, 372000);
assert.notEqual(effort.maxOutputTokens, 123456);
});
it("applies overrides stored under provider-scoped model aliases", () => {
assert.equal(
overrides.setModelCapabilityOverride("github/claude-opus-4.5", "max_output_tokens", 77777),
true
);
assert.equal(
caps.getResolvedModelCapabilities({ provider: "github", model: "claude-opus-4.5" })
.maxOutputTokens,
77777
);
});
it("accepts exactly the three public token-limit keys through the API", async () => {
assert.equal(
contextOverrides.setModelContextOverride("codex", "gpt-5.6", 272000, "auto:discovery"),
true
);
const discoveredResponse = await route.GET(
new Request("http://localhost/api/model-capability-overrides")
);
const discoveredPayload = (await discoveredResponse.json()) as {
overrides: Array<{ target: string; key: string; value: number }>;
};
assert.ok(
discoveredPayload.overrides.some(
(override) =>
override.target === "codex/gpt-5.6" &&
override.key === "context_length" &&
override.value === 272000
),
"the unified surface exposes an auto-discovered context window before manual replacement"
);
assert.equal((await patchOverride("context_length", 372000)).status, 200);
assert.equal((await patchOverride("max_input_tokens", 353400)).status, 200);
assert.equal((await patchOverride("max_output_tokens", 128000)).status, 200);
assert.equal((await patchOverride("max_token", 77777)).status, 400, "legacy key");
assert.equal((await patchOverride("unknown", 1)).status, 400, "unsupported key");
assert.equal((await patchOverride("max_input_tokens", 0)).status, 400, "non-positive integer");
assert.equal(
(await patchOverride("max_input_tokens", Number.POSITIVE_INFINITY)).status,
400,
"JSON serializes Infinity as null; route rejects the resulting non-number"
);
const response = await route.GET(
new Request("http://localhost/api/model-capability-overrides")
);
const payload = (await response.json()) as {
overrides: Array<{ target: string; key: string; value: number }>;
};
assert.deepEqual(
payload.overrides
.map(({ target, key, value }) => ({ target, key, value }))
.sort((left, right) => left.key.localeCompare(right.key)),
[
{ target: "codex/gpt-5.6", key: "context_length", value: 372000 },
{ target: "codex/gpt-5.6", key: "max_input_tokens", value: 353400 },
{ target: "codex/gpt-5.6", key: "max_output_tokens", value: 128000 },
]
);
assert.equal(
contextOverrides.getModelContextOverrideRecord("codex", "gpt-5.6")?.source,
"manual"
);
const resolved = caps.getResolvedModelCapabilities("codex/gpt-5.6");
assert.deepEqual(
{
contextWindow: resolved.contextWindow,
maxInputTokens: resolved.maxInputTokens,
maxOutputTokens: resolved.maxOutputTokens,
},
{ contextWindow: 372000, maxInputTokens: 353400, maxOutputTokens: 128000 }
);
const removed = await route.DELETE(
new Request(
"http://localhost/api/model-capability-overrides?target=codex/gpt-5.6&key=context_length",
{ method: "DELETE" }
)
);
assert.equal(removed.status, 200);
assert.equal(contextOverrides.getModelContextOverride("codex", "gpt-5.6"), null);
const rejectedDelete = await route.DELETE(
new Request(
"http://localhost/api/model-capability-overrides?target=codex/gpt-5.6&key=max_token",
{ method: "DELETE" }
)
);
assert.equal(rejectedDelete.status, 400);
});
it("stores exact reasoning_efforts through the API and preserves native max/ultra", async () => {
const before = caps.getResolvedModelCapabilities("codex/gpt-5.6");
const accepted = await patchOverride(
"reasoning_efforts",
" low\r\n, medium, max, ultra"
);
assert.equal(accepted.status, 200);
const payload = (await accepted.json()) as {
overrides: Array<{ target: string; key: string; value: number | string[] }>;
};
const listed = payload.overrides.find((override) => override.key === "reasoning_efforts");
assert.ok(listed);
assert.equal(listed.target, "codex/gpt-5.6");
assert.deepEqual(listed.value, ["low", "medium", "max", "ultra"]);
assert.deepEqual(overrides.getReasoningEffortsOverride("codex", "gpt-5.6"), [
"low",
"medium",
"max",
"ultra",
]);
const resolved = caps.getResolvedModelCapabilities("codex/gpt-5.6");
assert.equal(resolved.supportsThinking, true);
assert.equal(resolved.reasoningEffortsOverride, true);
assert.deepEqual(resolved.supportedThinkingEfforts, ["low", "medium", "max", "ultra"]);
for (const invalid of [
"",
"low,",
"low,,high",
"low, LOW",
"minimal,low",
"low,unknown",
"lowhigh",
]) {
assert.equal((await patchOverride("reasoning_efforts", invalid)).status, 400, invalid);
}
assert.equal((await patchOverride("reasoning_efforts", ["low", "high"])).status, 400);
assert.equal((await patchOverride("reasoning_efforts", 123)).status, 400);
const removed = await route.DELETE(
new Request(
"http://localhost/api/model-capability-overrides?target=codex/gpt-5.6&key=reasoning_efforts",
{ method: "DELETE" }
)
);
assert.equal(removed.status, 200);
assert.equal(overrides.getReasoningEffortsOverride("codex", "gpt-5.6"), null);
const after = caps.getResolvedModelCapabilities("codex/gpt-5.6");
assert.equal(after.reasoningEffortsOverride, false);
assert.deepEqual(after.supportedThinkingEfforts, before.supportedThinkingEfforts);
});
it("rejects invalid targets and non-positive values", () => {
assert.equal(overrides.setModelCapabilityOverride("gpt-4o", "max_output_tokens", 1000), false);
assert.equal(
overrides.setModelCapabilityOverride("openai/gpt-4o", "max_output_tokens", 0),
false
);
assert.equal(
overrides.setModelCapabilityOverride("openai/gpt-4o", "max_output_tokens", 1.5),
false
);
assert.deepEqual(overrides.listModelCapabilityOverrides(), []);
});
it("migrates legacy max_token rows without replacing a modern output override", () => {
const db = coreDb.getDbInstance();
const insert = db.prepare(
"INSERT INTO model_capability_overrides " +
"(provider, model_id, override_key, override_value, refreshed_at) VALUES (?, ?, ?, ?, ?)"
);
insert.run("legacy", "legacy-only", "max_token", "64000", "2026-01-01 00:00:00");
insert.run("legacy", "collision", "max_token", "64000", "2026-01-01 00:00:00");
insert.run("legacy", "collision", "max_output_tokens", "128000", "2026-02-01 00:00:00");
const migration = fs.readFileSync(
path.resolve("src/lib/db/migrations/135_migrate_model_capability_max_token.sql"),
"utf8"
);
db.exec(migration);
db.exec(migration);
assert.deepEqual(
db
.prepare(
"SELECT provider, model_id, override_key, override_value, refreshed_at " +
"FROM model_capability_overrides WHERE provider = 'legacy' " +
"ORDER BY model_id, override_key"
)
.all(),
[
{
provider: "legacy",
model_id: "collision",
override_key: "max_output_tokens",
override_value: "128000",
refreshed_at: "2026-02-01 00:00:00",
},
{
provider: "legacy",
model_id: "legacy-only",
override_key: "max_output_tokens",
override_value: "64000",
refreshed_at: "2026-01-01 00:00:00",
},
]
);
});
});