Files
OmniRoute/tests/unit/kiro-builder-id-import-3333.test.ts
Diego Rodrigues de Sa e Souza 7db430a352 Release v3.8.14 (#3340)
* chore(release): open v3.8.14 development cycle

Version bump 3.8.13 -> 3.8.14 (root + electron + open-sse + openapi + lockfiles).
Seed the v3.8.14 changelog with the four post-tag hotfixes that shipped to
Docker/Electron in v3.8.13 but missed the immutable npm 3.8.13 (#3336 SSRF /
CodeQL #323, #3334/#3335/#3339 Electron packaging). i18n CHANGELOG mirrors get
the in-progress placeholder section.

* feat: add per-provider custom headers support for OpenAI/Anthropic-compatible nodes (#3338)

Integrated into release/v3.8.14

* fix: Kiro Builder ID token import fails with Bad credentials (#3333)

Integrated into release/v3.8.14 — adds Builder ID cached-creds + OIDC refresh path for Kiro token import, with regression tests (#3333).

* Improve code quality: auto-pr/docstrings-1780792063 (#3337)

Integrated into release/v3.8.14 — docstring for context analytics route re-export.

* fix(catalog): remove minimaxai/minimax-m3 from NVIDIA NIM tier (404 upstream) (#3329) (#3341)

NVIDIA NIM does not host minimaxai/minimax-m3 — every request returns
404 page not found, while sibling minimaxai/minimax-m2.7 on the same provider
works. Advertising a model that 404s is a catalog bug; remove it from the nvidia
tier (it remains on the tiers that actually serve MiniMax M3). Re-add only once
NVIDIA serves it.

Co-authored-by: mikmaneggahommie <mikmaneggahommie@users.noreply.github.com>

* fix(cli): write OpenCode config to ~/.config on all platforms incl. Windows (#3330) (#3343)

resolveOpencodeConfigDir used %APPDATA% on Windows, but OpenCode reads its
config from XDG ~/.config/opencode/ on every platform (on Windows:
%USERPROFILE%\.config\opencode\, NOT %APPDATA%). So a Windows user who
configured OpenCode via the dashboard had the file written where OpenCode never
looks — it silently had no effect.

Use the XDG path (XDG_CONFIG_HOME || ~/.config) unconditionally. Update the UI
note + route JSDoc, and flip the three tests that encoded the old %APPDATA%
behavior (t40 per-platform + card-note, cli-runtime-extended getCliConfigPaths).

Co-authored-by: abdulkadirozyurt <abdulkadirozyurt@users.noreply.github.com>

* fix(proxy): make auto-selection fallback opt-in (#3332) (#3344)

selectWorkingProxyFallback (Step 11 of resolveProxyForConnection) listed ALL
registry proxies, ignoring assignments and per-connection proxy_enabled, and
returned the first working one with level:'autoSelect'. So a single proxy added
to the registry silently became a global fallback for every connection's traffic.

Gate it behind a new PROXY_AUTO_SELECT_ENABLED feature flag (default off): the
fallback now no-ops unless the operator opts in. No registry proxy becomes a
silent global default anymore.

Co-authored-by: hertznsk <hertznsk@users.noreply.github.com>

* fix(sse): treat MiniMax M3 as multimodal so vision isn't stripped (#3328) (#3342)

MiniMax M3 via the opencode provider (oc/minimax-m3-free) appeared blind:
image inputs didn't reach the model, while the same model in Cline could
see them. Verified empirically that MiniMax M3 on the opencode upstream IS
multimodal -- a base64 image is described correctly (it returns 403 only
for remote image URLs, which it doesn't accept).

Root cause: OmniRoute treated MiniMax M3 as a non-vision model in two
places, so when compression was active the image was replaced with a text
placeholder before dispatch:
- compression's modelSupportsVision() heuristic (lite.ts) only matched
  gpt-4/4o/claude-3/gemini/vision -- minimax was absent -> replaceImageUrls
  stripped the image.
- the opencode minimax-m3-free catalog entry lacked supportsVision, so the
  combo vision-capability gate could also exclude/mishandle it.

Add 'minimax-m3' to the vision heuristic and supportsVision: true to the
opencode minimax-m3-free entry. TDD: a failing-then-passing test in
compression/lite.test.ts proves replaceImageUrls now keeps images for
minimax-m3 ids, plus a registry assertion mirroring the #2822 qwen test.

Reported-by: @mikmaneggahommie

* docs(i18n): translate 25 core documentation files to Indonesian (#3348)

Integrated into release/v3.8.14 — Indonesian i18n docs.

* fix(review): resolve /review-reviews battery findings (LEDGER-1..11) on v3.8.14 (#3350)

Integrated into release/v3.8.14 — /review-reviews battery hardening (LEDGER-1..11) for #3338 custom-headers + #3333 kiro, plus cycle-test drift fixes (#3329/#3330/#3332).

* fix(provider-proxy): honor per-account proxy toggles (#3349)

Integrated into release/v3.8.14 — honor per-account proxy toggles + auto-fallback opt-in via PROXY_AUTO_SELECT_ENABLED.

* fix(dashboard): remove duplicate Distribute Proxies button on provider page (#3352)

* fix(providers): reduce proxy label noise (#3346)

Integrated into release/v3.8.14 — reduce proxy label noise + a11y (aria-label/sr-only).

* fix(duckduckgo): restore bare Response contract and rebase onto release/v3.8.14 (#3323)

Integrated into release/v3.8.14 — browser-backed cookie providers (duckduckgo/claude-web) with restored executor contract + unit tests.

* fix(noauth): expose only usable model aliases (#3345)

Integrated into release/v3.8.14 — noauth usable-alias filtering + registry alias plumbing (veo-free).

* fix(dashboard): stop infinite config-load loop on Hermes Agent detail page (#3353)

* fix(electron): tree-kill the server on exit/update to release the omniroute.exe lock (#3347) (#3354)

* chore(release): finalize v3.8.14 changelog + clear release-gate drift

- CHANGELOG: finalize the v3.8.14 section (date, full New Features/Bug Fixes/
  Maintenance coverage of all 16 cycle commits, Contributors hall of 12).
- docs: document OMNIROUTE_BROWSER_POOL + WEB_COOKIE_USE_BROWSER (#3323) in
  .env.example + ENVIRONMENT.md; regenerate the id/llm.txt strict mirror (#3348
  had translated it; llm.txt mirrors must match root).
- test(proxy-fetch): #3323 made tlsClient.available a computed getter — stub it
  via Object.defineProperty instead of assignment (5 tests were red on the base).

* fix(translator): coerce Gemini functionDeclaration parameters to an OBJECT schema (#3357) (#3360)

* fix(gemini): resolve truncation/suppression of false positive textual tool call markers in backticks (#3358)

Integrated into release/v3.8.14 — Gemini/Antigravity textual tool-call marker normalization (no false-positive suppression + split-chunk buffering).

* docs(changelog): add #3358 Gemini textual tool-call normalization to v3.8.14

* fix(dashboard): surface real analytics error instead of generic placeholder (#3356) (#3361)

The Analytics page discarded the server's error body on a non-OK response and
rendered a generic "An error occurred", so users (and maintainers) could not see
why /api/usage/analytics 500'd after an upgrade. Now the route returns the real
reason via buildErrorBody (sanitized, Hard Rule #12) and the page surfaces it via
a new readFetchErrorMessage helper that handles both the OpenAI-style and legacy
error shapes.

Reported-by: @superti4r

---------

Co-authored-by: PizzaV <103120356+pizzav-xyz@users.noreply.github.com>
Co-authored-by: Someres <168349709+quanturbo@users.noreply.github.com>
Co-authored-by: Dong Mengzhe <154944819+Lang-Qiu@users.noreply.github.com>
Co-authored-by: mikmaneggahommie <mikmaneggahommie@users.noreply.github.com>
Co-authored-by: abdulkadirozyurt <abdulkadirozyurt@users.noreply.github.com>
Co-authored-by: hertznsk <hertznsk@users.noreply.github.com>
Co-authored-by: Krisna Santosa <54174372+KrisnaSantosa15@users.noreply.github.com>
Co-authored-by: Randi <55005611+rdself@users.noreply.github.com>
Co-authored-by: Wilson <pedbookmed@gmail.com>
Co-authored-by: Paijo <14921983+oyi77@users.noreply.github.com>
Co-authored-by: Ardem2025 <ardemb22@gmail.com>
2026-06-07 07:20:02 -03:00

193 lines
7.2 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
// Regression guard for #3333 — Kiro Builder ID token import failed with "Bad
// credentials" because validateImportToken only ever tried the social-auth
// refresh path. Builder ID tokens need the cached AWS SSO clientId/clientSecret
// (~/.aws/sso/cache/*.json) and the OIDC refresh path (authMethod: "builder-id").
const { KiroService } = await import("../../src/lib/oauth/services/kiro.ts");
const ORIGINAL_HOME = process.env.HOME;
const ORIGINAL_FETCH = globalThis.fetch;
let tmpHome: string;
function makeFakeSsoCache(home: string, creds: { clientId: string; clientSecret: string } | null) {
const cacheDir = path.join(home, ".aws", "sso", "cache");
fs.mkdirSync(cacheDir, { recursive: true });
if (creds) {
// The OIDC client-registration cache entry also carries unrelated keys.
fs.writeFileSync(
path.join(cacheDir, "client-reg.json"),
JSON.stringify({ ...creds, region: "us-east-1", expiresAt: "2099-01-01T00:00:00Z" })
);
}
}
test.beforeEach(() => {
tmpHome = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-kiro-3333-"));
process.env.HOME = tmpHome;
});
test.afterEach(() => {
process.env.HOME = ORIGINAL_HOME;
globalThis.fetch = ORIGINAL_FETCH;
if (tmpHome) fs.rmSync(tmpHome, { recursive: true, force: true });
});
test("validateImportToken uses cached Builder ID client creds + OIDC refresh path", async () => {
makeFakeSsoCache(tmpHome, { clientId: "cid-cached", clientSecret: "secret-cached" });
const calledEndpoints: string[] = [];
globalThis.fetch = (async (url: string | URL | Request) => {
const u = String(url);
calledEndpoints.push(u);
// Builder ID refresh hits the AWS OIDC token endpoint.
if (u.includes("oidc.") && u.endsWith("/token")) {
return new Response(
JSON.stringify({
accessToken: "access-builder-id",
refreshToken: "refreshed-token",
expiresIn: 3600,
}),
{ status: 200, headers: { "Content-Type": "application/json" } }
);
}
throw new Error(`unexpected fetch to ${u}`);
}) as typeof fetch;
const svc = new KiroService();
const result = await svc.validateImportToken("aorAAAAAGtoken-builder-id");
assert.equal(result.authMethod, "builder-id");
assert.equal(result.accessToken, "access-builder-id");
assert.equal(result.clientId, "cid-cached");
assert.equal(result.clientSecret, "secret-cached");
// Must have gone through the OIDC token endpoint, NOT the social-auth service.
assert.ok(
calledEndpoints.some((u) => u.includes("oidc.") && u.endsWith("/token")),
"expected OIDC token endpoint to be used for Builder ID refresh"
);
});
test("validateImportToken falls back to social auth when no cached creds exist", async () => {
// No ~/.aws/sso/cache → readCachedClientCredentials() returns null.
makeFakeSsoCache(tmpHome, null);
globalThis.fetch = (async (url: string | URL | Request) => {
const u = String(url);
// Social-auth refresh endpoint.
if (u.includes("auth.desktop.kiro.dev")) {
return new Response(
JSON.stringify({
accessToken: "access-social",
refreshToken: "social-rt",
expiresIn: 3600,
}),
{ status: 200, headers: { "Content-Type": "application/json" } }
);
}
// registerClient() for the isolated OIDC client (may fail gracefully).
if (u.includes("oidc.") && u.endsWith("/client/register")) {
return new Response(JSON.stringify({ clientId: "reg-cid", clientSecret: "reg-secret" }), {
status: 200,
headers: { "Content-Type": "application/json" },
});
}
throw new Error(`unexpected fetch to ${u}`);
}) as typeof fetch;
const svc = new KiroService();
const result = await svc.validateImportToken("aorAAAAAGtoken-social");
assert.equal(result.authMethod, "imported");
assert.equal(result.accessToken, "access-social");
});
// LEDGER-6 (/review-reviews v3.8.14): the Builder ID validation refresh must
// forward the requested region to the OIDC endpoint, not default to us-east-1.
test("validateImportToken forwards the region to the OIDC endpoint (LEDGER-6)", async () => {
makeFakeSsoCache(tmpHome, { clientId: "cid", clientSecret: "secret" });
const calledEndpoints: string[] = [];
globalThis.fetch = (async (url: string | URL | Request) => {
const u = String(url);
calledEndpoints.push(u);
if (u.includes("oidc.") && u.endsWith("/token")) {
return new Response(
JSON.stringify({ accessToken: "a", refreshToken: "r", expiresIn: 3600 }),
{ status: 200, headers: { "Content-Type": "application/json" } }
);
}
throw new Error(`unexpected fetch to ${u}`);
}) as typeof fetch;
const svc = new KiroService();
await svc.validateImportToken("aorAAAAAGtoken", "eu-west-1");
assert.ok(
calledEndpoints.some((u) => u.includes("oidc.eu-west-1.amazonaws.com/token")),
`expected the eu-west-1 OIDC endpoint, got: ${calledEndpoints.join(", ")}`
);
assert.ok(
!calledEndpoints.some((u) => u.includes("oidc.us-east-1.amazonaws.com/token")),
"must not fall back to us-east-1 when a region was requested"
);
});
// LEDGER-8 (/review-reviews v3.8.14): with multiple cached SSO client
// registrations, the one whose region matches the import must be chosen rather
// than whichever readdir returns first.
test("validateImportToken prefers the region-matching cached client (LEDGER-8)", async () => {
const cacheDir = path.join(tmpHome, ".aws", "sso", "cache");
fs.mkdirSync(cacheDir, { recursive: true });
// "a-" sorts first so naive first-match would pick the wrong (us-east-1) pair.
fs.writeFileSync(
path.join(cacheDir, "a-useast.json"),
JSON.stringify({
clientId: "cid-useast",
clientSecret: "secret-useast",
region: "us-east-1",
expiresAt: "2099-01-01T00:00:00Z",
})
);
fs.writeFileSync(
path.join(cacheDir, "z-euwest.json"),
JSON.stringify({
clientId: "cid-euwest",
clientSecret: "secret-euwest",
region: "eu-west-1",
expiresAt: "2099-01-01T00:00:00Z",
})
);
globalThis.fetch = (async (url: string | URL | Request) => {
const u = String(url);
if (u.includes("oidc.") && u.endsWith("/token")) {
return new Response(
JSON.stringify({ accessToken: "a", refreshToken: "r", expiresIn: 3600 }),
{ status: 200, headers: { "Content-Type": "application/json" } }
);
}
throw new Error(`unexpected fetch to ${u}`);
}) as typeof fetch;
const svc = new KiroService();
const result = await svc.validateImportToken("aorAAAAAGtoken", "eu-west-1");
assert.equal(result.clientId, "cid-euwest", "must pick the eu-west-1 registration");
assert.equal(result.clientSecret, "secret-euwest");
});
test("validateImportToken rejects malformed refresh tokens before touching the cache", async () => {
let fetched = false;
globalThis.fetch = (async () => {
fetched = true;
return new Response("{}", { status: 200 });
}) as typeof fetch;
const svc = new KiroService();
await assert.rejects(() => svc.validateImportToken("not-a-valid-token"), /Invalid token format/);
assert.equal(fetched, false, "must not attempt any network call for a malformed token");
});