mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-08-19 05:32:19 +03:00
* chore(release): continue v3.8.25 development cycle after main code-sync (r5) main fast-forwarded to release/v3.8.25 (#3863): unblocked Build+Docker via #3864, plus #3837 (mimocode proxy) and #3862 (trivy bump). This marker re-opens the umbrella PR for further v3.8.25 work. No version bump. * fix(db): persist the Keep-latest-backups retention setting (#3834) (#3867) * fix(oauth): clear GitLab Duo setup message instead of 500 (#3861) (#3868) * test(oauth): prove refresh_token preserved on real gemini-cli/antigravity dispatch (#3850) (#3869) * feat(compression-ui): unified compression config UI — per-engine pages + combos editor + menu + WS default-on (#3860) Integrated into release/v3.8.25 — feat(compression-ui): unified compression configuration UI (Compression Hub + per-engine Lite/Aggressive/Ultra pages + combos editor + sidebar entry + live-WS default-on). File-size re-baselined for sidebarVisibility.ts/chatCore.ts growth; orphan ws test relocated to a collected path. * docs(changelog): complete the v3.8.25 release notes + credit all contributors Audited every commit since v3.8.24 and filled the gaps the [3.8.25] section was missing: a New Features section (compression engines + Compression Studios #3848, compression UI #3860, injection-guard #3857, kiro discovery #3836, Veo #3839, mimocode proxy #3837, Arena ELO flag #3821), 9 more Fixed entries (#3811/#3807/#3759/#3849/#3838/#3835/#3814/#3820/#3819), a Security section (CCR IDOR #3859, supply-chain #3824), and an Internal/Quality section. Every contributor and issue reporter is now credited. * docs(changelog): restore + complete the v3.8.25 release notes Re-adds CHANGELOG.md (a prior server-side commit accidentally dropped it) with the complete, audited [3.8.25] section: New Features, the full Fixed list, Security & Hardening, and Internal/Quality — every contributor and issue reporter credited. * chore(release): finalize v3.8.25 — reconcile CHANGELOG + i18n mirrors, document OMNIROUTE_MAX_PENDING_MIGRATIONS, green the unit suite Release-gate reconciliation for v3.8.25: - CHANGELOG: dated 2026-06-14, linked #3826, rolled up file-size re-baselines (#3823/#3833), recorded the test-greening; re-synced all 41 i18n CHANGELOG mirrors. - Documented OMNIROUTE_MAX_PENDING_MIGRATIONS (#3416) in .env.example + ENVIRONMENT.md. - Greened the unit suite (was merged red on 4 CI shards): aligned 10 stale tests to this cycle's intended behavior (#3838/#3822/#3501/SOCKS5/Vertex-Express/Antigravity) and the same-provider 503 fall-through test; de-flaked the compression benchmark reproducibility and ServiceSupervisor crash tests. No production code changed. * ci(security): clear OpenSSF Scorecard code-scanning noise + harden workflow token permissions The Security tab held 155 open alerts, ALL from the advisory OpenSSF Scorecard tool (#3824) — supply-chain/posture scores, not code vulnerabilities — which drowned out real CodeQL findings. - scorecard.yml: stop uploading SARIF to the code-scanning tab (drop the upload-sarif step + the now-unused security-events: write). The run still produces the OpenSSF badge (publish_results) and a downloadable SARIF artifact. - TokenPermissions hardening (the high-severity, genuinely-valuable subset): set each workflow's top-level token to read-only and grant the exact writes at the job level that needs them — npm-publish (id-token/packages on publish jobs), docker-publish (packages on build), electron-release (contents on build/release, id-token/packages on publish-npm), build-fork (packages on build), claude (empty top-level; job grants its own). The 155 existing alerts were dismissed. Not adopting repo-wide SHA-pinning (143 PinnedDependencies advisories) — declined. * test(integration): align stale wiring/socks5 integration tests to this cycle's behavior These were red on the CI Integration job (pre-existing). No production code changed: - integration-wiring: the combos page no longer renders a per-page EmailPrivacyToggle (#3822 consolidated it into Settings → Appearance); the provider-detail test-result masking and upstream-proxy copy moved to decomposed components (#3501 BatchTestResultsModal / UpstreamProxyCard) — assertions now read the owning files. - api-routes-critical: SOCKS5 is now enabled by default (opt-out), so the disabled- rejection test must set ENABLE_SOCKS5_PROXY=false explicitly (an unset env now means enabled). (The ~32 live-Gemini integration tests are gated on OMNIROUTE_API_KEY and skip in CI; they only 'fail' locally when that key is present without a running server.)
587 lines
20 KiB
TypeScript
587 lines
20 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import http from "node:http";
|
|
import net from "node:net";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
process.env.NODE_ENV = "test";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-token-healthcheck-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const providersDb = await import("../../src/lib/db/providers.ts");
|
|
const settingsDb = await import("../../src/lib/db/settings.ts");
|
|
const { PROVIDERS, OAUTH_ENDPOINTS } = await import("../../open-sse/config/constants.ts");
|
|
const tokenHealthCheck = await import("../../src/lib/tokenHealthCheck.ts");
|
|
|
|
async function resetStorage() {
|
|
core.resetDbInstance();
|
|
|
|
for (let attempt = 0; attempt < 10; attempt++) {
|
|
try {
|
|
if (fs.existsSync(TEST_DATA_DIR)) {
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true });
|
|
}
|
|
break;
|
|
} catch (error: any) {
|
|
if ((error?.code === "EBUSY" || error?.code === "EPERM") && attempt < 9) {
|
|
await new Promise((resolve) => setTimeout(resolve, 50 * (attempt + 1)));
|
|
} else {
|
|
throw error;
|
|
}
|
|
}
|
|
}
|
|
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
}
|
|
|
|
async function withHttpServer(handler, fn) {
|
|
const server = http.createServer(handler);
|
|
|
|
await new Promise((resolve, reject) => {
|
|
server.once("error", reject);
|
|
server.listen(0, "127.0.0.1", resolve);
|
|
});
|
|
|
|
const address = server.address();
|
|
assert.ok(address && typeof address === "object");
|
|
|
|
try {
|
|
return await fn({
|
|
host: "127.0.0.1",
|
|
port: address.port,
|
|
url: `http://127.0.0.1:${address.port}`,
|
|
});
|
|
} finally {
|
|
await new Promise((resolve, reject) => {
|
|
server.close((error) => {
|
|
if (error) reject(error);
|
|
else resolve();
|
|
});
|
|
});
|
|
}
|
|
}
|
|
|
|
async function withConnectProxyServer(fn) {
|
|
const server = http.createServer((_req, res) => {
|
|
res.writeHead(501);
|
|
res.end("CONNECT only");
|
|
});
|
|
|
|
server.on("connect", (req, clientSocket, head) => {
|
|
const [host, portText] = String(req.url || "").split(":");
|
|
const targetPort = Number(portText || 80);
|
|
const upstreamSocket = net.connect(targetPort, host, () => {
|
|
clientSocket.write("HTTP/1.1 200 Connection Established\r\n\r\n");
|
|
if (head && head.length > 0) {
|
|
upstreamSocket.write(head);
|
|
}
|
|
upstreamSocket.pipe(clientSocket);
|
|
clientSocket.pipe(upstreamSocket);
|
|
});
|
|
|
|
const closeSockets = () => {
|
|
upstreamSocket.destroy();
|
|
clientSocket.destroy();
|
|
};
|
|
|
|
upstreamSocket.on("error", closeSockets);
|
|
clientSocket.on("error", closeSockets);
|
|
});
|
|
|
|
await new Promise((resolve, reject) => {
|
|
server.once("error", reject);
|
|
server.listen(0, "127.0.0.1", resolve);
|
|
});
|
|
|
|
const address = server.address();
|
|
assert.ok(address && typeof address === "object");
|
|
|
|
try {
|
|
return await fn({
|
|
host: "127.0.0.1",
|
|
port: address.port,
|
|
url: `http://127.0.0.1:${address.port}`,
|
|
});
|
|
} finally {
|
|
await new Promise((resolve, reject) => {
|
|
server.close((error) => {
|
|
if (error) reject(error);
|
|
else resolve();
|
|
});
|
|
});
|
|
}
|
|
}
|
|
|
|
async function withPatchedProvider(providerId, config, fn) {
|
|
const hadOwnConfig = Object.prototype.hasOwnProperty.call(PROVIDERS, providerId);
|
|
const previousConfig = hadOwnConfig ? PROVIDERS[providerId] : undefined;
|
|
PROVIDERS[providerId] = config;
|
|
|
|
try {
|
|
return await fn();
|
|
} finally {
|
|
if (hadOwnConfig) {
|
|
PROVIDERS[providerId] = previousConfig;
|
|
} else {
|
|
delete PROVIDERS[providerId];
|
|
}
|
|
}
|
|
}
|
|
|
|
test.after(async () => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true });
|
|
});
|
|
|
|
test("extractResolvedProxyConfig unwraps proxy resolution metadata", () => {
|
|
const proxy = {
|
|
type: "http",
|
|
host: "proxy.example.test",
|
|
port: 8080,
|
|
};
|
|
|
|
assert.deepEqual(
|
|
tokenHealthCheck.extractResolvedProxyConfig({
|
|
proxy,
|
|
level: "account",
|
|
levelId: "conn-123",
|
|
source: "registry",
|
|
}),
|
|
proxy
|
|
);
|
|
assert.deepEqual(tokenHealthCheck.extractResolvedProxyConfig(proxy), proxy);
|
|
assert.equal(
|
|
tokenHealthCheck.extractResolvedProxyConfig({
|
|
proxy: null,
|
|
level: "direct",
|
|
}),
|
|
null
|
|
);
|
|
assert.equal(tokenHealthCheck.extractResolvedProxyConfig(null), null);
|
|
});
|
|
|
|
test("buildRefreshFailureUpdate keeps active connections routable after refresh failure", () => {
|
|
const now = "2026-04-09T04:40:00.000Z";
|
|
|
|
const update = tokenHealthCheck.buildRefreshFailureUpdate(
|
|
{
|
|
testStatus: "active",
|
|
expiredRetryCount: 2,
|
|
},
|
|
now
|
|
);
|
|
|
|
assert.equal(update.testStatus, "active");
|
|
assert.equal(update.lastError, "Health check: token refresh failed");
|
|
assert.equal(update.lastErrorType, "token_refresh_failed");
|
|
assert.equal(update.lastErrorSource, "oauth");
|
|
assert.equal(update.errorCode, "refresh_failed");
|
|
assert.equal(update.lastHealthCheckAt, now);
|
|
assert.equal("expiredRetryCount" in update, false);
|
|
assert.equal("expiredRetryAt" in update, false);
|
|
});
|
|
|
|
test("buildRefreshFailureUpdate preserves expired retry tracking", () => {
|
|
const now = "2026-04-09T04:41:00.000Z";
|
|
|
|
const update = tokenHealthCheck.buildRefreshFailureUpdate(
|
|
{
|
|
testStatus: "expired",
|
|
expiredRetryCount: 2,
|
|
},
|
|
now
|
|
);
|
|
|
|
assert.equal(update.testStatus, "expired");
|
|
assert.equal(update.expiredRetryCount, 3);
|
|
assert.equal(update.expiredRetryAt, now);
|
|
});
|
|
|
|
test("checkConnection uses the resolved proxy payload when refreshing tokens", async () => {
|
|
await resetStorage();
|
|
|
|
const providerId = "custom-oauth-healthcheck";
|
|
const refreshRequests = [];
|
|
|
|
await withHttpServer(
|
|
(req, res) => {
|
|
let body = "";
|
|
req.setEncoding("utf8");
|
|
req.on("data", (chunk) => {
|
|
body += chunk;
|
|
});
|
|
req.on("end", () => {
|
|
refreshRequests.push({
|
|
method: req.method,
|
|
url: req.url,
|
|
headers: req.headers,
|
|
body,
|
|
});
|
|
res.writeHead(200, { "Content-Type": "application/json" });
|
|
res.end(
|
|
JSON.stringify({
|
|
access_token: "new-access-token",
|
|
refresh_token: "new-refresh-token",
|
|
expires_in: 3600,
|
|
})
|
|
);
|
|
});
|
|
},
|
|
async (tokenServer) => {
|
|
await withConnectProxyServer(async (proxy) => {
|
|
await withPatchedProvider(
|
|
providerId,
|
|
{
|
|
tokenUrl: `${tokenServer.url}/token`,
|
|
clientId: "healthcheck-client-id",
|
|
clientSecret: "healthcheck-client-secret",
|
|
},
|
|
async () => {
|
|
const connection = await providersDb.createProviderConnection({
|
|
provider: providerId,
|
|
authType: "oauth",
|
|
name: "Healthcheck Proxy Account",
|
|
email: "healthcheck@example.com",
|
|
accessToken: "stale-access-token",
|
|
refreshToken: "refresh-token-123",
|
|
isActive: true,
|
|
});
|
|
|
|
await settingsDb.setProxyForLevel("key", (connection as any).id, {
|
|
type: "http",
|
|
host: proxy.host,
|
|
port: proxy.port,
|
|
});
|
|
|
|
await tokenHealthCheck.checkConnection(connection);
|
|
|
|
const updated = await providersDb.getProviderConnectionById((connection as any).id);
|
|
|
|
assert.equal(refreshRequests.length, 1);
|
|
assert.equal(refreshRequests[0].method, "POST");
|
|
assert.equal(refreshRequests[0].url, "/token");
|
|
assert.match(refreshRequests[0].body, /grant_type=refresh_token/);
|
|
assert.match(refreshRequests[0].body, /refresh_token=refresh-token-123/);
|
|
assert.equal(updated?.accessToken, "new-access-token");
|
|
assert.equal(updated?.refreshToken, "new-refresh-token");
|
|
assert.equal(updated?.testStatus, "active");
|
|
assert.equal(updated?.lastError ?? null, null);
|
|
assert.ok(updated?.tokenExpiresAt);
|
|
assert.ok(updated?.expiresAt);
|
|
assert.equal(updated?.expiresAt, updated?.tokenExpiresAt);
|
|
}
|
|
);
|
|
});
|
|
}
|
|
);
|
|
});
|
|
|
|
test("checkConnection uses the latest stored refresh token instead of a stale sweep snapshot", async () => {
|
|
await resetStorage();
|
|
|
|
const providerId = "custom-oauth-stale-snapshot";
|
|
const refreshRequests: string[] = [];
|
|
|
|
await withHttpServer(
|
|
(req, res) => {
|
|
let body = "";
|
|
req.setEncoding("utf8");
|
|
req.on("data", (chunk) => {
|
|
body += chunk;
|
|
});
|
|
req.on("end", () => {
|
|
refreshRequests.push(body);
|
|
res.writeHead(200, { "Content-Type": "application/json" });
|
|
res.end(
|
|
JSON.stringify({
|
|
access_token: "snapshot-access-next",
|
|
refresh_token: "snapshot-refresh-next",
|
|
expires_in: 3600,
|
|
})
|
|
);
|
|
});
|
|
},
|
|
async (tokenServer) => {
|
|
await withPatchedProvider(
|
|
providerId,
|
|
{
|
|
tokenUrl: `${tokenServer.url}/token`,
|
|
clientId: "snapshot-client-id",
|
|
clientSecret: "snapshot-client-secret",
|
|
},
|
|
async () => {
|
|
const connection = await providersDb.createProviderConnection({
|
|
provider: providerId,
|
|
authType: "oauth",
|
|
name: "Snapshot Account",
|
|
email: "snapshot@example.com",
|
|
accessToken: "snapshot-access-old",
|
|
refreshToken: "snapshot-refresh-old",
|
|
isActive: true,
|
|
});
|
|
|
|
const staleCheckTime = new Date(Date.now() - 2 * 60 * 60 * 1000).toISOString();
|
|
await providersDb.updateProviderConnection((connection as any).id, {
|
|
refreshToken: "snapshot-refresh-current",
|
|
lastHealthCheckAt: staleCheckTime,
|
|
});
|
|
|
|
await tokenHealthCheck.checkConnection(connection);
|
|
|
|
const updated = await providersDb.getProviderConnectionById((connection as any).id);
|
|
assert.equal(refreshRequests.length, 1);
|
|
assert.match(refreshRequests[0], /refresh_token=snapshot-refresh-current/);
|
|
assert.equal(updated?.refreshToken, "snapshot-refresh-next");
|
|
assert.equal(updated?.accessToken, "snapshot-access-next");
|
|
}
|
|
);
|
|
}
|
|
);
|
|
});
|
|
|
|
test("checkConnection skips interval refresh when token expiry is known and still far away", async () => {
|
|
await resetStorage();
|
|
|
|
const providerId = "custom-oauth-known-expiry";
|
|
let refreshCount = 0;
|
|
|
|
await withHttpServer(
|
|
(_req, res) => {
|
|
refreshCount += 1;
|
|
res.writeHead(200, { "Content-Type": "application/json" });
|
|
res.end(
|
|
JSON.stringify({
|
|
access_token: "should-not-refresh",
|
|
refresh_token: "should-not-refresh",
|
|
expires_in: 3600,
|
|
})
|
|
);
|
|
},
|
|
async (tokenServer) => {
|
|
await withPatchedProvider(
|
|
providerId,
|
|
{
|
|
tokenUrl: `${tokenServer.url}/token`,
|
|
clientId: "known-expiry-client-id",
|
|
clientSecret: "known-expiry-client-secret",
|
|
},
|
|
async () => {
|
|
const connection = await providersDb.createProviderConnection({
|
|
provider: providerId,
|
|
authType: "oauth",
|
|
name: "Known Expiry Account",
|
|
email: "known-expiry@example.com",
|
|
accessToken: "known-expiry-access",
|
|
refreshToken: "known-expiry-refresh",
|
|
expiresAt: new Date(Date.now() + 24 * 60 * 60 * 1000).toISOString(),
|
|
isActive: true,
|
|
});
|
|
|
|
const staleCheckTime = new Date(Date.now() - 2 * 60 * 60 * 1000).toISOString();
|
|
await providersDb.updateProviderConnection((connection as any).id, {
|
|
lastHealthCheckAt: staleCheckTime,
|
|
});
|
|
|
|
await tokenHealthCheck.checkConnection(connection);
|
|
|
|
const updated = await providersDb.getProviderConnectionById((connection as any).id);
|
|
assert.equal(refreshCount, 0);
|
|
assert.equal(updated?.accessToken, "known-expiry-access");
|
|
assert.equal(updated?.refreshToken, "known-expiry-refresh");
|
|
assert.equal(updated?.lastHealthCheckAt, staleCheckTime);
|
|
}
|
|
);
|
|
}
|
|
);
|
|
});
|
|
|
|
test("checkConnection skips providers listed in OMNIROUTE_HEALTHCHECK_SKIP_PROVIDERS (#kimi-15)", async () => {
|
|
await resetStorage();
|
|
|
|
const providerId = "custom-oauth-skip-list";
|
|
const refreshRequests: string[] = [];
|
|
const prevSkip = process.env.OMNIROUTE_HEALTHCHECK_SKIP_PROVIDERS;
|
|
|
|
await withHttpServer(
|
|
(req, res) => {
|
|
let body = "";
|
|
req.setEncoding("utf8");
|
|
req.on("data", (chunk) => {
|
|
body += chunk;
|
|
});
|
|
req.on("end", () => {
|
|
refreshRequests.push(body);
|
|
res.writeHead(200, { "Content-Type": "application/json" });
|
|
res.end(
|
|
JSON.stringify({
|
|
access_token: "should-not-be-fetched",
|
|
refresh_token: "should-not-be-fetched",
|
|
expires_in: 3600,
|
|
})
|
|
);
|
|
});
|
|
},
|
|
async (tokenServer) => {
|
|
await withPatchedProvider(
|
|
providerId,
|
|
{
|
|
tokenUrl: `${tokenServer.url}/token`,
|
|
clientId: "skip-client-id",
|
|
clientSecret: "skip-client-secret",
|
|
},
|
|
async () => {
|
|
const connection = await providersDb.createProviderConnection({
|
|
provider: providerId,
|
|
authType: "oauth",
|
|
name: "Skip-list Account",
|
|
email: "skip@example.com",
|
|
accessToken: "stale-access-token",
|
|
refreshToken: "refresh-token-skip",
|
|
isActive: true,
|
|
});
|
|
|
|
// The connection is due for refresh (no known expiry, never checked).
|
|
// With the provider listed, the proactive sweep must skip it entirely —
|
|
// NO refresh request is made.
|
|
process.env.OMNIROUTE_HEALTHCHECK_SKIP_PROVIDERS = `foo, ${providerId} ,bar`;
|
|
await tokenHealthCheck.checkConnection(connection);
|
|
assert.equal(
|
|
refreshRequests.length,
|
|
0,
|
|
"listed provider must NOT trigger a proactive refresh"
|
|
);
|
|
|
|
// Control: with the provider no longer listed, the same due connection
|
|
// IS refreshed — proving the skip (not token freshness) gated it.
|
|
process.env.OMNIROUTE_HEALTHCHECK_SKIP_PROVIDERS = "some-other-provider";
|
|
const stillStale = await providersDb.getProviderConnectionById((connection as any).id);
|
|
await tokenHealthCheck.checkConnection(stillStale);
|
|
assert.equal(refreshRequests.length, 1, "non-listed provider must refresh");
|
|
}
|
|
);
|
|
}
|
|
);
|
|
|
|
if (prevSkip === undefined) delete process.env.OMNIROUTE_HEALTHCHECK_SKIP_PROVIDERS;
|
|
else process.env.OMNIROUTE_HEALTHCHECK_SKIP_PROVIDERS = prevSkip;
|
|
});
|
|
|
|
// Regression for #3679: a non-rotating (Google-family) provider whose proactive
|
|
// refresh fails with invalid_grant used to have its refresh_token NULLED, leaving
|
|
// the connection unrecoverable ("No valid refresh token available"). The null was
|
|
// only meant for rotating one-time-use tokens (Codex/OpenAI). Non-rotating providers
|
|
// must keep the stored refresh_token as the recovery artifact.
|
|
test("checkConnection preserves refresh_token for non-rotating providers on unrecoverable error (#3679)", async () => {
|
|
await resetStorage();
|
|
|
|
const providerId = "custom-nonrotating-3679"; // NOT in ROTATING_REFRESH_PROVIDERS
|
|
let refreshCount = 0;
|
|
|
|
await withHttpServer(
|
|
(_req, res) => {
|
|
refreshCount += 1;
|
|
// Google returns invalid_grant → isUnrecoverableRefreshError() is true.
|
|
res.writeHead(400, { "Content-Type": "application/json" });
|
|
res.end(JSON.stringify({ error: "invalid_grant", error_description: "Bad Request" }));
|
|
},
|
|
async (tokenServer) => {
|
|
await withPatchedProvider(
|
|
providerId,
|
|
{
|
|
tokenUrl: `${tokenServer.url}/token`,
|
|
clientId: "nonrotating-client-id",
|
|
clientSecret: "nonrotating-client-secret",
|
|
},
|
|
async () => {
|
|
const connection = await providersDb.createProviderConnection({
|
|
provider: providerId,
|
|
authType: "oauth",
|
|
name: "Non-rotating Account",
|
|
email: "nonrotating@example.com",
|
|
accessToken: "expired-access-token",
|
|
refreshToken: "rt-preserve-3679",
|
|
// Already expired → proactive refresh runs AND the still-valid guard fails,
|
|
// so execution reaches the deactivation branch that used to null the token.
|
|
expiresAt: new Date(Date.now() - 60 * 60 * 1000).toISOString(),
|
|
isActive: true,
|
|
});
|
|
|
|
await tokenHealthCheck.checkConnection(connection);
|
|
|
|
const updated = await providersDb.getProviderConnectionById((connection as any).id);
|
|
assert.equal(refreshCount, 1, "the expired token must trigger a refresh attempt");
|
|
assert.equal(updated?.testStatus, "expired", "should reach the unrecoverable branch");
|
|
// The fix: the refresh_token is PRESERVED (was nulled before the fix).
|
|
assert.equal(
|
|
updated?.refreshToken,
|
|
"rt-preserve-3679",
|
|
"non-rotating provider must keep its refresh_token for recovery"
|
|
);
|
|
}
|
|
);
|
|
}
|
|
);
|
|
});
|
|
|
|
// Regression for #3850 (continuation of #3679): the #3679 test above uses a SYNTHETIC
|
|
// provider that routes through the generic refreshAccessToken/tokenUrl path. The real
|
|
// Google-family providers (gemini-cli / antigravity) instead dispatch through
|
|
// refreshGoogleToken() against the HARDCODED OAUTH_ENDPOINTS.google.token — a path the
|
|
// synthetic test never exercised, which left #3766's correctness unproven for the
|
|
// actual reported providers. This drives checkConnection through the REAL gemini-cli /
|
|
// antigravity dispatch and asserts the refresh_token is preserved (NOT nulled) when
|
|
// Google rejects the refresh with invalid_grant.
|
|
for (const providerId of ["gemini-cli", "antigravity"]) {
|
|
test(`checkConnection preserves refresh_token for ${providerId} on invalid_grant (#3850)`, async () => {
|
|
await resetStorage();
|
|
|
|
let refreshCount = 0;
|
|
const originalGoogleTokenUrl = OAUTH_ENDPOINTS.google.token;
|
|
|
|
await withHttpServer(
|
|
(_req, res) => {
|
|
refreshCount += 1;
|
|
// Google returns invalid_grant → isUnrecoverableRefreshError() is true.
|
|
res.writeHead(400, { "Content-Type": "application/json" });
|
|
res.end(JSON.stringify({ error: "invalid_grant", error_description: "Bad Request" }));
|
|
},
|
|
async (tokenServer) => {
|
|
// gemini-cli / antigravity refresh hits OAUTH_ENDPOINTS.google.token directly
|
|
// (not a per-provider tokenUrl), so redirect that hardcoded endpoint.
|
|
OAUTH_ENDPOINTS.google.token = `${tokenServer.url}/token`;
|
|
try {
|
|
const connection = await providersDb.createProviderConnection({
|
|
provider: providerId,
|
|
authType: "oauth",
|
|
name: `${providerId} Account`,
|
|
email: `${providerId}@example.com`,
|
|
accessToken: "expired-access-token",
|
|
refreshToken: "rt-keep-3850",
|
|
// Already expired → proactive refresh runs AND the still-valid guard fails,
|
|
// so execution reaches the deactivation branch.
|
|
expiresAt: new Date(Date.now() - 60 * 60 * 1000).toISOString(),
|
|
isActive: true,
|
|
});
|
|
|
|
await tokenHealthCheck.checkConnection(connection);
|
|
|
|
const updated = await providersDb.getProviderConnectionById((connection as any).id);
|
|
assert.equal(refreshCount, 1, "the expired token must trigger one refresh attempt");
|
|
assert.equal(updated?.testStatus, "expired", "should reach the unrecoverable branch");
|
|
assert.equal(
|
|
updated?.refreshToken,
|
|
"rt-keep-3850",
|
|
`${providerId} (non-rotating) must keep its refresh_token for recovery`
|
|
);
|
|
} finally {
|
|
OAUTH_ENDPOINTS.google.token = originalGoogleTokenUrl;
|
|
}
|
|
}
|
|
);
|
|
});
|
|
}
|