Files
OmniRoute/tests/unit/aihorde-optional-api-key.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

141 lines
5.4 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-aihorde-key-"));
process.env.DATA_DIR = TEST_DATA_DIR;
process.env.API_KEY_SECRET = process.env.API_KEY_SECRET || "aihorde-optional-key-test-secret";
const core = await import("../../src/lib/db/core.ts");
const providersDb = await import("../../src/lib/db/providers.ts");
const { getProviderCredentials } = await import("../../src/sse/services/auth.ts");
const { supportsApiKeyOnFreeProvider, providerAllowsOptionalApiKey } =
await import("../../src/shared/constants/providers.ts");
const { getCredentialRequirement } =
await import("../../src/shared/utils/providerCredentialRequirement.ts");
const { DefaultExecutor } = await import("../../open-sse/executors/default.ts");
const { isManagedProviderConnectionId } = await import("../../src/lib/providers/catalog.ts");
test.after(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("aihorde treats a registered key as optional, not required", () => {
assert.equal(providerAllowsOptionalApiKey("aihorde"), true);
assert.equal(supportsApiKeyOnFreeProvider("aihorde"), true);
assert.equal(getCredentialRequirement("aihorde"), "optional");
assert.equal(isManagedProviderConnectionId("aihorde"), true);
});
test("aihorde without a stored key still uses the synthetic no-auth path", async () => {
const creds = await getProviderCredentials("aihorde");
assert.ok(creds);
assert.equal((creds as { connectionId?: string }).connectionId, "noauth");
assert.equal((creds as { apiKey?: unknown }).apiKey, null);
});
let registeredKeyConnectionId: string | undefined;
test("aihorde prefers a stored API key over the anonymous fallback", async () => {
const created = await providersDb.createProviderConnection({
provider: "aihorde",
authType: "apikey",
name: "Horde kudos key",
apiKey: "horde-registered-key-123",
});
assert.ok(created?.id);
registeredKeyConnectionId = created.id;
const creds = await getProviderCredentials("aihorde");
assert.ok(creds);
assert.equal((creds as { apiKey?: string }).apiKey, "horde-registered-key-123");
assert.equal((creds as { connectionId?: string }).connectionId, created.id);
});
test("aihorde falls back to anonymous when the only stored key is rate-limited", async () => {
// Deactivate the healthy connection from the prior test so it cannot mask
// the fallback behavior being exercised here.
assert.ok(registeredKeyConnectionId);
await providersDb.updateProviderConnection(registeredKeyConnectionId, { isActive: false });
const created = await providersDb.createProviderConnection({
provider: "aihorde",
authType: "apikey",
name: "Horde cooling-down key",
apiKey: "horde-cooling-down-key",
});
assert.ok(created?.id);
await providersDb.updateProviderConnection(created.id, {
rateLimitedUntil: new Date(Date.now() + 60_000).toISOString(),
testStatus: "unavailable",
});
const creds = await getProviderCredentials("aihorde");
assert.ok(creds);
assert.equal((creds as { connectionId?: string }).connectionId, "noauth");
assert.equal((creds as { apiKey?: unknown }).apiKey, null);
});
test("aihorde falls back to anonymous when the only stored key is terminally banned", async () => {
const created = await providersDb.createProviderConnection({
provider: "aihorde",
authType: "apikey",
name: "Horde banned key",
apiKey: "horde-banned-key",
});
assert.ok(created?.id);
await providersDb.updateProviderConnection(created.id, { testStatus: "banned" });
const creds = await getProviderCredentials("aihorde");
assert.ok(creds);
assert.equal((creds as { connectionId?: string }).connectionId, "noauth");
assert.equal((creds as { apiKey?: unknown }).apiKey, null);
});
test("aihorde rotates past an unhealthy stored key to the next healthy one", async () => {
const unhealthy = await providersDb.createProviderConnection({
provider: "aihorde",
authType: "apikey",
name: "Horde unhealthy key",
apiKey: "horde-unhealthy-key",
priority: 1,
});
assert.ok(unhealthy?.id);
await providersDb.updateProviderConnection(unhealthy.id, {
rateLimitedUntil: new Date(Date.now() + 60_000).toISOString(),
testStatus: "unavailable",
});
const healthy = await providersDb.createProviderConnection({
provider: "aihorde",
authType: "apikey",
name: "Horde healthy key",
apiKey: "horde-healthy-key",
priority: 2,
});
assert.ok(healthy?.id);
const creds = await getProviderCredentials("aihorde");
assert.ok(creds);
assert.equal((creds as { apiKey?: string }).apiKey, "horde-healthy-key");
assert.equal((creds as { connectionId?: string }).connectionId, healthy.id);
});
test("DefaultExecutor uses a stored Horde key for chat, else the anonymous key", () => {
const executor = new DefaultExecutor("aihorde");
const withKey = executor.buildHeaders(
{ apiKey: "horde-registered-key-123", accessToken: null } as never,
true
) as Record<string, string>;
assert.equal(withKey.Authorization, "Bearer horde-registered-key-123");
const anonymous = executor.buildHeaders(
{ apiKey: null, accessToken: null } as never,
true
) as Record<string, string>;
assert.equal(anonymous.Authorization, "Bearer 0000000000");
});