Files
OmniRoute/tests/unit/combo-scope-proxy-dead-7149.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

88 lines
3.0 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-combo-proxy-7149-"));
process.env.DATA_DIR = TEST_DATA_DIR;
process.env.API_KEY_SECRET = "test-secret";
const core = await import("../../src/lib/db/core.ts");
const proxiesDb = await import("../../src/lib/db/proxies.ts");
const providersDb = await import("../../src/lib/db/providers.ts");
const combosDb = await import("../../src/lib/db/combos.ts");
const settingsDb = await import("../../src/lib/db/settings.ts");
type ProxyResolutionLike = {
proxy?: { host?: string } | null;
level?: string;
levelId?: string | null;
} | null;
async function resetStorage() {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
test.after(async () => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("#7149: a proxy assigned to a Combo via the dashboard (registry scope='combo') is honored when resolving the proxy for a request routed through that combo", async () => {
await resetStorage();
const comboProxy = await proxiesDb.createProxy({
name: "Combo-Assigned Proxy",
type: "http",
host: "10.20.30.40",
port: 8888,
});
assert.ok(comboProxy?.id);
const combo = await combosDb.createCombo({
name: "diy_deepseek-v4-flash",
strategy: "round-robin",
models: ["openai/gpt-4"],
});
const comboRecord = combo as Record<string, unknown>;
assert.ok(comboRecord?.id);
const comboId = comboRecord.id as string;
const assignment = await proxiesDb.assignProxyToScope("combo", comboId, comboProxy!.id);
assert.ok(assignment, "assignProxyToScope('combo', ...) should persist the assignment");
const directRegistryLookup = (await proxiesDb.resolveProxyForScopeFromRegistry(
"combo",
comboId
)) as ProxyResolutionLike;
assert.ok(
directRegistryLookup?.proxy,
"the registry must be able to answer a direct combo-scope lookup"
);
assert.equal(directRegistryLookup?.proxy?.host, "10.20.30.40");
const connection = await providersDb.createProviderConnection({
provider: "openai",
authType: "apikey",
apiKey: "sk-test-1234",
name: "openai-account-1",
});
const connectionRecord = connection as Record<string, unknown> | null;
const connectionId = connectionRecord?.id as string;
assert.ok(connectionId, "test setup requires a real connection id");
const resolved = (await settingsDb.resolveProxyForConnection(
connectionId
)) as ProxyResolutionLike;
assert.equal(
resolved?.level,
"combo",
`expected the combo-assigned proxy to be resolved (level="combo"), got level="${resolved?.level}" — the registry-based combo proxy assignment is never consulted by resolveProxyForConnection()`
);
assert.equal(resolved?.proxy?.host, "10.20.30.40");
});