Files
OmniRoute/tests/unit/db-core-migration.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

131 lines
3.5 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import path from "node:path";
import os from "node:os";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-db-core-migration-"));
process.env.DATA_DIR = TEST_DATA_DIR;
const JSON_DB_FILE = path.join(TEST_DATA_DIR, "db.json");
const core = await import("../../src/lib/db/core.ts");
test.after(async () => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("Test 1: migrateFromJson handles empty db.json and renames it", () => {
// Setup empty db.json
fs.writeFileSync(JSON_DB_FILE, JSON.stringify({}));
// Initialize db, should trigger migration
const db = core.getDbInstance();
assert.equal(fs.existsSync(JSON_DB_FILE), false);
assert.equal(fs.existsSync(JSON_DB_FILE + ".empty"), true);
core.resetDbInstance();
});
test("Test 2: migrateFromJson migrates data to SQLite successfully", () => {
// Re-setup db.json with data
const data = {
providerConnections: [
{
id: "test-conn",
provider: "openai",
authType: "oauth",
isActive: false,
priority: 10,
createdAt: new Date().toISOString(),
},
],
providerNodes: [
{
id: "test-node",
type: "custom",
name: "My Node",
createdAt: new Date().toISOString(),
},
],
modelAliases: {
alias1: "openai/gpt-4",
},
settings: {
globalFallbackModel: "openai/gpt-4o",
},
pricing: {
openai: { "gpt-4": { inputCost: 1 } },
},
customModels: {
openai: ["gpt-4-custom"],
},
proxyConfig: {
global: { enabled: true },
},
combos: [
{
id: "test-combo",
name: "my-combo",
models: ["openai/gpt-4"],
},
],
apiKeys: [
{
id: "test-key",
name: "Key 1",
key: "sk-omniroute-test",
noLog: true,
},
],
};
fs.writeFileSync(JSON_DB_FILE, JSON.stringify(data));
// create dummy db_backups dir
const backupDir = path.join(TEST_DATA_DIR, "db_backups");
fs.mkdirSync(backupDir, { recursive: true });
fs.writeFileSync(path.join(backupDir, "db-legacy.json"), JSON.stringify({}));
const db = core.getDbInstance();
assert.equal(fs.existsSync(JSON_DB_FILE), false);
assert.equal(fs.existsSync(JSON_DB_FILE + ".migrated"), true);
const pc = db.prepare("SELECT * FROM provider_connections WHERE id = 'test-conn'").get();
assert.ok(pc);
assert.equal((pc as any).provider, "openai");
(assert as any).equal((pc as any).is_active, 0);
const key = db.prepare("SELECT * FROM api_keys WHERE id = 'test-key'").get();
assert.ok(key);
(assert as any).equal((key as any).name, "Key 1");
const kv = db
.prepare("SELECT * FROM key_value WHERE namespace = 'settings' AND key = 'globalFallbackModel'")
.get();
assert.ok(kv);
(assert as any).equal(JSON.parse((kv as any).value), "openai/gpt-4o");
core.resetDbInstance();
});
test("Test 3: migrateFromJson throws error securely when JSON is corrupted", () => {
fs.writeFileSync(JSON_DB_FILE, "{invalid-json");
const originalError = console.error;
let errorLogged = false;
console.error = () => {
errorLogged = true;
};
try {
core.getDbInstance(); // should trigger migration and fail securely without crashing
assert.ok(errorLogged);
} finally {
console.error = originalError;
core.resetDbInstance();
}
});