Files
OmniRoute/tests/unit/db-read-cache.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

286 lines
9.5 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import { pathToFileURL } from "node:url";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-db-read-cache-"));
process.env.DATA_DIR = TEST_DATA_DIR;
const core = await import("../../src/lib/db/core.ts");
const settingsDb = await import("../../src/lib/db/settings.ts");
const providersDb = await import("../../src/lib/db/providers.ts");
async function importFresh(modulePath) {
const url = pathToFileURL(path.resolve(modulePath)).href;
return import(`${url}?test=${Date.now()}-${Math.random().toString(16).slice(2)}`);
}
async function resetStorage() {
core.resetDbInstance();
for (let attempt = 0; attempt < 10; attempt++) {
try {
if (fs.existsSync(TEST_DATA_DIR)) {
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
}
break;
} catch (error: any) {
if ((error?.code === "EBUSY" || error?.code === "EPERM") && attempt < 9) {
await new Promise((resolve) => setTimeout(resolve, 50 * (attempt + 1)));
} else {
throw error;
}
}
}
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
test.beforeEach(async () => {
await resetStorage();
});
test.after(async () => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("getCachedSettings returns cached data until TTL expires or cache is invalidated", async () => {
const readCache = await importFresh("src/lib/db/readCache.ts");
const db = core.getDbInstance();
await settingsDb.updateSettings({ label: "initial" });
assert.equal((await readCache.getCachedSettings()).label, "initial");
db.prepare("INSERT OR REPLACE INTO key_value (namespace, key, value) VALUES (?, ?, ?)").run(
"settings",
"label",
JSON.stringify("stale-write")
);
assert.equal((await readCache.getCachedSettings()).label, "initial");
const originalNow = Date.now;
try {
Date.now = () => originalNow() + 6_000;
assert.equal((await readCache.getCachedSettings()).label, "stale-write");
} finally {
Date.now = originalNow;
}
db.prepare("INSERT OR REPLACE INTO key_value (namespace, key, value) VALUES (?, ?, ?)").run(
"settings",
"label",
JSON.stringify("after-invalidate")
);
readCache.invalidateDbCache("settings");
assert.equal((await readCache.getCachedSettings()).label, "after-invalidate");
});
test("getCachedPricing caches results and refreshes after invalidation", async () => {
const readCache = await importFresh("src/lib/db/readCache.ts");
const db = core.getDbInstance();
db.prepare("INSERT INTO key_value (namespace, key, value) VALUES (?, ?, ?)").run(
"pricing",
"cache-provider",
JSON.stringify({
"model-a": { prompt: 1 },
})
);
assert.equal((await readCache.getCachedPricing())["cache-provider"]["model-a"].prompt, 1);
db.prepare("UPDATE key_value SET value = ? WHERE namespace = ? AND key = ?").run(
JSON.stringify({
"model-a": { prompt: 9 },
}),
"pricing",
"cache-provider"
);
assert.equal((await readCache.getCachedPricing())["cache-provider"]["model-a"].prompt, 1);
readCache.invalidateDbCache("pricing");
assert.equal((await readCache.getCachedPricing())["cache-provider"]["model-a"].prompt, 9);
});
test("getCachedProviderConnections caches only the unfiltered query", async () => {
const readCache = await import("../../src/lib/db/readCache.ts");
const db = core.getDbInstance();
const now = new Date().toISOString();
await providersDb.createProviderConnection({
provider: "openai",
authType: "apikey",
name: "Primary",
apiKey: "sk-primary",
});
const firstRead = await readCache.getCachedProviderConnections();
db.prepare(
`
INSERT INTO provider_connections (
id, provider, auth_type, name, is_active, created_at, updated_at
) VALUES (?, ?, ?, ?, ?, ?, ?)
`
).run("direct-insert", "openai", "apikey", "Secondary", 1, now, now);
const cachedAll = await readCache.getCachedProviderConnections();
const filtered = await readCache.getCachedProviderConnections({ provider: "openai" });
assert.equal(firstRead.length, 1);
assert.equal(cachedAll.length, 1);
assert.equal(filtered.length, 2);
readCache.invalidateDbCache("connections");
assert.equal((await readCache.getCachedProviderConnections()).length, 2);
});
test("resetDbInstance invalidates provider connection read caches", async () => {
await providersDb.createProviderConnection({
provider: "openai",
authType: "apikey",
name: "Reset Cache Test",
apiKey: "sk-reset-cache",
});
assert.equal((await providersDb.getProviderConnections()).length, 1);
await resetStorage();
assert.equal((await providersDb.getProviderConnections()).length, 0);
});
test("cached LKGP values refresh only after the specific key is invalidated", async () => {
const readCache = await importFresh("src/lib/db/readCache.ts");
const db = core.getDbInstance();
const comboName = `combo-${Date.now()}`;
const modelId = `model-${Date.now()}`;
const lkgpKey = `${comboName}:${modelId}`;
await settingsDb.setLKGP(comboName, modelId, "openai");
assert.deepEqual(await readCache.getCachedLKGP(comboName, modelId), { provider: "openai" });
db.prepare("UPDATE key_value SET value = ? WHERE namespace = 'lkgp' AND key = ?").run(
JSON.stringify("anthropic"),
lkgpKey
);
assert.deepEqual(await readCache.getCachedLKGP(comboName, modelId), { provider: "openai" });
await readCache.setCachedLKGP(comboName, modelId, "gemini");
assert.deepEqual(await readCache.getCachedLKGP(comboName, modelId), { provider: "gemini" });
});
test("staleness regression: getProviderConnections returns fresh data after connection deleted", async () => {
const readCache = await importFresh("src/lib/db/readCache.ts");
const conn = await providersDb.createProviderConnection({
provider: "openai",
authType: "apikey",
name: "Staleness Test",
apiKey: "sk-stale-test",
});
const before = await providersDb.getProviderConnections();
assert.ok(before.length > 0);
assert.ok(before.some((c) => c.name === "Staleness Test"));
await providersDb.deleteProviderConnection(conn.id);
const after = await providersDb.getProviderConnections();
assert.equal(after.filter((c) => c.name === "Staleness Test").length, 0);
});
test("staleness regression: getProviderConnections returns fresh data after deleteProviderConnectionsByProvider", async () => {
const readCache = await importFresh("src/lib/db/readCache.ts");
await providersDb.createProviderConnection({
provider: "test-stale-batch",
authType: "apikey",
name: "Batch Stale Conn",
apiKey: "sk-batch-stale",
});
const before = await providersDb.getProviderConnections();
assert.ok(before.some((c) => c.provider === "test-stale-batch"));
await providersDb.deleteProviderConnectionsByProvider("test-stale-batch");
const after = await providersDb.getProviderConnections();
assert.equal(after.filter((c) => c.provider === "test-stale-batch").length, 0);
});
test("getCachedProviderConnectionById caches result and invalidates on connections write", async () => {
const readCache = await importFresh("src/lib/db/readCache.ts");
const db = core.getDbInstance();
await providersDb.createProviderConnection({
provider: "anthropic",
authType: "apikey",
name: "Cached Conn",
apiKey: "sk-cached-conn",
});
const allConns = await providersDb.getProviderConnections();
const id = allConns[allConns.length - 1].id;
const firstRead = await readCache.getCachedProviderConnectionById(id);
assert.ok(firstRead);
assert.equal(firstRead.name, "Cached Conn");
db.prepare("UPDATE provider_connections SET name = ? WHERE id = ?").run("Stale", id);
const cachedRead = await readCache.getCachedProviderConnectionById(id);
assert.equal(cachedRead.name, "Cached Conn");
readCache.invalidateDbCache("connections");
const freshRead = await readCache.getCachedProviderConnectionById(id);
assert.ok(freshRead);
assert.equal(freshRead.name, "Stale");
});
test("getCachedProviderNodes caches results and invalidates on nodes write", async () => {
const readCache = await importFresh("src/lib/db/readCache.ts");
const nodesDb = await importFresh("src/lib/db/providers/nodes.ts");
const db = core.getDbInstance();
const now = new Date().toISOString();
await nodesDb.createProviderNode({
id: "node-cache-test",
type: "openai",
name: "Cached Node",
baseUrl: "https://cached.example.com",
createdAt: now,
updatedAt: now,
});
const firstRead = await readCache.getCachedProviderNodes();
const matching = firstRead.filter((n) => n.id === "node-cache-test");
assert.equal(matching.length, 1);
assert.equal(matching[0].name, "Cached Node");
db.prepare(
"INSERT INTO provider_nodes (id, type, name, base_url, created_at, updated_at) VALUES (?, ?, ?, ?, ?, ?)"
).run("node-direct-test", "openai", "Direct Insert Node", "https://direct.example.com", now, now);
const cachedNodes = await readCache.getCachedProviderNodes();
const matchingCached = cachedNodes.filter((n) => n.id === "node-direct-test");
assert.equal(matchingCached.length, 0);
readCache.invalidateDbCache("nodes");
const freshNodes = await readCache.getCachedProviderNodes();
const matchingFresh = freshNodes.filter((n) => n.id === "node-direct-test");
assert.equal(matchingFresh.length, 1);
assert.equal(matchingFresh[0].name, "Direct Insert Node");
});