mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
67 lines
2.8 KiB
TypeScript
67 lines
2.8 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
import {
|
|
getInternalServiceAuthHeaders,
|
|
INTERNAL_SERVICE_AUTH_HEADER,
|
|
isInternalServiceRequest,
|
|
isTrustedLoopbackInternalServiceRequest,
|
|
} from "../../src/lib/api/internalServiceAuth.ts";
|
|
import { AUTHZ_HEADER_PEER_LOCALITY } from "../../src/server/authz/headers.ts";
|
|
|
|
const originalInline = process.env.OMNIROUTE_INTERNAL_SERVICE_TOKEN;
|
|
const originalFile = process.env.OMNIROUTE_INTERNAL_SERVICE_TOKEN_FILE;
|
|
|
|
test.afterEach(() => {
|
|
if (originalInline === undefined) delete process.env.OMNIROUTE_INTERNAL_SERVICE_TOKEN;
|
|
else process.env.OMNIROUTE_INTERNAL_SERVICE_TOKEN = originalInline;
|
|
if (originalFile === undefined) delete process.env.OMNIROUTE_INTERNAL_SERVICE_TOKEN_FILE;
|
|
else process.env.OMNIROUTE_INTERNAL_SERVICE_TOKEN_FILE = originalFile;
|
|
});
|
|
|
|
test("internal service auth is disabled when no token is configured", () => {
|
|
delete process.env.OMNIROUTE_INTERNAL_SERVICE_TOKEN;
|
|
delete process.env.OMNIROUTE_INTERNAL_SERVICE_TOKEN_FILE;
|
|
assert.deepEqual(getInternalServiceAuthHeaders(), {});
|
|
assert.equal(isInternalServiceRequest(new Request("http://localhost")), false);
|
|
});
|
|
|
|
test("internal service auth preserves a separate constant-time token channel", () => {
|
|
process.env.OMNIROUTE_INTERNAL_SERVICE_TOKEN = "test-internal-token-0123456789";
|
|
delete process.env.OMNIROUTE_INTERNAL_SERVICE_TOKEN_FILE;
|
|
const headers = new Headers({
|
|
...getInternalServiceAuthHeaders(),
|
|
[AUTHZ_HEADER_PEER_LOCALITY]: "loopback",
|
|
});
|
|
const request = new Request("http://localhost", { headers });
|
|
assert.equal(headers.get(INTERNAL_SERVICE_AUTH_HEADER), "test-internal-token-0123456789");
|
|
assert.equal(isInternalServiceRequest(request), true);
|
|
assert.equal(isTrustedLoopbackInternalServiceRequest(request), true);
|
|
|
|
const remote = new Request("https://example.test", {
|
|
headers: {
|
|
[INTERNAL_SERVICE_AUTH_HEADER]: "test-internal-token-0123456789",
|
|
[AUTHZ_HEADER_PEER_LOCALITY]: "remote",
|
|
},
|
|
});
|
|
assert.equal(isTrustedLoopbackInternalServiceRequest(remote), false);
|
|
});
|
|
|
|
test("internal service token file is read without exposing it to process env", () => {
|
|
const directory = fs.mkdtempSync(path.join(os.tmpdir(), "omr-internal-auth-"));
|
|
const tokenFile = path.join(directory, "token");
|
|
try {
|
|
fs.writeFileSync(tokenFile, "file-backed-token-0123456789\n", { mode: 0o600 });
|
|
delete process.env.OMNIROUTE_INTERNAL_SERVICE_TOKEN;
|
|
process.env.OMNIROUTE_INTERNAL_SERVICE_TOKEN_FILE = tokenFile;
|
|
assert.deepEqual(getInternalServiceAuthHeaders(), {
|
|
[INTERNAL_SERVICE_AUTH_HEADER]: "file-backed-token-0123456789",
|
|
});
|
|
} finally {
|
|
fs.rmSync(directory, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|