mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
78 lines
2.5 KiB
TypeScript
78 lines
2.5 KiB
TypeScript
/**
|
|
* #7938 — privileged MITM steps (cert trust, DNS) must be skippable when no sudo password.
|
|
*/
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import { EventEmitter } from "node:events";
|
|
import { canRunPrivilegedMitmSteps, isMitmSudoPasswordRequired } from "../../src/mitm/sudoGate.ts";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-mitm-sudo-gate-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const manager = await import("../../src/mitm/manager.ts");
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("canRunPrivilegedMitmSteps is false when isMitmSudoPasswordRequired is true", () => {
|
|
assert.equal(canRunPrivilegedMitmSteps("secret"), !isMitmSudoPasswordRequired("secret"));
|
|
});
|
|
|
|
test("canRunPrivilegedMitmSteps is false for empty password on POSIX sudo-required hosts", () => {
|
|
if (process.platform === "win32") return;
|
|
const isRootUser = !!(process.getuid && process.getuid() === 0);
|
|
if (isRootUser) return;
|
|
if (!isMitmSudoPasswordRequired("")) return;
|
|
assert.equal(canRunPrivilegedMitmSteps(""), false);
|
|
});
|
|
|
|
test("stopMitm skips DNS teardown without sudo password but still kills server (#7938)", async () => {
|
|
if (process.platform === "win32") return;
|
|
const isRootUser = !!(process.getuid && process.getuid() === 0);
|
|
if (isRootUser) return;
|
|
if (!isMitmSudoPasswordRequired("")) return;
|
|
|
|
const events: string[] = [];
|
|
const fakeProc = new EventEmitter() as EventEmitter & {
|
|
killed: boolean;
|
|
kill: (signal?: string) => boolean;
|
|
};
|
|
fakeProc.killed = false;
|
|
fakeProc.kill = (signal?: string) => {
|
|
events.push(`kill:${signal}`);
|
|
fakeProc.killed = true;
|
|
return true;
|
|
};
|
|
|
|
manager.__setServerProcessForTest(
|
|
fakeProc as unknown as import("child_process").ChildProcess,
|
|
4242
|
|
);
|
|
|
|
await manager.stopMitm("", {
|
|
removeDNSEntry: async () => {
|
|
events.push("removeDNSEntry");
|
|
},
|
|
removeDNSEntries: async () => {
|
|
events.push("removeDNSEntries");
|
|
},
|
|
collectManagedHosts: () => ["fake.example.test"],
|
|
});
|
|
|
|
assert.equal(
|
|
events.filter((event) => event.startsWith("remove")).length,
|
|
0,
|
|
"must not invoke DNS teardown with empty sudo password"
|
|
);
|
|
assert.ok(
|
|
events.some((event) => event.startsWith("kill:")),
|
|
"server process must still be stopped"
|
|
);
|
|
});
|