mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-08-18 21:22:28 +03:00
* fix(opencode): session stability, free-tier routing, and CLI defaults - Wire generateSessionId() into opencodeHeaders so x-opencode-session is a deterministic fingerprint instead of randomUUID() per request, enabling upstream prompt caching across a conversation - Thread request body through buildHeaders() so session fingerprint has access to model, system, messages, and tools - Default CLI header synthesis to ON (opt-out via false), align values with 9router proven defaults (opencode/desktop/global) - Auto-echo listing-valid model names for noAuth providers so response.model matches /v1/models listing - Short-circuit free-tier model resolution to opencode provider first to prevent prefix inference misrouting when catalog is unreachable * fix(opencode): make free-tier default flip self-consistent + add coverage PR #10571 flipped OPENCODE_SYNTHESIZE_CLI_HEADERS to on-by-default and changed the synthesized UA/client/project default values, but shipped with 2 broken assertions in the existing #5997 regression test and no coverage for the new session-fingerprinting, free-tier routing, or noAuth echoModel logic (Hard Rule #18). - Update tests/unit/opencode-cli-headers-synthesis-5997.test.ts to match the new on-by-default behavior and new default values; add an explicit opt-out coverage test so the forward-only path is still guarded. - Fix 20 further test failures in tests/unit/opencode-executor.test.ts and tests/unit/refactor-buildHeaders-opencode.test.ts caused by the same default flip (pin OPENCODE_SYNTHESIZE_CLI_HEADERS=false for the characterization suites that predate #10571; use a genuinely CLI-looking UA where the preserved-UA test requires one). - Fix a real bug found via TDD while adding the mandated free-tier routing regression test: the big-pickle/*-free short-circuit in open-sse/services/model.ts checked activeProviders?.has("opencode") literally, but getActiveProviderSet() canonicalizes every connection's provider id through resolveProviderAlias(), which rewrites "opencode" to "opencode-zen" via a manual override — so an active no-auth opencode connection could never satisfy the check. Now checks both opencode-family candidate ids. Proven with a test that fails on the original code and passes with the fix (both connections active with a stale synced catalog omitting big-pickle). - Extract the noAuth-provider echoModel aliasing in chatCore.ts into a pure, directly-testable helper (open-sse/handlers/chatCore/noAuthEchoModel.ts), matching the existing chatCore god-file decomposition pattern. - Add regression tests for generateSessionId()-based x-opencode-session fingerprinting (stable within a conversation, changes on model/message changes), the free-tier routing short-circuit, and the noAuth echoModel aliasing. - Add the changelog.d/ fragment and sync docs/reference/ENVIRONMENT.md's OPENCODE_SYNTHESIZE_CLI_HEADERS/OPENCODE_USER_AGENT/OPENCODE_CLIENT/ OPENCODE_PROJECT rows to the new defaults. Does NOT resolve whether flipping OPENCODE_SYNTHESIZE_CLI_HEADERS's default was the right call, and does NOT touch the separate open PR #10357 which flips the same flag with a different literal default value - that decision is left to the maintainer at merge time. Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com> --------- Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
46 lines
2.1 KiB
TypeScript
46 lines
2.1 KiB
TypeScript
/**
|
|
* Regression test for PR #10571 — chatCore auto-echoes the listing-valid
|
|
* `<alias>/<model>` form in the response `model` field for bare (unprefixed)
|
|
* requests routed to a no-auth catalog provider (e.g. `opencode`), so clients
|
|
* that validate `response.model` against the provider's entry in
|
|
* `/v1/models` (which lists models under the provider's alias prefix) don't
|
|
* warn/reject.
|
|
*
|
|
* `resolveNoAuthEchoModel()` (`open-sse/handlers/chatCore/noAuthEchoModel.ts`)
|
|
* is a pure extraction of the inline logic chatCore.ts wires into its
|
|
* `echoModel` computation.
|
|
*/
|
|
import { test } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { resolveNoAuthEchoModel } from "../../open-sse/handlers/chatCore/noAuthEchoModel.ts";
|
|
import { REGISTRY } from "../../open-sse/config/providerRegistry.ts";
|
|
|
|
test("aliases a bare model routed to a no-auth provider to <alias>/<model>", () => {
|
|
const alias = REGISTRY["opencode"]?.alias;
|
|
assert.ok(alias, "opencode must declare an alias in the registry for this test to be meaningful");
|
|
assert.equal(resolveNoAuthEchoModel("big-pickle", "opencode"), `${alias}/big-pickle`);
|
|
});
|
|
|
|
test("is a no-op (returns null) for an unregistered provider id", () => {
|
|
assert.equal(resolveNoAuthEchoModel("some-model", "provider-with-no-registry-entry"), null);
|
|
});
|
|
|
|
test("is a no-op (returns null) for a non-noAuth provider", () => {
|
|
assert.equal(resolveNoAuthEchoModel("gpt-5.5", "openai"), null);
|
|
});
|
|
|
|
test("is a no-op (returns null) when the requested model already has a provider prefix", () => {
|
|
assert.equal(resolveNoAuthEchoModel("opencode/big-pickle", "opencode"), null);
|
|
});
|
|
|
|
test("is a no-op (returns null) for empty/non-string requested model", () => {
|
|
assert.equal(resolveNoAuthEchoModel("", "opencode"), null);
|
|
assert.equal(resolveNoAuthEchoModel(null, "opencode"), null);
|
|
assert.equal(resolveNoAuthEchoModel(undefined, "opencode"), null);
|
|
});
|
|
|
|
test("is a no-op (returns null) for a null/undefined provider", () => {
|
|
assert.equal(resolveNoAuthEchoModel("big-pickle", null), null);
|
|
assert.equal(resolveNoAuthEchoModel("big-pickle", undefined), null);
|
|
});
|