Files
OmniRoute/tests/unit/text-tool-call-parsing.test.ts
GiauPhan 548316a2c4 fix(translator): Normalize tool call names from lowercase to PascalCase when translating upstream responses to Claude Messages API format (#10392)
* fix(translator): Normalize tool call names from lowercase to PascalCase (#1)

* Fix: Map lowercase tool names from Antigravity (Gemini format) to Claude Code expected PascalCase

* Fix: toolNameMap in fun restoreClaudePassthroughToolUseName

* fix(translator): Normalize tool call names from lowercase to PascalCase when translating upstream responses (OpenAI, Gemini, Antigravity) to Claude Messages API format

This resolves `Error: No such tool available: read`/`bash`/`write` errors when using Claude Code CLI with third-party providers that emit lowercase tool names. The fix adds case-insensitive tool name lookups in `openai-to-claude.ts`, `gemini-to-claude.ts`, and related translators, ensuring tool names like `read`/`bash` are mapped to `Read`/`Bash` before being sent to Claude Code. Includes unit tests and comprehensive changelog notes ([#10250](https://github.com/diegosouzapw/OmniRoute/pull/10250))

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

* fix(translator): Parse <tool_call> JSON and TOOL_CALL text formats fr… (#2)

* fix(translator): Parse <tool_call> JSON and TOOL_CALL text formats from model output

Some models (DeepSeek, Qwen) emit tool calls as text instead of proper
tool_calls JSON: either <tool_call>{...}</tool_call> or TOOL_CALL Name: {...}.
Extend extractXmlInvokeBlocks to handle all 3 formats in a single scan pass,
picking whichever pattern appears first. Includes unit tests for all formats.

* fix(translator): Parse text-format tool calls in gemini-to-claude translator

Extend the Gemini->Claude translator to detect <invoke>, <tool_call> JSON,
and TOOL_CALL text formats emitted inline in text parts (Antigravity/Gemini
models), converting them to proper tool_use content blocks instead of leaking
raw text to Claude Code.

* docs(changelog): Add changelog entry for text tool call parsing fix

* fix(translator): consolidate tool name casing normalization and restore thought-signature persistence (#3)

* fix(translator): sanitize tool_use.id and tool_result.tool_use_id to match Anthropic schema (#4)

Ensure tool IDs from OpenAI-compatible upstreams (which may contain dots, colons, or special characters) are sanitized to ^[a-zA-Z0-9_-]+$ in response translators and passthrough requests before reaching Claude endpoints.

* fix(responses): preserve native tools for openai-compatible Responses targets (#5)

A Responses-shaped request to a custom openai-compatible connection whose
outbound protocol is Responses took a Responses -> Chat -> Responses round
trip, so Codex custom tools lost their grammar (`exec`), namespace groups were
flattened (`collaboration`), and tool invocations failed upstream.

Gate a native Responses passthrough on the connection's configured protocol
(`apiType: "responses"` / `_omnirouteForceResponsesUpstream`) so the original
tool definitions reach a Responses-capable upstream unchanged. Chat-only
connections keep the existing downgrade.

Closes #10374

* fix(translator): add support for 'applypatch' tool name in tool call checks

* test(translator): add unit test for apply_patch and applypatch tool name remapping

* fix(translator): remove no-explicit-any lint errors in tool-use-id-sanitization test

Type the openaiToClaudeResponse/translateNonStreamingResponse return
values with narrow local shapes instead of `any`, satisfying the
repo's no-explicit-any = error rule for tests/. No behavior change —
the same 3 assertions still pass.

Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>

* test: update 9568 casing regression to match #10392's consolidated fix

restoreClaudeToolName's static casing map now normalizes known
lowercase tool names to canonical PascalCase unconditionally on the
gemini-to-claude and openai-to-claude Claude Messages API paths (not
gated behind toolNameMap), superseding the earlier per-map-only fix
that the original #9568 regression test locked in as "expected" (it
was previously labeled a known bug case). The gemini-to-openai
passthrough path is unaffected by #10392 and keeps its original
pass-through assertion.

Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
2026-08-18 10:49:48 -03:00

113 lines
4.0 KiB
TypeScript

import { describe, it } from "node:test";
import assert from "node:assert/strict";
import { openaiToClaudeResponse } from "../../open-sse/translator/response/openai-to-claude.ts";
import { geminiToClaudeResponse } from "../../open-sse/translator/response/gemini-to-claude.ts";
interface XmlToolCall {
id: string;
name: string;
args: Record<string, string>;
}
interface TestState {
toolCalls: Map<number, unknown>;
nextBlockIndex: number;
_pendingXmlToolCalls: XmlToolCall[];
}
describe("Text Tool Call Parsing Fixes", () => {
it("parses <tool_call> JSON blocks in OpenAI content text", () => {
const chunk = {
choices: [
{
delta: {
content: '<tool_call>{"name":"Write","arguments":{"file_path":"/tmp/test.txt","content":"hello"}}</tool_call>',
},
finish_reason: "stop",
},
],
};
const state: TestState = { toolCalls: new Map(), nextBlockIndex: 0, _pendingXmlToolCalls: [] };
openaiToClaudeResponse(
chunk as unknown as Parameters<typeof openaiToClaudeResponse>[0],
state as unknown as Parameters<typeof openaiToClaudeResponse>[1]
);
assert.equal(state._pendingXmlToolCalls.length, 1);
assert.equal(state._pendingXmlToolCalls[0].name, "Write");
assert.equal(state._pendingXmlToolCalls[0].args.file_path, "/tmp/test.txt");
});
it("parses TOOL_CALL Name: JSON blocks in OpenAI content text", () => {
const chunk = {
choices: [
{
delta: {
content: 'TOOL_CALL Read: {"file_path":"/home/ubuntu/codeatlas-mcp-server/SECURITY.md"}',
},
finish_reason: "stop",
},
],
};
const state: TestState = { toolCalls: new Map(), nextBlockIndex: 0, _pendingXmlToolCalls: [] };
openaiToClaudeResponse(
chunk as unknown as Parameters<typeof openaiToClaudeResponse>[0],
state as unknown as Parameters<typeof openaiToClaudeResponse>[1]
);
assert.equal(state._pendingXmlToolCalls.length, 1);
assert.equal(state._pendingXmlToolCalls[0].name, "Read");
assert.equal(state._pendingXmlToolCalls[0].args.file_path, "/home/ubuntu/codeatlas-mcp-server/SECURITY.md");
});
it("parses standard XML <invoke> blocks in OpenAI content text", () => {
const chunk = {
choices: [
{
delta: {
content: '<invoke name="Bash"><parameter name="command">ls -la</parameter></invoke>',
},
finish_reason: "stop",
},
],
};
const state: TestState = { toolCalls: new Map(), nextBlockIndex: 0, _pendingXmlToolCalls: [] };
openaiToClaudeResponse(
chunk as unknown as Parameters<typeof openaiToClaudeResponse>[0],
state as unknown as Parameters<typeof openaiToClaudeResponse>[1]
);
assert.equal(state._pendingXmlToolCalls.length, 1);
assert.equal(state._pendingXmlToolCalls[0].name, "Bash");
assert.equal(state._pendingXmlToolCalls[0].args.command, "ls -la");
});
it("parses <tool_call> JSON blocks in Gemini content text", () => {
const chunk = {
candidates: [
{
content: {
parts: [
{
text: '<tool_call>{"name":"bash","arguments":{"command":"pwd"}}</tool_call>',
},
],
},
},
],
};
const state: {
messageId: string | null;
model: string;
contentBlockIndex: number;
openTextBlockIdx: number | null;
} = { messageId: null, model: "gemini", contentBlockIndex: 0, openTextBlockIdx: null };
const events = geminiToClaudeResponse(
chunk as unknown as Parameters<typeof geminiToClaudeResponse>[0],
state as unknown as Parameters<typeof geminiToClaudeResponse>[1]
);
const startEvent = (events as Array<{ type: string; content_block?: { type: string; name: string } }>)?.find(
(e) => e.type === "content_block_start" && e.content_block?.type === "tool_use"
);
assert.ok(startEvent, "Should emit tool_use content_block_start");
assert.equal(startEvent?.content_block?.name, "Bash");
});
});