Files
OmniRoute/tests/unit/chatcore-compression-usage-receipt.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

76 lines
2.7 KiB
TypeScript

// tests/unit/chatcore-compression-usage-receipt.test.ts
// Characterization of attachCompressionUsageReceiptAfterAnalytics — the fire-and-forget compression
// usage-receipt attachment extracted from handleChatCore (chatCore god-file decomposition, #3501).
// Uses a real temp DB: inserts a compression_analytics row, attaches a receipt after pendingWrite,
// and asserts the aggregated realUsage. Also locks the best-effort error swallowing.
import { test, before, after } from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const testDataDir = fs.mkdtempSync(path.join(os.tmpdir(), "omni-compression-receipt-test-"));
process.env.DATA_DIR = testDataDir;
const coreDb = await import("../../src/lib/db/core.ts");
const { insertCompressionAnalyticsRow, getCompressionAnalyticsSummary } =
await import("../../src/lib/db/compressionAnalytics.ts");
const { attachCompressionUsageReceiptAfterAnalytics } =
await import("../../open-sse/handlers/chatCore/compressionUsageReceipt.ts");
const tick = (ms: number) => new Promise((r) => setTimeout(r, ms));
before(async () => {
await coreDb.ensureDbInitialized();
});
after(() => {
coreDb.resetDbInstance();
fs.rmSync(testDataDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("attaches the usage receipt only after pendingWrite resolves", async () => {
insertCompressionAnalyticsRow({
timestamp: new Date().toISOString(),
mode: "test",
original_tokens: 100,
compressed_tokens: 60,
tokens_saved: 40,
request_id: "req-1",
});
let pendingResolved = false;
const pendingWrite = new Promise<void>((res) =>
setTimeout(() => {
pendingResolved = true;
res();
}, 20)
);
attachCompressionUsageReceiptAfterAnalytics(
{ prompt_tokens: 10, completion_tokens: 5, total_tokens: 15 },
"provider",
{ pendingWrite, skillRequestId: "req-1" }
);
await tick(80);
assert.equal(pendingResolved, true, "pendingWrite should have resolved first");
const summary = getCompressionAnalyticsSummary();
assert.equal(summary.realUsage.requestsWithReceipts, 1);
assert.equal(summary.realUsage.promptTokens, 10);
assert.equal(summary.realUsage.completionTokens, 5);
});
test("swallows the no-matching-row case without throwing or recording a receipt", async () => {
assert.doesNotThrow(() =>
attachCompressionUsageReceiptAfterAnalytics({ prompt_tokens: 1, total_tokens: 1 }, "provider", {
pendingWrite: null,
skillRequestId: "does-not-exist",
})
);
await tick(40);
const summary = getCompressionAnalyticsSummary();
assert.equal(summary.realUsage.requestsWithReceipts, 1);
});