mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-07 15:32:10 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
110 lines
4.4 KiB
TypeScript
110 lines
4.4 KiB
TypeScript
// ENVIRONMENT NOTE (sandbox better-sqlite3 / glibc limitation, not a code defect):
|
|
// This test constructs or exercises a real better-sqlite3-backed SQLite database.
|
|
// better-sqlite3 is a native addon; production and CI load it normally, but some
|
|
// sandboxes/dev boxes ship a system glibc older than the prebuilt binary requires
|
|
// ("GLIBC_2.29 not found"), so the native module fails to dlopen and any test that
|
|
// reaches better-sqlite3 directly (or asserts stdout that the load-failure warning
|
|
// would pollute) fails HERE while passing in CI. This is a known environment
|
|
// limitation, not a defect in the code under test: the OmniRoute runtime itself
|
|
// cascades to node:sqlite/sql.js when better-sqlite3 is unavailable. See
|
|
// tests/unit/_helpers/betterSqlite3Availability.ts for a guard helper.
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const ORIGINAL_DATA_DIR = process.env.DATA_DIR;
|
|
|
|
function createTempDataDir() {
|
|
return fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-cli-backup-"));
|
|
}
|
|
|
|
async function withBackupEnv(fn: (dataDir: string) => Promise<void>) {
|
|
const dataDir = createTempDataDir();
|
|
process.env.DATA_DIR = dataDir;
|
|
|
|
const originalLog = console.log;
|
|
console.log = () => {};
|
|
|
|
try {
|
|
await fn(dataDir);
|
|
} finally {
|
|
console.log = originalLog;
|
|
fs.rmSync(dataDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
if (ORIGINAL_DATA_DIR === undefined) delete process.env.DATA_DIR;
|
|
else process.env.DATA_DIR = ORIGINAL_DATA_DIR;
|
|
}
|
|
}
|
|
|
|
test("backup returns 0 with no files (empty data dir)", async () => {
|
|
await withBackupEnv(async () => {
|
|
const { runBackupCommand } = await import("../../bin/cli/commands/backup.mjs");
|
|
const result = await runBackupCommand({});
|
|
assert.equal(result, 0);
|
|
});
|
|
});
|
|
|
|
test("backup creates backup-info.json when storage.sqlite exists", async () => {
|
|
await withBackupEnv(async (dataDir) => {
|
|
const dbPath = path.join(dataDir, "storage.sqlite");
|
|
const Database = (await import("better-sqlite3")).default;
|
|
new Database(dbPath).close();
|
|
|
|
const { runBackupCommand } = await import("../../bin/cli/commands/backup.mjs");
|
|
const result = await runBackupCommand({});
|
|
assert.equal(result, 0);
|
|
|
|
const backupDir = path.join(dataDir, "backups");
|
|
assert.ok(fs.existsSync(backupDir));
|
|
const entries = fs.readdirSync(backupDir).filter((d) => d.startsWith("omniroute-backup-"));
|
|
assert.ok(entries.length > 0);
|
|
const infoPath = path.join(backupDir, entries[0], "backup-info.json");
|
|
assert.ok(fs.existsSync(infoPath));
|
|
const info = JSON.parse(fs.readFileSync(infoPath, "utf8"));
|
|
assert.ok(info.timestamp);
|
|
assert.ok(Array.isArray(info.files));
|
|
});
|
|
});
|
|
|
|
test("encrypted backup removes temporary ciphertext files", async () => {
|
|
await withBackupEnv(async (dataDir) => {
|
|
fs.writeFileSync(path.join(dataDir, "settings.json"), JSON.stringify({ ok: true }), "utf8");
|
|
const keyFile = path.join(dataDir, "backup.key");
|
|
fs.writeFileSync(keyFile, "test-passphrase", "utf8");
|
|
|
|
const { runBackupCommand } = await import("../../bin/cli/commands/backup.mjs");
|
|
const result = await runBackupCommand({ encrypt: true, keyFile });
|
|
assert.equal(result, 0);
|
|
|
|
const backupDir = path.join(dataDir, "backups");
|
|
const entries = fs.readdirSync(backupDir).filter((d) => d.startsWith("omniroute-backup-"));
|
|
assert.ok(entries.length > 0);
|
|
const backupPath = path.join(backupDir, entries[0]);
|
|
assert.deepEqual(
|
|
fs.readdirSync(backupPath).filter((name) => name.endsWith(".ciphertext")),
|
|
[]
|
|
);
|
|
assert.ok(fs.existsSync(path.join(backupPath, "settings.json.enc")));
|
|
});
|
|
});
|
|
|
|
test("restore --list returns 0 with no backups", async () => {
|
|
await withBackupEnv(async () => {
|
|
const { runRestoreCommand } = await import("../../bin/cli/commands/backup.mjs");
|
|
const result = await runRestoreCommand(undefined, { list: true });
|
|
assert.equal(result, 0);
|
|
});
|
|
});
|
|
|
|
test("restore returns 1 when backup id not found", async () => {
|
|
await withBackupEnv(async () => {
|
|
const { runRestoreCommand } = await import("../../bin/cli/commands/backup.mjs");
|
|
const originalError = console.error;
|
|
console.error = () => {};
|
|
const result = await runRestoreCommand("nonexistent-id", { yes: true });
|
|
console.error = originalError;
|
|
assert.equal(result, 1);
|
|
});
|
|
});
|