mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-01 20:32:13 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
145 lines
5.9 KiB
TypeScript
145 lines
5.9 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { mkdtempSync, rmSync, writeFileSync, mkdirSync } from "node:fs";
|
|
import { join } from "node:path";
|
|
import { tmpdir } from "node:os";
|
|
|
|
let tmpDir: string;
|
|
let origDataDir: string | undefined;
|
|
|
|
test.before(() => {
|
|
tmpDir = mkdtempSync(join(tmpdir(), "omniroute-runtime-test-"));
|
|
origDataDir = process.env.DATA_DIR;
|
|
process.env.DATA_DIR = tmpDir;
|
|
});
|
|
|
|
test.after(() => {
|
|
if (origDataDir === undefined) delete process.env.DATA_DIR;
|
|
else process.env.DATA_DIR = origDataDir;
|
|
try {
|
|
rmSync(tmpDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
} catch {}
|
|
});
|
|
|
|
test("nativeDeps.mjs pode ser importado sem erro", async () => {
|
|
const mod = await import("../../bin/cli/runtime/nativeDeps.mjs");
|
|
assert.equal(typeof mod.ensureRuntimeDir, "function");
|
|
assert.equal(typeof mod.getRuntimeNodeModules, "function");
|
|
assert.equal(typeof mod.hasModule, "function");
|
|
assert.equal(typeof mod.isBetterSqliteBinaryValid, "function");
|
|
assert.equal(typeof mod.npmInstallRuntime, "function");
|
|
assert.equal(typeof mod.ensureBetterSqliteRuntime, "function");
|
|
assert.equal(typeof mod.buildEnvWithRuntime, "function");
|
|
});
|
|
|
|
test("ensureRuntimeDir cria diretório e package.json", async () => {
|
|
const { ensureRuntimeDir } = await import("../../bin/cli/runtime/nativeDeps.mjs");
|
|
const dir = ensureRuntimeDir();
|
|
const { existsSync } = await import("node:fs");
|
|
assert.ok(existsSync(dir), "runtime dir deve existir");
|
|
assert.ok(existsSync(join(dir, "package.json")), "package.json deve existir");
|
|
});
|
|
|
|
test("getRuntimeNodeModules retorna caminho dentro do DATA_DIR", async () => {
|
|
const { getRuntimeNodeModules } = await import("../../bin/cli/runtime/nativeDeps.mjs");
|
|
const nm = getRuntimeNodeModules();
|
|
assert.ok(nm.startsWith(tmpDir), "node_modules deve estar dentro do tmpDir");
|
|
assert.ok(nm.endsWith("node_modules"), "path deve terminar com node_modules");
|
|
});
|
|
|
|
test("hasModule retorna false para módulo inexistente", async () => {
|
|
const { hasModule } = await import("../../bin/cli/runtime/nativeDeps.mjs");
|
|
assert.equal(hasModule("definitely-not-installed-xyz"), false);
|
|
});
|
|
|
|
test("isBetterSqliteBinaryValid retorna false quando binário não existe", async () => {
|
|
const { isBetterSqliteBinaryValid } = await import("../../bin/cli/runtime/nativeDeps.mjs");
|
|
assert.equal(isBetterSqliteBinaryValid(), false);
|
|
});
|
|
|
|
test("buildEnvWithRuntime extende NODE_PATH com runtime node_modules", async () => {
|
|
const { buildEnvWithRuntime, getRuntimeNodeModules } =
|
|
await import("../../bin/cli/runtime/nativeDeps.mjs");
|
|
const nm = getRuntimeNodeModules();
|
|
const env = buildEnvWithRuntime({});
|
|
assert.ok(env.NODE_PATH.includes(nm), "NODE_PATH deve conter runtime node_modules");
|
|
});
|
|
|
|
test("buildEnvWithRuntime preserva NODE_PATH existente", async () => {
|
|
const { buildEnvWithRuntime } = await import("../../bin/cli/runtime/nativeDeps.mjs");
|
|
const env = buildEnvWithRuntime({ NODE_PATH: "/existing/path" });
|
|
assert.ok(env.NODE_PATH.includes("/existing/path"), "NODE_PATH original deve ser preservado");
|
|
});
|
|
|
|
test("isBetterSqliteBinaryValid rejeita binário com magic bytes válidos mas ABI incompatível (regressão #2493)", async () => {
|
|
// Regression for upstream 9router#2493: a binary that only "looks" native (correct ELF/Mach-O/PE
|
|
// header) but was built for a different Node ABI (NODE_MODULE_VERSION) must NOT be reported as
|
|
// valid — loading it crashes the process (segfault) instead of triggering a rebuild.
|
|
const { getRuntimeNodeModules, isBetterSqliteBinaryValid } =
|
|
await import("../../bin/cli/runtime/nativeDeps.mjs");
|
|
const nm = getRuntimeNodeModules();
|
|
const buildDir = join(nm, "better-sqlite3", "build", "Release");
|
|
mkdirSync(buildDir, { recursive: true });
|
|
const binary = join(buildDir, "better_sqlite3.node");
|
|
const { platform } = await import("node:os");
|
|
const os = platform();
|
|
// Correct file-format magic bytes for the current OS, but not a real, loadable native addon —
|
|
// this is exactly what the old magic-bytes-only check let through.
|
|
const magicByPlatform = {
|
|
linux: [0x7f, 0x45, 0x4c, 0x46],
|
|
darwin: [0xcf, 0xfa, 0xed, 0xfe],
|
|
win32: [0x4d, 0x5a],
|
|
};
|
|
const magic = magicByPlatform[os] ?? magicByPlatform.linux;
|
|
const buf = Buffer.concat([Buffer.from(magic), Buffer.alloc(64, 0)]);
|
|
writeFileSync(binary, buf);
|
|
const result = isBetterSqliteBinaryValid();
|
|
assert.equal(
|
|
result,
|
|
false,
|
|
"binário com header válido mas ABI/conteúdo incompatível deve ser inválido"
|
|
);
|
|
rmSync(join(nm, "better-sqlite3"), {
|
|
recursive: true,
|
|
force: true,
|
|
maxRetries: 5,
|
|
retryDelay: 100,
|
|
});
|
|
});
|
|
|
|
test("isBetterSqliteBinaryValid aceita um binário nativo real e carregável", async () => {
|
|
const { getRuntimeNodeModules, isBetterSqliteBinaryValid } =
|
|
await import("../../bin/cli/runtime/nativeDeps.mjs");
|
|
const { existsSync, copyFileSync } = await import("node:fs");
|
|
const realBinary = join(
|
|
process.cwd(),
|
|
"node_modules",
|
|
"better-sqlite3",
|
|
"build",
|
|
"Release",
|
|
"better_sqlite3.node"
|
|
);
|
|
if (!existsSync(realBinary)) {
|
|
// Ambient runtime without a compiled better-sqlite3 binary — nothing to assert here.
|
|
return;
|
|
}
|
|
const nm = getRuntimeNodeModules();
|
|
const buildDir = join(nm, "better-sqlite3", "build", "Release");
|
|
mkdirSync(buildDir, { recursive: true });
|
|
const binary = join(buildDir, "better_sqlite3.node");
|
|
copyFileSync(realBinary, binary);
|
|
const result = isBetterSqliteBinaryValid();
|
|
assert.equal(result, true, "um binário real, compatível com o Node atual, deve ser válido");
|
|
rmSync(join(nm, "better-sqlite3"), {
|
|
recursive: true,
|
|
force: true,
|
|
maxRetries: 5,
|
|
retryDelay: 100,
|
|
});
|
|
});
|
|
|
|
test("commands/runtime.mjs pode ser importado sem erro", async () => {
|
|
const mod = await import("../../bin/cli/commands/runtime.mjs");
|
|
assert.equal(typeof mod.registerRuntime, "function");
|
|
});
|