mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 02:42:24 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
101 lines
3.4 KiB
TypeScript
101 lines
3.4 KiB
TypeScript
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import test from "node:test";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-codex-revalidation-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const providersDb = await import("../../src/lib/db/providers.ts");
|
|
const revalidation = await import("../../src/shared/services/codexCatalogRevalidation.ts");
|
|
|
|
const originalFetch = globalThis.fetch;
|
|
const originalEnv = {
|
|
OMNIROUTE_PORT: process.env.OMNIROUTE_PORT,
|
|
PORT: process.env.PORT,
|
|
DASHBOARD_PORT: process.env.DASHBOARD_PORT,
|
|
BASE_URL: process.env.BASE_URL,
|
|
NEXT_PUBLIC_BASE_URL: process.env.NEXT_PUBLIC_BASE_URL,
|
|
NEXT_PUBLIC_APP_URL: process.env.NEXT_PUBLIC_APP_URL,
|
|
OMNIROUTE_INTERNAL_SCHEME: process.env.OMNIROUTE_INTERNAL_SCHEME,
|
|
};
|
|
|
|
async function resetStorage() {
|
|
globalThis.fetch = originalFetch;
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
}
|
|
|
|
test.beforeEach(async () => {
|
|
await resetStorage();
|
|
process.env.OMNIROUTE_PORT = "20128";
|
|
process.env.PORT = "22128";
|
|
process.env.DASHBOARD_PORT = "22128";
|
|
process.env.BASE_URL = "https://attacker.example";
|
|
delete process.env.NEXT_PUBLIC_BASE_URL;
|
|
delete process.env.NEXT_PUBLIC_APP_URL;
|
|
delete process.env.OMNIROUTE_INTERNAL_SCHEME;
|
|
});
|
|
|
|
test.after(() => {
|
|
globalThis.fetch = originalFetch;
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
for (const [key, value] of Object.entries(originalEnv)) {
|
|
if (value === undefined) delete process.env[key];
|
|
else process.env[key] = value;
|
|
}
|
|
});
|
|
|
|
test("live Codex revalidation sends its internal header only to the dashboard loopback origin", async () => {
|
|
const connection = await providersDb.createProviderConnection({
|
|
provider: "codex",
|
|
authType: "oauth",
|
|
name: "Codex Runtime Safety",
|
|
accessToken: "test-token",
|
|
isActive: true,
|
|
providerSpecificData: { workspaceId: "runtime-safety" },
|
|
});
|
|
const calls: Array<{ url: string; hasInternalAuth: boolean; redirect?: RequestRedirect }> = [];
|
|
globalThis.fetch = async (input, init) => {
|
|
const headers = new Headers(init?.headers);
|
|
calls.push({
|
|
url: String(input),
|
|
hasInternalAuth: headers.has("x-model-sync-internal-auth"),
|
|
redirect: init?.redirect,
|
|
});
|
|
return Response.json({ syncedModels: 1 });
|
|
};
|
|
|
|
const result = await revalidation.liveResyncCodexConnections("http://127.0.0.1:7777");
|
|
|
|
assert.deepEqual(result, { attempted: 1, succeeded: 1 });
|
|
assert.deepEqual(calls, [
|
|
{
|
|
url: `http://127.0.0.1:22128/api/providers/${connection.id}/sync-models?quiet=1`,
|
|
hasInternalAuth: true,
|
|
redirect: "error",
|
|
},
|
|
]);
|
|
});
|
|
|
|
test("Codex readiness and live sync resolve the same dashboard loopback port", async () => {
|
|
const calls: string[] = [];
|
|
globalThis.fetch = async (input, init) => {
|
|
calls.push(String(input));
|
|
assert.equal(init?.redirect, "error");
|
|
return new Response(null, { status: 404 });
|
|
};
|
|
|
|
await revalidation.waitForLoopbackHttpReady({
|
|
apiBaseUrl: "http://localhost:7777",
|
|
maxWaitMs: 100,
|
|
pollMs: 1,
|
|
});
|
|
|
|
assert.deepEqual(calls, ["http://127.0.0.1:22128/api/providers/__readiness_probe__/models"]);
|
|
});
|