Files
OmniRoute/tests/unit/compression/retrieveRouteRanged.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

65 lines
2.5 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import { join } from "node:path";
import { mkdtempSync, rmSync } from "node:fs";
import { tmpdir } from "node:os";
const TEST_DATA_DIR = mkdtempSync(join(tmpdir(), "retrieve-ranged-"));
process.env.DATA_DIR = TEST_DATA_DIR;
process.env.API_KEY_SECRET = process.env.API_KEY_SECRET ?? "test-secret-32-chars-min-aaaaaaaa";
delete process.env.INITIAL_PASSWORD;
const core = await import("../../../src/lib/db/core.ts");
const ccr = await import("../../../open-sse/services/compression/engines/ccr/index.ts");
const route = await import("../../../src/app/api/compression/retrieve/route.ts");
const BLOCK = ["x1", "x2 ERR", "x3", "x4"].join("\n");
function makeReq(body: unknown) {
return new Request("http://localhost/api/compression/retrieve", {
method: "POST",
headers: { "content-type": "application/json" },
body: JSON.stringify(body),
});
}
test.beforeEach(() => {
core.resetDbInstance();
ccr.resetCcrStore();
});
test.after(() => {
core.resetDbInstance();
rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("mode:head n:2 returns first 2 lines", async () => {
const hash = ccr.storeBlock(BLOCK); // management scope (no principalId)
const res = await route.POST(makeReq({ hash, mode: "head", n: 2 }));
assert.equal(res.status, 200);
const json = await res.json();
assert.equal(json.found, true);
assert.equal(json.block, "x1\nx2 ERR");
});
test("mode:stats returns correct line count", async () => {
const hash = ccr.storeBlock(BLOCK);
const res = await route.POST(makeReq({ hash, mode: "stats" }));
assert.equal(res.status, 200);
const json = await res.json();
assert.equal(json.found, true);
assert.equal(JSON.parse(json.block).lines, 4);
});
test("mode:grep with ReDoS pattern is rejected and sanitized", async () => {
const hash = ccr.storeBlock(BLOCK);
const res = await route.POST(makeReq({ hash, mode: "grep", pattern: "(a+)+$" }));
assert.equal(res.status, 200);
const json = await res.json();
assert.ok(json.error, "expected an error field for the rejected ReDoS pattern");
assert.ok(!String(json.error).includes("at /"), "error must be sanitized");
});
test("no mode returns the whole block (backward-compat)", async () => {
const hash = ccr.storeBlock(BLOCK);
const res = await route.POST(makeReq({ hash }));
assert.equal(res.status, 200);
const json = await res.json();
assert.equal(json.found, true);
assert.equal(json.block, BLOCK);
});