mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
57 lines
2.5 KiB
TypeScript
57 lines
2.5 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
// R0.3 — unit tests for the ExecutorRegistry seam itself (registration
|
|
// semantics + wiring of the built-ins). Behavior parity of the full map is
|
|
// covered separately by tests/unit/executor-map-golden.test.ts.
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-executor-registry-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const { registerExecutor, getRegisteredExecutor, hasRegisteredExecutor, listExecutorAliases } =
|
|
await import("../../open-sse/executors/registry.ts");
|
|
const { getExecutor, hasSpecializedExecutor, BaseExecutor, DefaultExecutor } =
|
|
await import("../../open-sse/executors/index.ts");
|
|
|
|
test.after(() => {
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("built-ins are registered at module load and resolve through the registry", async () => {
|
|
const aliases = listExecutorAliases();
|
|
assert.ok(aliases.length >= 100, `expected the built-in table, got ${aliases.length} aliases`);
|
|
for (const alias of ["antigravity", "kiro", "glm", "9router", "conol-web"]) {
|
|
assert.ok(hasRegisteredExecutor(alias), `missing built-in: ${alias}`);
|
|
assert.equal(await getExecutor(alias), getRegisteredExecutor(alias));
|
|
assert.ok((await getExecutor(alias)) instanceof BaseExecutor);
|
|
}
|
|
});
|
|
|
|
test("registerExecutor throws on duplicate alias", () => {
|
|
assert.throws(() => registerExecutor("kiro", getRegisteredExecutor("kiro")!), {
|
|
message: /already registered: "kiro"/,
|
|
});
|
|
});
|
|
|
|
test("registering a new alias makes it resolvable via getExecutor and hasSpecializedExecutor", async () => {
|
|
const alias = "registry-test-provider";
|
|
assert.equal(hasSpecializedExecutor(alias), false);
|
|
const instance = new DefaultExecutor(alias);
|
|
registerExecutor(alias, instance);
|
|
assert.equal(hasSpecializedExecutor(alias), true);
|
|
assert.equal(await getExecutor(alias), instance);
|
|
});
|
|
|
|
test("registry lookup is exact — Object.prototype names are not executors", async () => {
|
|
// The old object-literal lookup (`executors[provider]`) leaked prototype
|
|
// members: getExecutor("constructor") returned Object's constructor. The Map
|
|
// registry must treat these as unknown providers (DefaultExecutor fallback).
|
|
for (const name of ["constructor", "toString", "hasOwnProperty", "__proto__"]) {
|
|
assert.equal(hasSpecializedExecutor(name), false, name);
|
|
assert.ok((await getExecutor(name)) instanceof DefaultExecutor, name);
|
|
}
|
|
});
|