Files
OmniRoute/tests/unit/interception-rules.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

97 lines
3.7 KiB
TypeScript

import { describe, it, beforeEach, after } from "node:test";
import assert from "node:assert/strict";
import os from "node:os";
import path from "node:path";
import fs from "node:fs";
// Set DATA_DIR to a temp dir before any imports that touch the DB.
const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-test-interception-rules-"));
process.env.DATA_DIR = tmpDir;
const core = await import("../../src/lib/db/core.ts");
const {
getInterceptionRules,
setInterceptionRules,
deleteInterceptionRules,
resolveInterceptSearch,
} = await import("../../src/lib/db/interceptionRules.ts");
// #3384 — per-model web-search/web-fetch interception rule store.
describe("db/interceptionRules — per-model interception rules (#3384)", () => {
function resetDb() {
core.resetDbInstance();
fs.rmSync(tmpDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(tmpDir, { recursive: true });
}
beforeEach(() => {
resetDb();
});
after(() => {
core.resetDbInstance();
fs.rmSync(tmpDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
it("returns null for an unconfigured provider", () => {
assert.equal(getInterceptionRules("anthropic"), null);
});
it("round-trips a provider-level rule via set/get", () => {
setInterceptionRules("anthropic", { interceptSearch: true, interceptFetch: false });
const rules = getInterceptionRules("anthropic");
assert.equal(rules?.interceptSearch, true);
assert.equal(rules?.interceptFetch, false);
});
it("round-trips a per-model override", () => {
setInterceptionRules("anthropic", {
interceptSearch: false,
models: { "claude-opus-4": { interceptSearch: true } },
});
const rules = getInterceptionRules("anthropic");
assert.equal(rules?.interceptSearch, false);
assert.equal(rules?.models?.["claude-opus-4"]?.interceptSearch, true);
});
it("delete resets a provider back to unconfigured", () => {
setInterceptionRules("anthropic", { interceptSearch: true });
deleteInterceptionRules("anthropic");
assert.equal(getInterceptionRules("anthropic"), null);
});
it("invalidates the in-memory cache after a write", () => {
setInterceptionRules("openai", { interceptSearch: true });
assert.equal(getInterceptionRules("openai")?.interceptSearch, true);
setInterceptionRules("openai", { interceptSearch: false });
assert.equal(getInterceptionRules("openai")?.interceptSearch, false);
});
describe("resolveInterceptSearch — precedence", () => {
it("returns undefined when no rule is configured (caller falls back to bypass defaults)", () => {
assert.equal(resolveInterceptSearch("anthropic", "claude-opus-4"), undefined);
});
it("returns the provider-level rule when no model override exists", () => {
setInterceptionRules("anthropic", { interceptSearch: true });
assert.equal(resolveInterceptSearch("anthropic", "claude-opus-4"), true);
assert.equal(resolveInterceptSearch("anthropic", "claude-haiku-4"), true);
});
it("per-model rule overrides the provider-level rule", () => {
setInterceptionRules("anthropic", {
interceptSearch: false,
models: { "claude-opus-4": { interceptSearch: true } },
});
assert.equal(resolveInterceptSearch("anthropic", "claude-opus-4"), true);
assert.equal(resolveInterceptSearch("anthropic", "claude-haiku-4"), false);
});
it("returns undefined for an empty/missing provider", () => {
assert.equal(resolveInterceptSearch("", "claude-opus-4"), undefined);
assert.equal(resolveInterceptSearch(null, "claude-opus-4"), undefined);
assert.equal(resolveInterceptSearch(undefined, "claude-opus-4"), undefined);
});
});
});