mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
84 lines
3.1 KiB
TypeScript
84 lines
3.1 KiB
TypeScript
import { describe, it } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { mkdtempSync, writeFileSync, mkdirSync, rmSync } from "node:fs";
|
|
import { join } from "node:path";
|
|
import { tmpdir } from "node:os";
|
|
|
|
const mod = await import("../../src/lib/plugins/scanner.ts");
|
|
|
|
function makePluginDir(tmpDir: string, name: string, manifest: Record<string, unknown>) {
|
|
const pluginDir = join(tmpDir, name);
|
|
mkdirSync(pluginDir, { recursive: true });
|
|
writeFileSync(join(pluginDir, "plugin.json"), JSON.stringify(manifest, null, 2));
|
|
writeFileSync(join(pluginDir, "index.js"), "module.exports = {};");
|
|
return pluginDir;
|
|
}
|
|
|
|
const validManifest = { name: "scan-test", version: "1.0.0" };
|
|
|
|
describe("plugin scanner", () => {
|
|
describe("getDefaultPluginDir", () => {
|
|
it("returns a string path", () => {
|
|
const dir = mod.getDefaultPluginDir();
|
|
assert.equal(typeof dir, "string");
|
|
assert.ok(dir.includes("plugins") || dir.includes("omniroute"));
|
|
});
|
|
});
|
|
|
|
describe("scanPluginDir", () => {
|
|
it("discovers valid plugins", async () => {
|
|
const tmp = mkdtempSync(join(tmpdir(), "scan-test-"));
|
|
try {
|
|
makePluginDir(tmp, "my-plugin", validManifest);
|
|
const result = await mod.scanPluginDir(tmp);
|
|
assert.equal(result.plugins.length, 1);
|
|
assert.equal(result.plugins[0].name, "scan-test");
|
|
assert.ok(result.plugins[0].manifest);
|
|
assert.ok(result.plugins[0].pluginDir);
|
|
} finally {
|
|
rmSync(tmp, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|
|
|
|
it("skips directories without plugin.json", async () => {
|
|
const tmp = mkdtempSync(join(tmpdir(), "scan-test-"));
|
|
try {
|
|
mkdirSync(join(tmp, "not-a-plugin"));
|
|
writeFileSync(join(tmp, "not-a-plugin", "index.js"), "");
|
|
const result = await mod.scanPluginDir(tmp);
|
|
assert.equal(result.plugins.length, 0);
|
|
} finally {
|
|
rmSync(tmp, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|
|
|
|
it("skips plugins with invalid manifest", async () => {
|
|
const tmp = mkdtempSync(join(tmpdir(), "scan-test-"));
|
|
try {
|
|
makePluginDir(tmp, "bad-plugin", { name: "INVALID NAME!", version: "nope" });
|
|
const result = await mod.scanPluginDir(tmp);
|
|
assert.equal(result.plugins.length, 0);
|
|
} finally {
|
|
rmSync(tmp, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|
|
|
|
it("handles non-existent directory", async () => {
|
|
const result = await mod.scanPluginDir("/nonexistent/path");
|
|
assert.equal(result.plugins.length, 0);
|
|
});
|
|
|
|
it("discovers multiple plugins", async () => {
|
|
const tmp = mkdtempSync(join(tmpdir(), "scan-test-"));
|
|
try {
|
|
makePluginDir(tmp, "plugin-a", { name: "plugin-a", version: "1.0.0" });
|
|
makePluginDir(tmp, "plugin-b", { name: "plugin-b", version: "2.0.0" });
|
|
const result = await mod.scanPluginDir(tmp);
|
|
assert.equal(result.plugins.length, 2);
|
|
} finally {
|
|
rmSync(tmp, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|
|
});
|
|
});
|