mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
76 lines
3.4 KiB
TypeScript
76 lines
3.4 KiB
TypeScript
/**
|
|
* Issue #3061 — No-auth providers (opencode / opencode-zen) infinite
|
|
* account-fallback loop on a persistent upstream error → unbounded DB growth /
|
|
* disk exhaustion.
|
|
*
|
|
* For a no-auth provider, getProviderCredentials early-returns synthetic
|
|
* credentials with connectionId "noauth" BEFORE honoring the exclusion set
|
|
* (src/sse/services/auth.ts: the NOAUTH_PROVIDERS block and the opencode-zen
|
|
* keyless fallback). So when the chat fallback loop marks the failed "noauth"
|
|
* connection and excludes it, the selector hands "noauth" right back → it loops
|
|
* forever, writing key-health + request logs every iteration until the disk
|
|
* fills (see @paraflu's "failure #320" trace in discussion #3038).
|
|
*
|
|
* Loop-breaking invariant under test: once "noauth" is in excludeConnectionIds,
|
|
* the selector MUST return null (no remaining candidate) so the chat handler
|
|
* stops after a single attempt instead of re-selecting the same synthetic
|
|
* connection. The happy-path (nothing excluded → synthetic noauth) must stay
|
|
* intact so keyless access still works.
|
|
*/
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-noauth-loop-3061-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const { getProviderCredentials } = await import("../../src/sse/services/auth.ts");
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
// ── Happy path preserved: first selection (nothing excluded) still works ──
|
|
|
|
test("#3061 opencode no-auth: first selection returns synthetic noauth (happy path preserved)", async () => {
|
|
const creds = await getProviderCredentials("opencode", null, null, "minimax-m2.5-free");
|
|
assert.ok(creds, "opencode must resolve to synthetic no-auth credentials on first selection");
|
|
assert.equal((creds as { connectionId?: string }).connectionId, "noauth");
|
|
assert.equal((creds as { apiKey?: unknown }).apiKey, null);
|
|
});
|
|
|
|
test("#3061 opencode-zen no-auth: first selection returns synthetic noauth (happy path preserved)", async () => {
|
|
const creds = await getProviderCredentials("opencode-zen");
|
|
assert.ok(creds, "opencode-zen must resolve to synthetic no-auth credentials on first selection");
|
|
assert.equal((creds as { connectionId?: string }).connectionId, "noauth");
|
|
});
|
|
|
|
// ── The fix: once "noauth" is excluded, selection MUST stop (return null) ──
|
|
|
|
test("#3061 opencode no-auth: excluding 'noauth' returns null (breaks the fallback loop)", async () => {
|
|
const creds = await getProviderCredentials("opencode", null, null, "minimax-m2.5-free", {
|
|
excludeConnectionIds: ["noauth"],
|
|
});
|
|
assert.equal(
|
|
creds,
|
|
null,
|
|
"after the synthetic noauth connection failed and was excluded, the selector must return " +
|
|
"null instead of handing back 'noauth' (which would loop forever and fill the disk)"
|
|
);
|
|
});
|
|
|
|
test("#3061 opencode-zen no-auth: excluding 'noauth' returns null (breaks the fallback loop)", async () => {
|
|
const creds = await getProviderCredentials("opencode-zen", null, null, null, {
|
|
excludeConnectionIds: ["noauth"],
|
|
});
|
|
assert.equal(
|
|
creds,
|
|
null,
|
|
"excluded synthetic noauth must not be re-selected for the opencode-zen keyless path"
|
|
);
|
|
});
|