Files
OmniRoute/tests/unit/codex-stream-false.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

416 lines
12 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import { OMNIROUTE_RESPONSE_HEADERS } from "../../src/shared/constants/headers.ts";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-codex-stream-false-"));
process.env.DATA_DIR = TEST_DATA_DIR;
const core = await import("../../src/lib/db/core.ts");
const { handleChatCore } = await import("../../open-sse/handlers/chatCore.ts");
const { handleComboChat } = await import("../../open-sse/services/combo.ts");
const { CodexExecutor } = await import("../../open-sse/executors/codex.ts");
const originalFetch = globalThis.fetch;
function noopLog() {
return {
debug() {},
info() {},
warn() {},
error() {},
};
}
function createComboLog() {
const entries = [];
return {
info: (tag, msg) => entries.push({ level: "info", tag, msg }),
warn: (tag, msg) => entries.push({ level: "warn", tag, msg }),
error: (tag, msg) => entries.push({ level: "error", tag, msg }),
entries,
};
}
function createCaptureLog() {
const entries = [];
return {
debug: (tag, msg) => entries.push({ level: "debug", tag, msg }),
info: (tag, msg) => entries.push({ level: "info", tag, msg }),
warn: (tag, msg) => entries.push({ level: "warn", tag, msg }),
error: (tag, msg) => entries.push({ level: "error", tag, msg }),
entries,
};
}
function jsonResponse(body, status = 200) {
return new Response(JSON.stringify(body), {
status,
headers: { "content-type": "application/json" },
});
}
function buildResponsesSse(text = "Brasilia") {
return new Response(
[
"event: response.created",
'data: {"type":"response.created","response":{"id":"resp_1","model":"gpt-5.3-codex","status":"in_progress","output":[]}}',
"",
"event: response.output_text.delta",
`data: ${JSON.stringify({
type: "response.output_text.delta",
output_index: 0,
delta: text,
})}`,
"",
"event: response.completed",
`data: ${JSON.stringify({
type: "response.completed",
response: {
id: "resp_1",
object: "response",
model: "gpt-5.3-codex",
status: "completed",
output: [
{
type: "message",
role: "assistant",
content: [{ type: "output_text", text }],
},
],
usage: { input_tokens: 6, output_tokens: 1 },
},
})}`,
"",
"data: [DONE]",
"",
].join("\n"),
{
status: 200,
headers: { "Content-Type": "text/event-stream" },
}
);
}
function buildResponsesNdjson(text = "Brasilia") {
return new Response(
[
JSON.stringify({
type: "response.created",
response: {
id: "resp_1",
model: "gpt-5.3-codex",
status: "in_progress",
output: [],
},
}),
JSON.stringify({
type: "response.output_text.delta",
output_index: 0,
delta: text,
}),
JSON.stringify({
type: "response.completed",
response: {
id: "resp_1",
object: "response",
model: "gpt-5.3-codex",
status: "completed",
output: [
{
type: "message",
role: "assistant",
content: [{ type: "output_text", text }],
},
],
usage: { input_tokens: 6, output_tokens: 1 },
},
}),
].join("\n"),
{
status: 200,
headers: { "Content-Type": "application/x-ndjson" },
}
);
}
async function resetStorage() {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
async function flushAsyncSideEffects() {
// setImmediate rounds drain the event loop more reliably than setTimeout under CI load.
for (let i = 0; i < 5; i++) await new Promise((resolve) => setImmediate(resolve));
}
async function invokeChatCore({
body,
provider = "openai",
model = "gpt-4o-mini",
endpoint = "/v1/chat/completions",
accept = "application/json",
responseFactory,
log = noopLog(),
} = {}) {
const calls = [];
globalThis.fetch = async (url, init = {}) => {
const headers =
init.headers instanceof Headers
? Object.fromEntries(init.headers.entries())
: init.headers || {};
const call = {
url: String(url),
method: init.method || "GET",
headers,
body: init.body ? JSON.parse(String(init.body)) : null,
};
calls.push(call);
return responseFactory(call);
};
try {
const requestBody = structuredClone(body);
const result = await handleChatCore({
body: requestBody,
modelInfo: { provider, model, extendedContext: false },
credentials: {
apiKey: "sk-test",
accessToken: "codex-token",
providerSpecificData: {},
},
log,
clientRawRequest: {
endpoint,
body: structuredClone(body),
headers: new Headers({ accept }),
},
userAgent: "unit-test",
});
await flushAsyncSideEffects();
return { result, calls, call: calls.at(-1) };
} finally {
globalThis.fetch = originalFetch;
}
}
test.beforeEach(async () => {
globalThis.fetch = originalFetch;
await resetStorage();
});
test.after(async () => {
globalThis.fetch = originalFetch;
await resetStorage();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("CodexExecutor.transformRequest clones the request body before forcing stream=true", () => {
const executor = new CodexExecutor();
const body = {
model: "gpt-5.6-sol",
input: [{ role: "user", content: [{ type: "input_text", text: "Oi" }] }],
stream: false,
reasoning: { effort: "low" },
};
const original = structuredClone(body);
const transformed = executor.transformRequest("gpt-5.6-sol", body, false, {
requestEndpointPath: "/responses",
});
assert.notStrictEqual(transformed, body);
assert.deepEqual(body, original);
assert.equal(transformed.stream, true);
});
test("chatCore converts Responses-style SSE fallback into JSON when stream=false", async () => {
const { result, call } = await invokeChatCore({
body: {
model: "gpt-4o-mini",
stream: false,
messages: [{ role: "user", content: "Qual a capital do Brasil?" }],
},
provider: "openai",
model: "gpt-4o-mini",
responseFactory: () => buildResponsesSse("Brasilia"),
});
const payload = (await result.response.json()) as any;
assert.equal(result.success, true);
assert.equal(call.headers.Accept || call.headers.accept, "application/json");
assert.equal(payload.object, "chat.completion");
assert.equal(payload.choices[0].message.content, "Brasilia");
assert.ok(payload.usage.total_tokens >= 7);
assert.ok(payload.usage.prompt_tokens > 0);
assert.ok(payload.usage.completion_tokens > 0);
});
test("chatCore buffers expected Codex upstream SSE without warning for stream=false clients", async () => {
const log = createCaptureLog();
const { result, call } = await invokeChatCore({
body: {
model: "gpt-5.3-codex",
stream: false,
messages: [{ role: "user", content: "Qual a capital do Brasil?" }],
},
provider: "codex",
model: "gpt-5.3-codex",
responseFactory: () => buildResponsesSse("Brasilia"),
log,
});
const payload = (await result.response.json()) as any;
assert.equal(result.success, true);
assert.equal(call.headers.Accept || call.headers.accept, "text/event-stream");
assert.equal(call.body.stream, true);
assert.equal(payload.choices[0].message.content, "Brasilia");
assert.equal(
log.entries.some(
(entry) =>
entry.level === "warn" &&
String(entry.msg).includes("Unexpected SSE response for non-streaming request")
),
false
);
assert.equal(
log.entries.some(
(entry) =>
entry.level === "debug" &&
String(entry.msg).includes("Buffering upstream SSE response for non-streaming client")
),
true
);
});
test("chatCore converts Responses-style NDJSON fallback into JSON when stream=false", async () => {
const { result, call } = await invokeChatCore({
body: {
model: "gpt-4o-mini",
stream: false,
messages: [{ role: "user", content: "Qual a capital do Brasil?" }],
},
provider: "openai",
model: "gpt-4o-mini",
responseFactory: () => buildResponsesNdjson("Brasilia"),
});
const payload = (await result.response.json()) as any;
assert.equal(result.success, true);
assert.equal(call.headers.Accept || call.headers.accept, "application/json");
assert.equal(payload.object, "chat.completion");
assert.equal(payload.choices[0].message.content, "Brasilia");
assert.ok(payload.usage.total_tokens >= 7);
});
test("handleComboChat validates non-stream quality using the original client stream intent", async () => {
const combo = {
name: "codex-stream-false-quality",
models: ["codex/gpt-5.6-sol", "openai/gpt-4o-mini"],
};
const log = createComboLog();
const seenModels = [];
const result = await handleComboChat({
body: {
stream: false,
messages: [{ role: "user", content: "Qual a capital do Brasil?" }],
},
combo,
handleSingleModel: async (requestBody, modelStr) => {
seenModels.push(modelStr);
if (modelStr === "codex/gpt-5.6-sol") {
requestBody.stream = true;
return jsonResponse({
choices: [
{ index: 0, message: { role: "assistant", content: "" }, finish_reason: "stop" },
],
});
}
return jsonResponse({
choices: [
{
index: 0,
message: { role: "assistant", content: "Brasilia" },
finish_reason: "stop",
},
],
});
},
isModelAvailable: async () => true,
log,
settings: null,
allCombos: null,
});
const payload = (await result.json()) as any;
assert.equal(result.ok, true);
assert.deepEqual(seenModels, ["codex/gpt-5.6-sol", "openai/gpt-4o-mini"]);
assert.equal(payload.choices[0].message.content, "Brasilia");
assert.ok(
log.entries.some(
(entry) =>
entry.level === "warn" &&
String(entry.msg).includes(
"failed quality check: empty content and no tool_calls in response"
)
)
);
});
test("non-stream chat success carries cost-telemetry meta headers (cost/version/tokens)", async () => {
// Regression guard: the single non-stream success return in chatCore.ts routes
// through attachOmniRouteMetaHeaders, which must always emit the cost-telemetry
// headers. A usage-bearing JSON upstream body proves real usage flowed through.
const { result } = await invokeChatCore({
body: {
model: "gpt-4o-mini",
stream: false,
messages: [{ role: "user", content: "Qual a capital do Brasil?" }],
},
provider: "openai",
model: "gpt-4o-mini",
responseFactory: () =>
jsonResponse({
id: "chatcmpl-cost-header",
object: "chat.completion",
model: "gpt-4o-mini",
choices: [
{
index: 0,
message: { role: "assistant", content: "Brasilia" },
finish_reason: "stop",
},
],
usage: { prompt_tokens: 10, completion_tokens: 5, total_tokens: 15 },
}),
});
assert.equal(result.success, true);
const headers = result.response.headers;
const cost = headers.get(OMNIROUTE_RESPONSE_HEADERS.responseCost);
assert.equal(typeof cost, "string");
// 10-decimal cost format; 0.0000000000 is valid when no pricing is available.
assert.match(String(cost), /^\d+\.\d{10}$/);
const version = headers.get(OMNIROUTE_RESPONSE_HEADERS.version);
assert.equal(typeof version, "string");
assert.ok(String(version).length > 0);
// Real usage from the upstream body must surface as token-count headers.
assert.equal(headers.get(OMNIROUTE_RESPONSE_HEADERS.tokensIn), "10");
assert.equal(headers.get(OMNIROUTE_RESPONSE_HEADERS.tokensOut), "5");
});