Files
OmniRoute/tests/unit/compression/rtk-mcp-tools.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

90 lines
3.7 KiB
TypeScript

import { describe, it, beforeEach, after } from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
// T07 — omniroute_rtk_discover / omniroute_rtk_learn MCP tools (read-only; audited).
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omni-rtk-mcp-"));
process.env.DATA_DIR = TEST_DATA_DIR;
const core = await import("../../../src/lib/db/core.ts");
const { handleRtkDiscover, handleRtkLearn } =
await import("../../../open-sse/mcp-server/tools/compressionTools.ts");
const { maybePersistRtkRawOutput } =
await import("../../../open-sse/services/compression/engines/rtk/rawOutput.ts");
const { getRecentAuditEntries } = await import("../../../open-sse/mcp-server/audit.ts");
const NOISE = [
"Welcome to Gradle 8.5!",
"> Task :app:compileJava UP-TO-DATE",
"Downloading https://repo1.maven.org/foo.jar",
"BUILD SUCCESSFUL in 12s",
].join("\n");
function seedSamples() {
// retention "always" forces a capture even on a successful (non-failure) output.
// The two captures MUST differ in content: the raw-output filename is keyed on
// Date.now() (ms) + a hash of the content (see rawOutput.ts), so two BYTE-IDENTICAL
// captures that land in the same millisecond collapse to the same filename — the 2nd
// write overwrites the 1st, leaving only 1 sample. That made this test ~25% flaky on
// fast CI runners ("expected 2, got 1"). Distinct content = 2 files regardless of
// timing; two real build runs never emit byte-identical output anyway.
maybePersistRtkRawOutput(NOISE, { retention: "always", command: "gradle build" });
maybePersistRtkRawOutput(`${NOISE}\n> Task :app:test UP-TO-DATE`, {
retention: "always",
command: "gradle build",
});
}
beforeEach(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
core.getDbInstance(); // run migrations → mcp_tool_audit table exists
});
after(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
describe("RTK MCP tools (T07)", () => {
it("omniroute_rtk_discover returns ranked noise candidates from the sample store", async () => {
seedSamples();
const result = await handleRtkDiscover({ limit: 100 });
assert.equal(typeof result.sampleCount, "number");
assert.ok(result.sampleCount >= 2, `expected the 2 seeded samples, got ${result.sampleCount}`);
assert.ok(Array.isArray(result.candidates));
});
it("omniroute_rtk_learn returns a filter draft for a specific command", async () => {
seedSamples();
const result = await handleRtkLearn({ command: "gradle build", limit: 100 });
assert.equal(result.command, "gradle build");
assert.ok(result.sampleCount >= 1, "expected at least one matching sample");
assert.ok(
result.filter && typeof result.filter === "object",
"expected a suggested filter draft"
);
});
it("returns an empty/baseline result with no samples (no throw)", async () => {
const discover = await handleRtkDiscover({});
assert.equal(discover.sampleCount, 0);
assert.deepEqual(discover.candidates, []);
const learn = await handleRtkLearn({ command: "npm test" });
assert.equal(learn.sampleCount, 0);
});
it("both tools are audited in mcp_tool_audit", async () => {
await handleRtkDiscover({});
await handleRtkLearn({ command: "gradle build" });
const entries = await getRecentAuditEntries(20);
const names = entries.map((e) => e.toolName);
assert.ok(names.includes("omniroute_rtk_discover"), "discover must be audited");
assert.ok(names.includes("omniroute_rtk_learn"), "learn must be audited");
});
});