Files
OmniRoute/tests/unit/conversations-tree-route-seq-param.test.ts
Praveen K Palaniswamy 65e81158ab fix(ollama): route models by advertised capability (#11088)
Landed with the design call resolved per the owner's pick — **option 1**: the synced store is now endpoint-agnostic (persistDiscoveredModels and managedModelImport no longer drop non-chat models at write time), and chat selectability moved to read time (auto-pool expansion in autoStrategy applies filterChatSelectableModels; the models-route projection already had its chatOnly filter). Your discovery test now passes end-to-end (3/3): /api/show capabilities persist per connection and image/embedding requests route through the advertising host.

Reconciliation notes: conflicted areas merged onto the current tip (adobe discovery import, requestedModel preflight signature, resolvedProvider fast-path coexists with the synced-route override — explicit resolution wins); carried base-red drains (#10055 memoization, #11071 test variants) dropped as already-landed; the managed-model-import exclusion test was propagated to the new contract (image/video models persist; the read filter still hides them from chat pickers — pinned by a new assertion). Full battery: 205/206 focused (the one red is a confirmed periodic-timer timing flake on the loaded devbox — 20/20 isolated), autoCombo vitest 30/30, combo suites 46/46, gates + typecheck clean.

Thank you @yourspraveen — the capability probe + routing design was right; it just needed the store contract opened up. Fixes #11087.
2026-08-23 11:45:01 -03:00

31 lines
1.2 KiB
TypeScript

/**
* Regression test for /api/conversations/[id]/tree's query-param parsing.
*
* Real bug: `Number(searchParams.get("beforeSeq"))` is 0 (not NaN) when the
* param is absent, since `Number(null) === 0`. That made an ABSENT
* beforeSeq/afterSeq look like "beforeSeq=0"/"afterSeq=0" was explicitly
* given, which — because the DB layer checks `opts.afterSeq != null` (true
* for 0) BEFORE checking limit — forced every single request into the
* uncapped "poll for new turns" branch, ignoring `limit` entirely and
* returning the conversation's ENTIRE history on every load.
*/
import test from "node:test";
import assert from "node:assert/strict";
import { parseSeqParam } from "../../src/app/api/conversations/[id]/tree/route.ts";
test("parseSeqParam: an absent query param returns undefined, not 0", () => {
assert.equal(parseSeqParam(null), undefined);
assert.equal(parseSeqParam(""), undefined);
});
test("parseSeqParam: a real numeric string parses to that number, including a literal '0'", () => {
assert.equal(parseSeqParam("0"), 0);
assert.equal(parseSeqParam("42"), 42);
});
test("parseSeqParam: a non-numeric string returns undefined rather than NaN", () => {
assert.equal(parseSeqParam("not-a-number"), undefined);
});