mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
89 lines
3.6 KiB
TypeScript
89 lines
3.6 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-bare-routing-fallback-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const providersDb = await import("../../src/lib/db/providers.ts");
|
|
const { getModelInfoCore } = await import("../../open-sse/services/model.ts");
|
|
|
|
// #FIX: end-to-end precedence checks for bare model routing. These guard
|
|
// the contract that:
|
|
// - Bare Codex-default model ids (gpt-5.6-sol, gpt-5.5, etc.) route to
|
|
// `codex` ahead of any other provider that also catalogs them — bounded by
|
|
// #9447 to installs where a codex connection is actually ACTIVE, so an
|
|
// OpenAI-only install is not handed a provider it has no credentials for.
|
|
// Ids that only codex catalogs (the tier variants) need no connection:
|
|
// there is no alternative provider to preempt.
|
|
// - Bare model ids shared between providers (e.g. claude-opus-5 across
|
|
// anthropic/claude/github/agentrouter/etc.) never silently route to a
|
|
// provider whose static registry does NOT actually catalog them (the
|
|
// kiro-synced-catalog bug).
|
|
// - Explicit `provider/model` prefixes always win over the bare inference.
|
|
|
|
test.before(async () => {
|
|
await providersDb.createProviderConnection({
|
|
provider: "codex",
|
|
authType: "oauth",
|
|
email: "codex@example.com",
|
|
providerSpecificData: { workspaceId: "ws-routing-fallback" },
|
|
});
|
|
});
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("bare gpt-5.6-sol routes to codex (precedence via CODEX_NATIVE_UNPREFIXED_MODELS)", async () => {
|
|
const info = await getModelInfoCore("gpt-5.6-sol", null);
|
|
assert.equal(
|
|
info.provider,
|
|
"codex",
|
|
"bare gpt-5.6-sol must route to codex — the Codex CLI default"
|
|
);
|
|
});
|
|
|
|
test("bare gpt-5.5 routes to codex", async () => {
|
|
const info = await getModelInfoCore("gpt-5.5", null);
|
|
assert.equal(info.provider, "codex");
|
|
});
|
|
|
|
test("bare gpt-5.6-sol-xhigh (a tier id) routes to codex", async () => {
|
|
const info = await getModelInfoCore("gpt-5.6-sol-xhigh", null);
|
|
assert.equal(info.provider, "codex");
|
|
});
|
|
|
|
test("explicit prefix overrides bare precedence (agentrouter/gpt-5.6-sol)", async () => {
|
|
const info = await getModelInfoCore("agentrouter/gpt-5.6-sol", null);
|
|
assert.equal(info.provider, "agentrouter");
|
|
});
|
|
|
|
test("explicit prefix overrides bare precedence (openai/gpt-5.6-sol)", async () => {
|
|
const info = await getModelInfoCore("openai/gpt-5.6-sol", null);
|
|
assert.equal(info.provider, "openai");
|
|
});
|
|
|
|
test("bare claude-opus-5 never resolves to kiro (synced-catalog validation)", async () => {
|
|
// The bug: a kiro connection had claude-opus-5 in its synced /v1/models
|
|
// cache (likely from a brief upstream quirk). The bare-routing path
|
|
// accepted it as a candidate and routed traffic there, which then 404'd
|
|
// because kiro's static registry never cataloged claude-opus-5.
|
|
// The fix: validated synced candidates against the static registry.
|
|
const info = await getModelInfoCore("claude-opus-5", null);
|
|
assert.notEqual(
|
|
info.provider,
|
|
"kiro",
|
|
`kiro must NOT win bare claude-opus-5 routing — it does not catalog the model`
|
|
);
|
|
});
|
|
|
|
test("bare claude-opus-4-8 also never resolves to kiro (same fix must apply to all shared models)", async () => {
|
|
const info = await getModelInfoCore("claude-opus-4-8", null);
|
|
assert.notEqual(info.provider, "kiro");
|
|
});
|