Files
OmniRoute/tests/unit/model-test-route.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

149 lines
4.5 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import { makeManagementSessionRequest } from "../helpers/managementSession.ts";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-model-test-route-"));
const ORIGINAL_DATA_DIR = process.env.DATA_DIR;
const ORIGINAL_INITIAL_PASSWORD = process.env.INITIAL_PASSWORD;
const ORIGINAL_REQUIRE_API_KEY = process.env.REQUIRE_API_KEY;
const ORIGINAL_JWT_SECRET = process.env.JWT_SECRET;
process.env.DATA_DIR = TEST_DATA_DIR;
const core = await import("../../src/lib/db/core.ts");
const providersDb = await import("../../src/lib/db/providers.ts");
const settingsDb = await import("../../src/lib/db/settings.ts");
const route = await import("../../src/app/api/models/test/route.ts");
const originalFetch = globalThis.fetch;
async function resetStorage() {
core.resetDbInstance();
delete process.env.INITIAL_PASSWORD;
delete process.env.REQUIRE_API_KEY;
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
function makeRequest(headers?: HeadersInit) {
return new Request("http://localhost/api/models/test", {
method: "POST",
headers: {
"content-type": "application/json",
...headers,
},
body: JSON.stringify({ providerId: "openai", modelId: "gpt-4o-2024-11-20" }),
});
}
test.beforeEach(async () => {
globalThis.fetch = originalFetch;
await resetStorage();
});
test.afterEach(() => {
globalThis.fetch = originalFetch;
});
test.after(async () => {
globalThis.fetch = originalFetch;
await resetStorage();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
if (ORIGINAL_DATA_DIR === undefined) {
delete process.env.DATA_DIR;
} else {
process.env.DATA_DIR = ORIGINAL_DATA_DIR;
}
if (ORIGINAL_INITIAL_PASSWORD === undefined) {
delete process.env.INITIAL_PASSWORD;
} else {
process.env.INITIAL_PASSWORD = ORIGINAL_INITIAL_PASSWORD;
}
if (ORIGINAL_REQUIRE_API_KEY === undefined) {
delete process.env.REQUIRE_API_KEY;
} else {
process.env.REQUIRE_API_KEY = ORIGINAL_REQUIRE_API_KEY;
}
if (ORIGINAL_JWT_SECRET === undefined) {
delete process.env.JWT_SECRET;
} else {
process.env.JWT_SECRET = ORIGINAL_JWT_SECRET;
}
});
test("model test route requires management auth when login protection is enabled", async () => {
process.env.INITIAL_PASSWORD = "bootstrap-password";
await settingsDb.updateSettings({ requireLogin: true, password: "" });
const unauthenticated = await route.POST(makeRequest());
const invalidToken = await route.POST(
makeRequest({
authorization: "Bearer sk-invalid",
})
);
const unauthenticatedBody = (await unauthenticated.json()) as any;
const invalidTokenBody = (await invalidToken.json()) as any;
assert.equal(unauthenticated.status, 401);
assert.equal(unauthenticatedBody.error.message, "Authentication required");
assert.equal(invalidToken.status, 403);
assert.equal(invalidTokenBody.error.message, "Invalid management token");
});
test("model test route ignores forwarded hosts and works in strict API-key mode", async () => {
process.env.REQUIRE_API_KEY = "true";
await providersDb.createProviderConnection({
provider: "openai",
authType: "apikey",
name: "openai-model-test",
apiKey: "sk-model-test",
isActive: true,
testStatus: "active",
providerSpecificData: {},
});
const fetchCalls: string[] = [];
globalThis.fetch = async (url) => {
const urlString = String(url);
fetchCalls.push(urlString);
assert.equal(urlString.includes("evil.example"), false);
return Response.json({
id: "chatcmpl-model-test",
choices: [
{
message: {
role: "assistant",
content: "OK",
},
},
],
});
};
const response = await route.POST(
await makeManagementSessionRequest("http://localhost/api/models/test", {
method: "POST",
headers: {
"x-forwarded-host": "evil.example",
"x-forwarded-proto": "https",
},
body: { providerId: "openai", modelId: "gpt-4o-2024-11-20" },
})
);
const body = (await response.json()) as any;
assert.equal(response.status, 200);
assert.equal(body.status, "ok");
assert.equal(body.responseText, "OK");
assert.equal(fetchCalls.length, 1);
assert.match(fetchCalls[0], /\/chat\/completions$/);
});